From: Jakub Kicinski <kuba@kernel.org>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jeroendb@google.com, andrew+netdev@lunn.ch,
willemb@google.com, ziweixiao@google.com,
pkaligineedi@google.com, yyd@google.com, joshwash@google.com,
shailend@google.com, linux@treblig.org, thostet@google.com,
jfraker@google.com, richardcochran@gmail.com, jdamato@fastly.com,
vadim.fedorenko@linux.dev, horms@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 5/8] gve: Add support to query the nic clock
Date: Tue, 27 May 2025 19:12:40 -0700 [thread overview]
Message-ID: <20250527191240.455b6752@kernel.org> (raw)
In-Reply-To: <20250522235737.1925605-6-hramamurthy@google.com>
On Thu, 22 May 2025 23:57:34 +0000 Harshitha Ramamurthy wrote:
> + err = gve_ptp_init(priv);
> + if (err)
> + return err;
> +
> + priv->nic_ts_report =
> + dma_alloc_coherent(&priv->pdev->dev,
> + sizeof(struct gve_nic_ts_report),
> + &priv->nic_ts_report_bus,
> + GFP_KERNEL);
> + if (!priv->nic_ts_report) {
> + dev_err(&priv->pdev->dev, "%s dma alloc error\n", __func__);
missing a call to gve_ptp_release() on this error path?
> + return -ENOMEM;
> + }
--
pw-bot: cr
next prev parent reply other threads:[~2025-05-28 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 23:57 [PATCH net-next v3 0/8] gve: Add Rx HW timestamping support Harshitha Ramamurthy
2025-05-22 23:57 ` [PATCH net-next v3 1/8] gve: Add device option for nic clock synchronization Harshitha Ramamurthy
2025-05-22 23:57 ` [PATCH net-next v3 2/8] gve: Add adminq command to report nic timestamp Harshitha Ramamurthy
2025-05-22 23:57 ` [PATCH net-next v3 3/8] gve: Add initial PTP device support Harshitha Ramamurthy
2025-05-22 23:57 ` [PATCH net-next v3 4/8] gve: Add adminq lock for queues creation and destruction Harshitha Ramamurthy
2025-05-22 23:57 ` [PATCH net-next v3 5/8] gve: Add support to query the nic clock Harshitha Ramamurthy
2025-05-24 21:58 ` Vadim Fedorenko
2025-05-28 2:12 ` Jakub Kicinski [this message]
2025-05-28 16:56 ` Ziwei Xiao
2025-05-22 23:57 ` [PATCH net-next v3 6/8] gve: Add rx hardware timestamp expansion Harshitha Ramamurthy
2025-05-24 21:59 ` Vadim Fedorenko
2025-05-22 23:57 ` [PATCH net-next v3 7/8] gve: Implement ndo_hwtstamp_get/set for RX timestamping Harshitha Ramamurthy
2025-05-22 23:57 ` [PATCH net-next v3 8/8] gve: Advertise support for rx hardware timestamping Harshitha Ramamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527191240.455b6752@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jdamato@fastly.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=joshwash@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=richardcochran@gmail.com \
--cc=shailend@google.com \
--cc=thostet@google.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
--cc=yyd@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.