All of lore.kernel.org
 help / color / mirror / Atom feed
From: Penny Zheng <Penny.Zheng@amd.com>
To: <xen-devel@lists.xenproject.org>
Cc: ray.huang@amd.com, "Penny Zheng" <Penny.Zheng@amd.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>,
	"Bertrand Marquis" <bertrand.marquis@arm.com>,
	"Michal Orzel" <michal.orzel@amd.com>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Anthony PERARD" <anthony.perard@vates.tech>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Bob Eshleman" <bobbyeshleman@gmail.com>,
	"Connor Davis" <connojdavis@gmail.com>,
	"Oleksii Kurochko" <oleksii.kurochko@gmail.com>
Subject: [PATCH v4 16/20] xen/sysctl: wrap around XEN_SYSCTL_physinfo
Date: Wed, 28 May 2025 17:17:04 +0800	[thread overview]
Message-ID: <20250528091708.390767-17-Penny.Zheng@amd.com> (raw)
In-Reply-To: <20250528091708.390767-1-Penny.Zheng@amd.com>

The following functions are only used to deal with XEN_SYSCTL_physinfo,
then they shall be wrapped:
- arch_do_physinfo()
- get_outstanding_claims()

Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v1 -> v2:
- no need to wrap declaration
- add transient #ifdef in sysctl.c for correct compilation
---
v2 -> v3:
- move #endif up ahead of the blank line
---
v3 -> v4:
- remove transient "#ifdef CONFIG_SYSCTL"
---
 xen/arch/arm/sysctl.c   | 2 ++
 xen/arch/riscv/stubs.c  | 2 ++
 xen/arch/x86/sysctl.c   | 2 ++
 xen/common/page_alloc.c | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c
index 32cab4feff..2d350b700a 100644
--- a/xen/arch/arm/sysctl.c
+++ b/xen/arch/arm/sysctl.c
@@ -15,6 +15,7 @@
 #include <asm/arm64/sve.h>
 #include <public/sysctl.h>
 
+#ifdef CONFIG_SYSCTL
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
 {
     pi->capabilities |= XEN_SYSCTL_PHYSCAP_hvm | XEN_SYSCTL_PHYSCAP_hap;
@@ -22,6 +23,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
     pi->arch_capabilities |= MASK_INSR(sve_encode_vl(get_sys_vl_len()),
                                        XEN_SYSCTL_PHYSCAP_ARM_SVE_MASK);
 }
+#endif
 
 long arch_do_sysctl(struct xen_sysctl *sysctl,
                     XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
diff --git a/xen/arch/riscv/stubs.c b/xen/arch/riscv/stubs.c
index 83416d3350..295456d0c8 100644
--- a/xen/arch/riscv/stubs.c
+++ b/xen/arch/riscv/stubs.c
@@ -321,10 +321,12 @@ long arch_do_sysctl(struct xen_sysctl *sysctl,
     BUG_ON("unimplemented");
 }
 
+#ifdef CONFIG_SYSCTL
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
 {
     BUG_ON("unimplemented");
 }
+#endif /* CONFIG_SYSCTL */
 
 /* p2m.c */
 
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index 1b04947516..f64addbe2b 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -91,6 +91,7 @@ static long cf_check smt_up_down_helper(void *data)
     return ret;
 }
 
+#ifdef CONFIG_SYSCTL
 void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
 {
     memcpy(pi->hw_cap, boot_cpu_data.x86_capability,
@@ -104,6 +105,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
     if ( IS_ENABLED(CONFIG_SHADOW_PAGING) )
         pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow;
 }
+#endif /* CONFIG_SYSCTL */
 
 long arch_do_sysctl(
     struct xen_sysctl *sysctl, XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index dec4cb2ab1..8177d12f50 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -601,6 +601,7 @@ out:
     return ret;
 }
 
+#ifdef CONFIG_SYSCTL
 void get_outstanding_claims(uint64_t *free_pages, uint64_t *outstanding_pages)
 {
     spin_lock(&heap_lock);
@@ -608,6 +609,7 @@ void get_outstanding_claims(uint64_t *free_pages, uint64_t *outstanding_pages)
     *free_pages = avail_heap_pages(MEMZONE_XEN + 1, NR_ZONES - 1, -1);
     spin_unlock(&heap_lock);
 }
+#endif /* CONFIG_SYSCTL */
 
 static bool __read_mostly first_node_initialised;
 #ifndef CONFIG_SEPARATE_XENHEAP
-- 
2.34.1



  parent reply	other threads:[~2025-05-28  9:21 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-28  9:16 [PATCH v4 00/20] xen: introduce CONFIG_SYSCTL Penny Zheng
2025-05-28  9:16 ` [PATCH v4 01/20] xen/pmstat: consolidate code into pmstat.c Penny Zheng
2025-06-11 11:47   ` Jan Beulich
2025-06-18 10:28   ` Jan Beulich
2025-05-28  9:16 ` [PATCH v4 02/20] xen: make avail_domheap_pages() inlined into get_outstanding_claims() Penny Zheng
2025-05-28  9:16 ` [PATCH v4 03/20] xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE" Penny Zheng
2025-05-29 23:22   ` Stefano Stabellini
2025-06-10 13:00   ` Jan Beulich
2025-06-12  4:09     ` Penny, Zheng
2025-06-12  7:01       ` Jan Beulich
2025-06-12  8:52         ` Penny, Zheng
2025-06-12  9:27           ` Jan Beulich
2025-05-28  9:16 ` [PATCH v4 04/20] xen: introduce CONFIG_SYSCTL Penny Zheng
2025-06-10 13:05   ` Jan Beulich
2025-06-10 13:54     ` Jan Beulich
2025-06-12  4:35     ` Penny, Zheng
2025-06-12  7:13       ` Jan Beulich
2025-05-28  9:16 ` [PATCH v4 05/20] xen/xsm: wrap around xsm_sysctl with CONFIG_SYSCTL Penny Zheng
2025-05-28  9:16 ` [PATCH v4 06/20] xen/sysctl: wrap around XEN_SYSCTL_readconsole Penny Zheng
2025-05-28  9:16 ` [PATCH v4 07/20] xen/sysctl: make CONFIG_TRACEBUFFER depend on CONFIG_SYSCTL Penny Zheng
2025-05-28  9:16 ` [PATCH v4 08/20] xen/sysctl: wrap around XEN_SYSCTL_sched_id Penny Zheng
2025-05-28  9:16 ` [PATCH v4 09/20] xen/sysctl: wrap around XEN_SYSCTL_perfc_op Penny Zheng
2025-05-28  9:16 ` [PATCH v4 10/20] xen/sysctl: wrap around XEN_SYSCTL_lockprof_op Penny Zheng
2025-05-28  9:16 ` [PATCH v4 11/20] xen/pmstat: introduce CONFIG_PM_OP Penny Zheng
2025-06-10 13:40   ` Jan Beulich
2025-06-12  7:00     ` Penny, Zheng
2025-06-12  7:22       ` Jan Beulich
2025-05-28  9:17 ` [PATCH v4 12/20] xen/sysctl: introduce CONFIG_PM_STATS Penny Zheng
2025-06-10 13:42   ` Jan Beulich
2025-05-28  9:17 ` [PATCH v4 13/20] xen/sysctl: wrap around XEN_SYSCTL_page_offline_op Penny Zheng
2025-05-28  9:17 ` [PATCH v4 14/20] xen/sysctl: wrap around XEN_SYSCTL_cpupool_op Penny Zheng
2025-05-28  9:17 ` [PATCH v4 15/20] xen/sysctl: wrap around XEN_SYSCTL_scheduler_op Penny Zheng
2025-05-28  9:17 ` Penny Zheng [this message]
2025-05-28  9:17 ` [PATCH v4 17/20] xen/sysctl: make CONFIG_COVERAGE depend on CONFIG_SYSCTL Penny Zheng
2025-06-10 13:47   ` Jan Beulich
2025-06-13  6:35     ` Penny, Zheng
2025-05-28  9:17 ` [PATCH v4 18/20] xen/sysctl: make CONFIG_LIVEPATCH " Penny Zheng
2025-05-28  9:17 ` [PATCH v4 19/20] xen/sysctl: wrap around arch-specific arch_do_sysctl Penny Zheng
2025-05-28  9:17 ` [PATCH v4 20/20] xen/sysctl: wrap around sysctl hypercall Penny Zheng
2025-06-10 13:53   ` Jan Beulich
2025-06-13  8:57     ` Penny, Zheng
2025-06-10 13:36 ` [PATCH v4 00/20] xen: introduce CONFIG_SYSCTL Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250528091708.390767-17-Penny.Zheng@amd.com \
    --to=penny.zheng@amd.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=alistair.francis@wdc.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=bertrand.marquis@arm.com \
    --cc=bobbyeshleman@gmail.com \
    --cc=connojdavis@gmail.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=ray.huang@amd.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.