From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: bpf@vger.kernel.org
Cc: Jiayuan Chen <jiayuan.chen@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>, Feng Yang <yangfeng@kylinos.cn>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH bpf-next v1 2/2] bpf/selftests: Add test cases for retrieving classid
Date: Thu, 29 May 2025 00:16:26 +0800 [thread overview]
Message-ID: <20250528161653.55162-2-jiayuan.chen@linux.dev> (raw)
In-Reply-To: <20250528161653.55162-1-jiayuan.chen@linux.dev>
Covers all scenarios where classid can be retrieved with bpf.
./test_progs -a cgroup_get_classid
53/1 cgroup_get_classid/get classid from tc:OK
53/2 cgroup_get_classid/get classid from sysctl:OK
53/3 cgroup_get_classid/get classid from cgroup dev:OK
53/4 cgroup_get_classid/get classid from cgroup sockopt:OK
53 cgroup_get_classid:OK
Summary: 1/4 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
---
.../selftests/bpf/prog_tests/cgroup_classid.c | 212 ++++++++++++++++++
.../selftests/bpf/progs/test_cgroup_classid.c | 51 +++++
2 files changed, 263 insertions(+)
create mode 100644 tools/testing/selftests/bpf/prog_tests/cgroup_classid.c
create mode 100644 tools/testing/selftests/bpf/progs/test_cgroup_classid.c
diff --git a/tools/testing/selftests/bpf/prog_tests/cgroup_classid.c b/tools/testing/selftests/bpf/prog_tests/cgroup_classid.c
new file mode 100644
index 000000000000..f00da952e52c
--- /dev/null
+++ b/tools/testing/selftests/bpf/prog_tests/cgroup_classid.c
@@ -0,0 +1,212 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <sys/types.h>
+#include <unistd.h>
+#include <test_progs.h>
+#include "cgroup_helpers.h"
+#include "network_helpers.h"
+#include "test_cgroup_classid.skel.h"
+
+#define TEST_CGROUP "/cgroup_classid"
+
+static int test_cgroup_get_classid_from_tc(int cgroup_fd, int srv_fd, int srv_port, bool egress)
+{
+ struct test_cgroup_classid *skel;
+ int cli_fd = -1, ret = -1, expected;
+
+ LIBBPF_OPTS(bpf_tcx_opts, optl);
+
+ skel = test_cgroup_classid__open_and_load();
+ if (!ASSERT_OK_PTR(skel, "skel_open"))
+ return ret;
+
+ skel->bss->classid = -1;
+ if (egress) {
+ expected = getpid();
+ skel->links.tc_egress =
+ bpf_program__attach_tcx(skel->progs.tc_egress, 1, &optl);
+ } else {
+ expected = 0;
+ skel->links.tc_ingress =
+ bpf_program__attach_tcx(skel->progs.tc_ingress, 1, &optl);
+ }
+
+ cli_fd = connect_to_fd_opts(srv_fd, NULL);
+ if (!ASSERT_GE(cli_fd, 0, "connect_to_fd_opts"))
+ goto out;
+
+ ASSERT_EQ(skel->bss->classid, expected, "classid mismatch");
+ ret = 0;
+out:
+ if (cli_fd > 0)
+ close(cli_fd);
+
+ test_cgroup_classid__destroy(skel);
+ return ret;
+}
+
+static void test_cgroup_get_classid_tc(void)
+{
+ int srv_fd = -1, srv_port = -1;
+ int cgroup_fd = -1;
+
+ setup_classid_environment();
+ set_classid();
+ join_classid();
+
+ cgroup_fd = open_classid();
+ if (!ASSERT_GE(cgroup_fd, 0, "open_classid"))
+ goto out;
+
+ srv_fd = start_server(AF_INET, SOCK_STREAM, NULL, 0, 0);
+ if (!ASSERT_GE(srv_fd, 0, "srv_fd"))
+ goto out;
+
+ srv_port = get_socket_local_port(srv_fd);
+ if (!ASSERT_GE(srv_port, 0, "get_socket_local_port"))
+ goto out;
+
+ ASSERT_OK(test_cgroup_get_classid_from_tc(cgroup_fd, srv_fd, srv_port, 1), "egress");
+ ASSERT_OK(test_cgroup_get_classid_from_tc(cgroup_fd, srv_fd, srv_port, 0), "ingress");
+out:
+ if (srv_fd > 0)
+ close(srv_fd);
+ if (cgroup_fd > 0)
+ close(cgroup_fd);
+ cleanup_classid_environment();
+}
+
+static void test_cgroup_get_classid_cgroup_dev(void)
+{
+ struct test_cgroup_classid *skel = NULL;
+ int cgroup_fd = -1;
+
+ cgroup_fd = test__join_cgroup(TEST_CGROUP);
+ if (!ASSERT_GE(cgroup_fd, 0, "join cgroup"))
+ goto out;
+
+ if (!ASSERT_OK(setup_classid_environment(), "setup env"))
+ goto out;
+
+ if (!ASSERT_OK(set_classid(), "set_classid"))
+ goto out;
+
+ skel = test_cgroup_classid__open_and_load();
+ if (!ASSERT_OK_PTR(skel, "load program"))
+ goto out;
+
+ skel->links.cg_dev =
+ bpf_program__attach_cgroup(skel->progs.cg_dev, cgroup_fd);
+
+ if (!ASSERT_OK_PTR(skel->links.cg_dev, "attach_program"))
+ goto out;
+
+ skel->bss->classid = -1;
+ if (!ASSERT_OK(join_classid(), "join_classid"))
+ goto out;
+
+ open("/dev/null", O_RDWR);
+ ASSERT_EQ(skel->bss->classid, getpid(), "classid mismatch");
+out:
+ if (cgroup_fd > 0)
+ close(cgroup_fd);
+ test_cgroup_classid__destroy(skel);
+ cleanup_classid_environment();
+}
+
+static void test_cgroup_get_classid_sysctl(void)
+{
+ struct test_cgroup_classid *skel = NULL;
+ int cgroup_fd = -1;
+
+ cgroup_fd = test__join_cgroup(TEST_CGROUP);
+ if (!ASSERT_GE(cgroup_fd, 0, "join cgroup"))
+ goto out;
+
+ if (!ASSERT_OK(setup_classid_environment(), "setup env"))
+ goto out;
+
+ if (!ASSERT_OK(set_classid(), "set_classid"))
+ goto out;
+
+ skel = test_cgroup_classid__open_and_load();
+ if (!ASSERT_OK_PTR(skel, "load program"))
+ goto out;
+
+ skel->links.sysctl_tcp_mem =
+ bpf_program__attach_cgroup(skel->progs.sysctl_tcp_mem, cgroup_fd);
+ if (!ASSERT_OK_PTR(skel->links.sysctl_tcp_mem, "attach_program"))
+ goto out;
+
+ skel->bss->classid = -1;
+ if (!ASSERT_OK(join_classid(), "join_classid"))
+ goto out;
+
+ SYS_NOFAIL("cat /proc/sys/net/ipv4/tcp_mem");
+ ASSERT_EQ(skel->bss->classid, getpid(), "classid mismatch");
+out:
+ if (cgroup_fd > 0)
+ close(cgroup_fd);
+ test_cgroup_classid__destroy(skel);
+ cleanup_classid_environment();
+}
+
+static void test_cgroup_get_classid_sockopt(void)
+{
+ struct test_cgroup_classid *skel = NULL;
+ int cgroup_fd = -1, fd = -1, val, err;
+ socklen_t val_len;
+
+ cgroup_fd = test__join_cgroup(TEST_CGROUP);
+ if (!ASSERT_GE(cgroup_fd, 0, "join cgroup"))
+ goto out;
+
+ if (!ASSERT_OK(setup_classid_environment(), "setup env"))
+ goto out;
+
+ if (!ASSERT_OK(set_classid(), "set_classid"))
+ goto out;
+
+ skel = test_cgroup_classid__open_and_load();
+ if (!ASSERT_OK_PTR(skel, "load program"))
+ goto out;
+
+ skel->links.cg_getsockopt =
+ bpf_program__attach_cgroup(skel->progs.cg_getsockopt, cgroup_fd);
+ if (!ASSERT_OK_PTR(skel->links.cg_getsockopt, "attach_program"))
+ goto out;
+
+ skel->bss->classid = -1;
+ if (!ASSERT_OK(join_classid(), "join_classid"))
+ goto out;
+
+ fd = socket(AF_INET, SOCK_STREAM, 0);
+ if (!ASSERT_OK_FD(fd, "socket"))
+ goto out;
+
+ val_len = sizeof(val);
+ err = getsockopt(fd, SOL_SOCKET, SO_SNDBUF, &val, &val_len);
+ if (!ASSERT_OK(err, "getsockopt"))
+ goto out;
+
+ ASSERT_EQ(skel->bss->classid, getpid(), "classid mismatch");
+out:
+ if (fd > 0)
+ close(fd);
+ if (cgroup_fd > 0)
+ close(cgroup_fd);
+ test_cgroup_classid__destroy(skel);
+ cleanup_classid_environment();
+}
+
+void test_cgroup_get_classid(void)
+{
+ if (test__start_subtest("get classid from tc"))
+ test_cgroup_get_classid_tc();
+ if (test__start_subtest("get classid from sysctl"))
+ test_cgroup_get_classid_sysctl();
+ if (test__start_subtest("get classid from cgroup dev"))
+ test_cgroup_get_classid_cgroup_dev();
+ if (test__start_subtest("get classid from cgroup sockopt"))
+ test_cgroup_get_classid_sockopt();
+}
diff --git a/tools/testing/selftests/bpf/progs/test_cgroup_classid.c b/tools/testing/selftests/bpf/progs/test_cgroup_classid.c
new file mode 100644
index 000000000000..7a555ba6bb17
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/test_cgroup_classid.c
@@ -0,0 +1,51 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <linux/bpf.h>
+#include <sys/socket.h>
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_endian.h>
+
+int classid;
+
+SEC("tc/egress")
+int tc_egress(struct __sk_buff *skb)
+{
+ /* expecte real classid */
+ classid = bpf_get_cgroup_classid(skb);
+ return TCX_PASS;
+}
+
+SEC("tc/ingress")
+int tc_ingress(struct __sk_buff *skb)
+{
+ /* expecte 0 */
+ classid = bpf_get_cgroup_classid(skb);
+ return TCX_PASS;
+}
+
+SEC("cgroup/dev")
+int cg_dev(struct bpf_cgroup_dev_ctx *ctx)
+{
+ /* expecte real classid */
+ classid = bpf_get_cgroup_classid((struct __sk_buff *)ctx);
+ /* Allow all */
+ return 1;
+}
+
+SEC("cgroup/sysctl")
+int sysctl_tcp_mem(struct bpf_sysctl *ctx)
+{
+ /* expecte real classid */
+ classid = bpf_get_cgroup_classid((struct __sk_buff *)ctx);
+ return 1;
+}
+
+SEC("cgroup/getsockopt")
+int cg_getsockopt(struct bpf_sockopt *ctx)
+{
+ /* expecte real classid */
+ classid = bpf_get_cgroup_classid((struct __sk_buff *)ctx);
+ return 1;
+}
+
+char _license[] SEC("license") = "GPL";
--
2.47.1
next prev parent reply other threads:[~2025-05-28 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 16:16 [PATCH bpf-next v1 1/2] bpf: Restrict usage scope of bpf_get_cgroup_classid Jiayuan Chen
2025-05-28 16:16 ` Jiayuan Chen [this message]
2025-05-29 16:46 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528161653.55162-2-jiayuan.chen@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=yangfeng@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.