From: Jakub Kicinski <kuba@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: avoid extra pskb_expand_head() in netlink_trim()
Date: Wed, 28 May 2025 17:43:55 -0700 [thread overview]
Message-ID: <20250528174355.2333a83a@kernel.org> (raw)
In-Reply-To: <20250528153628.249631-1-dmantipov@yandex.ru>
On Wed, 28 May 2025 18:36:28 +0300 Dmitry Antipov wrote:
> When 'netlink_trim()' processes shared skb, using 'skb_clone()' with
> following 'pskb_expand_head()' looks suboptimal, and it's expected to
> be a bit faster to do 'skb_copy_expand()' with desired tailroom instead.
Looks fine, but it would be useful to add more info about the practical
scenario where this patch makes a difference.
Other than that - net-next is closed, please repost after the merge
window.
--
pw-bot: defer
next prev parent reply other threads:[~2025-05-29 0:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 15:36 [PATCH] netlink: avoid extra pskb_expand_head() in netlink_trim() Dmitry Antipov
2025-05-29 0:43 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-06 7:41 [PATCH] net: core: avoid extra pskb_expand_head() when adjusting headroom Dmitry Antipov
2025-06-06 7:41 ` [PATCH] netlink: avoid extra pskb_expand_head() in netlink_trim() Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528174355.2333a83a@kernel.org \
--to=kuba@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.