From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH V2 19/19] virtio_ring: add in order support
Date: Thu, 29 May 2025 10:36:31 +0800 [thread overview]
Message-ID: <202505291000.2SXRDeLg-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250528064234.12228-20-jasowang@redhat.com>
References: <20250528064234.12228-20-jasowang@redhat.com>
TO: Jason Wang <jasowang@redhat.com>
Hi Jason,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on linus/master v6.15 next-20250528]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jason-Wang/virtio_ring-rename-virtqueue_reinit_xxx-to-virtqueue_reset_xxx/20250528-144806
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
patch link: https://lore.kernel.org/r/20250528064234.12228-20-jasowang%40redhat.com
patch subject: [PATCH V2 19/19] virtio_ring: add in order support
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
config: nios2-randconfig-r072-20250529 (https://download.01.org/0day-ci/archive/20250529/202505291000.2SXRDeLg-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 10.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202505291000.2SXRDeLg-lkp@intel.com/
New smatch warnings:
drivers/virtio/virtio_ring.c:2109 virtqueue_get_buf_ctx_packed_in_order() error: uninitialized symbol 'id'.
Old smatch warnings:
arch/nios2/include/asm/thread_info.h:62 current_thread_info() error: uninitialized symbol 'sp'.
drivers/virtio/virtio_ring.c:2113 virtqueue_get_buf_ctx_packed_in_order() error: uninitialized symbol 'id'.
drivers/virtio/virtio_ring.c:1866 virtqueue_add_packed_in_order() error: uninitialized symbol 'head_flags'.
drivers/virtio/virtio_ring.c:1709 virtqueue_add_packed() error: uninitialized symbol 'prev'.
drivers/virtio/virtio_ring.c:1717 virtqueue_add_packed() error: uninitialized symbol 'head_flags'.
vim +/id +2109 drivers/virtio/virtio_ring.c
52bedb9b5387f0 Jason Wang 2025-05-28 2069
52bedb9b5387f0 Jason Wang 2025-05-28 2070 static void *virtqueue_get_buf_ctx_packed_in_order(struct vring_virtqueue *vq,
52bedb9b5387f0 Jason Wang 2025-05-28 2071 unsigned int *len,
52bedb9b5387f0 Jason Wang 2025-05-28 2072 void **ctx)
52bedb9b5387f0 Jason Wang 2025-05-28 2073 {
52bedb9b5387f0 Jason Wang 2025-05-28 2074 unsigned int num = vq->packed.vring.num;
52bedb9b5387f0 Jason Wang 2025-05-28 2075 u16 last_used, id, last_used_idx;
52bedb9b5387f0 Jason Wang 2025-05-28 2076 bool used_wrap_counter;
52bedb9b5387f0 Jason Wang 2025-05-28 2077 void *ret;
52bedb9b5387f0 Jason Wang 2025-05-28 2078
52bedb9b5387f0 Jason Wang 2025-05-28 2079 START_USE(vq);
52bedb9b5387f0 Jason Wang 2025-05-28 2080
52bedb9b5387f0 Jason Wang 2025-05-28 2081 if (unlikely(vq->broken)) {
52bedb9b5387f0 Jason Wang 2025-05-28 2082 END_USE(vq);
52bedb9b5387f0 Jason Wang 2025-05-28 2083 return NULL;
52bedb9b5387f0 Jason Wang 2025-05-28 2084 }
52bedb9b5387f0 Jason Wang 2025-05-28 2085
52bedb9b5387f0 Jason Wang 2025-05-28 2086 last_used_idx = vq->last_used_idx;
52bedb9b5387f0 Jason Wang 2025-05-28 2087 used_wrap_counter = packed_used_wrap_counter(last_used_idx);
52bedb9b5387f0 Jason Wang 2025-05-28 2088 last_used = packed_last_used(last_used_idx);
52bedb9b5387f0 Jason Wang 2025-05-28 2089
52bedb9b5387f0 Jason Wang 2025-05-28 2090 if (vq->batch_head == num) {
52bedb9b5387f0 Jason Wang 2025-05-28 2091 if (!__more_used_packed(vq)) {
52bedb9b5387f0 Jason Wang 2025-05-28 2092 pr_debug("No more buffers in queue\n");
52bedb9b5387f0 Jason Wang 2025-05-28 2093 END_USE(vq);
52bedb9b5387f0 Jason Wang 2025-05-28 2094 return NULL;
52bedb9b5387f0 Jason Wang 2025-05-28 2095 }
52bedb9b5387f0 Jason Wang 2025-05-28 2096 /* Only get used elements after they have been exposed by host. */
52bedb9b5387f0 Jason Wang 2025-05-28 2097 virtio_rmb(vq->weak_barriers);
52bedb9b5387f0 Jason Wang 2025-05-28 2098 vq->batch_head = le16_to_cpu(vq->packed.vring.desc[last_used].id);
52bedb9b5387f0 Jason Wang 2025-05-28 2099 vq->batch_len = le32_to_cpu(vq->packed.vring.desc[last_used].len);
52bedb9b5387f0 Jason Wang 2025-05-28 2100 }
52bedb9b5387f0 Jason Wang 2025-05-28 2101
52bedb9b5387f0 Jason Wang 2025-05-28 2102 if (vq->batch_head == last_used) {
52bedb9b5387f0 Jason Wang 2025-05-28 2103 vq->batch_head = num;
52bedb9b5387f0 Jason Wang 2025-05-28 2104 *len = vq->batch_len;
52bedb9b5387f0 Jason Wang 2025-05-28 2105 } else
52bedb9b5387f0 Jason Wang 2025-05-28 2106 *len = vq->packed.desc_state[last_used].total_len;
52bedb9b5387f0 Jason Wang 2025-05-28 2107
52bedb9b5387f0 Jason Wang 2025-05-28 2108 if (unlikely(last_used >= num)) {
52bedb9b5387f0 Jason Wang 2025-05-28 @2109 BAD_RING(vq, "id %u out of range\n", id);
52bedb9b5387f0 Jason Wang 2025-05-28 2110 return NULL;
52bedb9b5387f0 Jason Wang 2025-05-28 2111 }
52bedb9b5387f0 Jason Wang 2025-05-28 2112 if (unlikely(!vq->packed.desc_state[last_used].data)) {
52bedb9b5387f0 Jason Wang 2025-05-28 2113 BAD_RING(vq, "id %u is not a head!\n", id);
52bedb9b5387f0 Jason Wang 2025-05-28 2114 return NULL;
52bedb9b5387f0 Jason Wang 2025-05-28 2115 }
52bedb9b5387f0 Jason Wang 2025-05-28 2116
52bedb9b5387f0 Jason Wang 2025-05-28 2117 /* detach_buf_packed clears data, so grab it now. */
52bedb9b5387f0 Jason Wang 2025-05-28 2118 ret = vq->packed.desc_state[last_used].data;
52bedb9b5387f0 Jason Wang 2025-05-28 2119 detach_buf_packed_in_order(vq, last_used, ctx);
52bedb9b5387f0 Jason Wang 2025-05-28 2120
52bedb9b5387f0 Jason Wang 2025-05-28 2121 update_last_used_idx_packed(vq, last_used, last_used,
52bedb9b5387f0 Jason Wang 2025-05-28 2122 used_wrap_counter);
52bedb9b5387f0 Jason Wang 2025-05-28 2123
52bedb9b5387f0 Jason Wang 2025-05-28 2124 LAST_ADD_TIME_INVALID(vq);
52bedb9b5387f0 Jason Wang 2025-05-28 2125
52bedb9b5387f0 Jason Wang 2025-05-28 2126 END_USE(vq);
52bedb9b5387f0 Jason Wang 2025-05-28 2127 return ret;
52bedb9b5387f0 Jason Wang 2025-05-28 2128 }
52bedb9b5387f0 Jason Wang 2025-05-28 2129
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-05-29 2:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 2:36 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-28 6:42 [PATCH V2 00/19] virtio_ring in order support Jason Wang
2025-05-28 6:42 ` [PATCH V2 19/19] virtio_ring: add " Jason Wang
2025-05-28 15:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505291000.2SXRDeLg-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.