From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1] bass: Fix not using SID from BT_BASS_ADD_SRC
Date: Thu, 29 May 2025 12:42:56 -0400 [thread overview]
Message-ID: <20250529164256.188167-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
BT_BASS_ADD_SRC command does actually have the SID of the broadcast
source which must be set otherwise the kernel would assume it to be
0x00 which may not always be the case.
Fixes: https://github.com/bluez/bluez/issues/1282
---
profiles/audio/bass.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c
index 017a5aa75c85..417b7b72ff9b 100644
--- a/profiles/audio/bass.c
+++ b/profiles/audio/bass.c
@@ -106,6 +106,7 @@ struct bass_delegator {
struct bt_bap *bap;
unsigned int state_id;
unsigned int bcode_id;
+ uint8_t sid;
uint8_t *bcode;
unsigned int timeout;
struct queue *bcode_reqs;
@@ -646,6 +647,7 @@ static void bap_attached(struct bt_bap *bap, void *user_data)
btd_device_get_bdaddr_type(device),
BT_IO_OPT_MODE, BT_IO_MODE_ISO,
BT_IO_OPT_QOS, &bap_sink_pa_qos,
+ BT_IO_OPT_ISO_BC_SID, dg->sid,
BT_IO_OPT_INVALID);
if (!dg->io) {
error("%s", err->message);
@@ -1320,6 +1322,7 @@ probe:
dg->device = device;
dg->src = bcast_src;
+ dg->sid = params->sid;
dg->bcode_reqs = queue_new();
dg->setups = queue_new();
@@ -1460,6 +1463,7 @@ static int handle_mod_src_req(struct bt_bcast_src *bcast_src,
btd_device_get_bdaddr_type(dg->device),
BT_IO_OPT_MODE, BT_IO_MODE_ISO,
BT_IO_OPT_QOS, &bap_sink_pa_qos,
+ BT_IO_OPT_ISO_BC_SID, dg->sid,
BT_IO_OPT_INVALID);
if (!dg->io) {
error("%s", err->message);
--
2.49.0
next reply other threads:[~2025-05-29 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 16:42 Luiz Augusto von Dentz [this message]
2025-05-29 18:11 ` [BlueZ,v1] bass: Fix not using SID from BT_BASS_ADD_SRC bluez.test.bot
2025-05-29 19:40 ` [PATCH BlueZ v1] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250529164256.188167-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.