From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FFFFC54FB3 for ; Fri, 30 May 2025 00:49:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BFD6B41C81; Fri, 30 May 2025 00:49:20 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WGDQoPmT2ddH; Fri, 30 May 2025 00:49:20 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 404AA41C7B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1748566160; bh=8Bl71w9e4E6Qo6rtxryDax3y08LU+Nx9kHzGp2J0tEk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fBAZU6i9bjM2+e2+m8F/qLxJFNEbMxRFPEbgG1njragjlagoYywcZ0F0jqA4XWDki S8574dG361rv0Z91/WXQq26xfMeF+5558az4J5ZoOYfqeuhN7qXwn1BoESrKjbfVmp 9v5iErLxRPTpqTndsp64WZvw87eGhCIi3C/le2H0HDtHM7MBf+yFqRPFEJys60hO6N ozw5JrrJJmc5Z7D2ueXIzIZOySq1EUkjmyXOCVY8aBtUsvcnmVRUX+V8Yyu1sbNGbJ x92FC8XyPyFzVJWpKup6WW7smPgRFzBju3GW3rzADMJDsElRothWfMPreRU8c10t7E SSp77t/z4VExg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 404AA41C7B; Fri, 30 May 2025 00:49:20 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 47F46127 for ; Fri, 30 May 2025 00:49:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3995A84154 for ; Fri, 30 May 2025 00:49:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LTlAetjgUxeX for ; Fri, 30 May 2025 00:49:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 9269784152 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9269784152 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9269784152 for ; Fri, 30 May 2025 00:49:18 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7A6AF60010; Fri, 30 May 2025 00:49:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D524C4CEE7; Fri, 30 May 2025 00:49:16 +0000 (UTC) Date: Thu, 29 May 2025 17:49:14 -0700 From: Jakub Kicinski To: Arkadiusz Kubalewski Cc: donald.hunter@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, vadim.fedorenko@linux.dev, jiri@resnulli.us, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com, corbet@lwn.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org, Milena Olech Message-ID: <20250529174914.179c1a34@kernel.org> In-Reply-To: <20250523172650.1517164-2-arkadiusz.kubalewski@intel.com> References: <20250523172650.1517164-1-arkadiusz.kubalewski@intel.com> <20250523172650.1517164-2-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748566156; bh=8Bl71w9e4E6Qo6rtxryDax3y08LU+Nx9kHzGp2J0tEk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G/1oTXcJfmrJCGtkYZhcTh5rIRqFiCd1irrdkiqp+Y9mefG/2ac0qSvw0Siko8rua nkWTbjqN2s0i9vCAzlyfo9hgqUVVST/i0soLWxMWm4yQjizSGOXk60eYH6ZwA9gJo6 msmtC3+9MnNrYGQlmDNGHFCkGVQQGq8RIj0S5Yda/uLOFsYE213XkUgtCGmPje2a/i nJd9uNugpY/u0gfYejO2l96XH7tkBD1HPcsSg/Db/NMqAqynIl3Osi86IwwxKaHs/C O4wBg4PoQsi8v2s94WAEuZbI5Pi3nUZx9xV0csl4K6W3CCPBHPZxn0r9/DU8BDQdqh /pMKhYRPE4aHg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=G/1oTXcJ Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/3] dpll: add reference-sync netlink attribute X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 23 May 2025 19:26:48 +0200 Arkadiusz Kubalewski wrote: > +The device may support the Reference SYNC feature, which allows the combination > +of two inputs into a Reference SYNC pair. In this configuration, clock signals > +from both inputs are used to synchronize the dpll device. The higher frequency > +signal is utilized for the loop bandwidth of the DPLL, while the lower frequency > +signal is used to syntonize the output signal of the DPLL device. This feature > +enables the provision of a high-quality loop bandwidth signal from an external > +source. I'm uninitiated into the deeper arts of time sync, but to me this sounds like a reference clock. Are you trying not to call it clock because in time clock means a ticker, and this is an oscillator? > +A capable input provides a list of inputs that can be paired to create a > +Reference SYNC pair. To control this feature, the user must request a desired > +state for a target pin: use ``DPLL_PIN_STATE_CONNECTED`` to enable or > +``DPLL_PIN_STATE_DISCONNECTED`` to disable the feature. Only two pins can be > +bound to form a Reference SYNC pair at any given time. Mostly I got confused by the doc saying "Reference SYNC pair". I was expecting that you'll have to provide 2 ref sync signals. But IIUC the first signal is still the existing signal we lock into, so the pair is of a reference sync + an input pin? Not a pair of two reference syncs. IOW my reading of the doc made me expect 2 pins to always be passed in as ref sync, but the example from the cover letter shows only adding one. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D8C2FBF0; Fri, 30 May 2025 00:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748566159; cv=none; b=RWJLU7bB0Xg1k/NIYUd8VFmR78WxhYT7wXajzhhuwCI5vz1oqjNcfkPIX2ZgwHf6OiuRPyTJGvHFpA8G2/ecdhcCcZGXV56FRkgxnuPMmqHsTuybAc7N5c4UBEouNTcrKxI0MQsdK5B0WpQmUoUDpcXIZx0ah1IwrdmuuImfPfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748566159; c=relaxed/simple; bh=8Bl71w9e4E6Qo6rtxryDax3y08LU+Nx9kHzGp2J0tEk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KqCnpl9L8ZHC9rcJxwxzaSjeA7taBRLa9I3cXlzijBoN02ua+to4kDSykMajx9wRpy9epw+y5xb1xz81ahZ2Fvq/7tvRxfUV2+8HeAQqD5mJxpyh5x2u0yrqXZkNcngzOln9TzHuBy48kWL4rIR1npMn+huByg+br6GUyrrQsa8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G/1oTXcJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G/1oTXcJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D524C4CEE7; Fri, 30 May 2025 00:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748566156; bh=8Bl71w9e4E6Qo6rtxryDax3y08LU+Nx9kHzGp2J0tEk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G/1oTXcJfmrJCGtkYZhcTh5rIRqFiCd1irrdkiqp+Y9mefG/2ac0qSvw0Siko8rua nkWTbjqN2s0i9vCAzlyfo9hgqUVVST/i0soLWxMWm4yQjizSGOXk60eYH6ZwA9gJo6 msmtC3+9MnNrYGQlmDNGHFCkGVQQGq8RIj0S5Yda/uLOFsYE213XkUgtCGmPje2a/i nJd9uNugpY/u0gfYejO2l96XH7tkBD1HPcsSg/Db/NMqAqynIl3Osi86IwwxKaHs/C O4wBg4PoQsi8v2s94WAEuZbI5Pi3nUZx9xV0csl4K6W3CCPBHPZxn0r9/DU8BDQdqh /pMKhYRPE4aHg== Date: Thu, 29 May 2025 17:49:14 -0700 From: Jakub Kicinski To: Arkadiusz Kubalewski Cc: donald.hunter@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, vadim.fedorenko@linux.dev, jiri@resnulli.us, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com, corbet@lwn.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org, Milena Olech Subject: Re: [PATCH net-next v4 1/3] dpll: add reference-sync netlink attribute Message-ID: <20250529174914.179c1a34@kernel.org> In-Reply-To: <20250523172650.1517164-2-arkadiusz.kubalewski@intel.com> References: <20250523172650.1517164-1-arkadiusz.kubalewski@intel.com> <20250523172650.1517164-2-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 May 2025 19:26:48 +0200 Arkadiusz Kubalewski wrote: > +The device may support the Reference SYNC feature, which allows the combination > +of two inputs into a Reference SYNC pair. In this configuration, clock signals > +from both inputs are used to synchronize the dpll device. The higher frequency > +signal is utilized for the loop bandwidth of the DPLL, while the lower frequency > +signal is used to syntonize the output signal of the DPLL device. This feature > +enables the provision of a high-quality loop bandwidth signal from an external > +source. I'm uninitiated into the deeper arts of time sync, but to me this sounds like a reference clock. Are you trying not to call it clock because in time clock means a ticker, and this is an oscillator? > +A capable input provides a list of inputs that can be paired to create a > +Reference SYNC pair. To control this feature, the user must request a desired > +state for a target pin: use ``DPLL_PIN_STATE_CONNECTED`` to enable or > +``DPLL_PIN_STATE_DISCONNECTED`` to disable the feature. Only two pins can be > +bound to form a Reference SYNC pair at any given time. Mostly I got confused by the doc saying "Reference SYNC pair". I was expecting that you'll have to provide 2 ref sync signals. But IIUC the first signal is still the existing signal we lock into, so the pair is of a reference sync + an input pin? Not a pair of two reference syncs. IOW my reading of the doc made me expect 2 pins to always be passed in as ref sync, but the example from the cover letter shows only adding one.