From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E2E6C5B543 for ; Fri, 30 May 2025 00:56:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2E77F40C46; Fri, 30 May 2025 00:56:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0bGa81OUsBUq; Fri, 30 May 2025 00:56:32 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7351440C0E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1748566592; bh=XkEkIQyx+DkxwQbUFbw/COCbajasDnfPyEBJ9wORWlg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=64rs1MUDxSpoh3hga0QHMSmpFO0JmQBixiozjjBfjTFTFzuLd+DO+C27rpYGMoM90 88UFHxoPGf7k291M7s/dzP+ozwr1CoYaU2l34twxlMg64qAlDiEM5JHfYe15q0Kzyj f4r2fJRALnDmP/wf7pKMmawpAeatafU2YsyQWjgdCgtsCCsjsouCBelDT4hWOSppQA xQ4mIY/p8D2esfORfZWnFq+Cw3q8flo1dPSrY4tY6tjV0Rq+0LCU7wvXqB0QnfAWC+ UreC7yrTHIMKCQF/7xvySiSHXc43t7lY0TJJffwSuDqG0HitrXu36Z0UYzTr+DEJQl cwUN3MVoQIPmg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 7351440C0E; Fri, 30 May 2025 00:56:32 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 1379D236 for ; Fri, 30 May 2025 00:56:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 057B640BF6 for ; Fri, 30 May 2025 00:56:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id QQtUoXqYs5uJ for ; Fri, 30 May 2025 00:56:30 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 60A6440BF1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 60A6440BF1 Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 60A6440BF1 for ; Fri, 30 May 2025 00:56:30 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6EDAE60010; Fri, 30 May 2025 00:56:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51CDEC4CEE7; Fri, 30 May 2025 00:56:28 +0000 (UTC) Date: Thu, 29 May 2025 17:56:27 -0700 From: Jakub Kicinski To: Arkadiusz Kubalewski Cc: donald.hunter@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, vadim.fedorenko@linux.dev, jiri@resnulli.us, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com, corbet@lwn.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org, Milena Olech Message-ID: <20250529175627.4e6a3b07@kernel.org> In-Reply-To: <20250523172650.1517164-3-arkadiusz.kubalewski@intel.com> References: <20250523172650.1517164-1-arkadiusz.kubalewski@intel.com> <20250523172650.1517164-3-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748566589; bh=yg6Wh8XDP53XOaEfOboKxLKTBHVS/nUo2gmPowtLxbo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D5yTMsUXYJkXKA/3AcLLVZtYKMkrbG7yBjq6Hz2CnCLmzDpTU+WuwJY/phWaP7LWK DH4sGRZP5sNjiuZI2lbzQ42iNVCv7M0Lqom0Yvd9yfFjLlLPun+tW5laqn3p8EPiO6 VhGLVjm8KUzTfHtQPYo9eDBQnBW6wmwRx5MTcO3HPFAmIWG/wBR2Tn7rVV4fgCHfUF buiRCeXTUvQPm9FWsgGuzQBy2kAfzGJAMk+NYCX5cWZivNmpmV7UDFhsAFL+3BQwo6 gsjjyQFKCMLAJ0P8cRIkGgi58XLvnhBBxXbrTn0iq0kNZELtg4Aj+XGs1NTiEORLZN Cx4g/jqxeB+WA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=D5yTMsUX Subject: Re: [Intel-wired-lan] [PATCH net-next v4 2/3] dpll: add reference sync get/set X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 23 May 2025 19:26:49 +0200 Arkadiusz Kubalewski wrote: > +static int > +dpll_pin_ref_sync_state_set(struct dpll_pin *pin, > + unsigned long ref_sync_pin_idx, > + const enum dpll_pin_state state, > + struct netlink_ext_ack *extack) > + > +{ > + struct dpll_pin_ref *ref, *failed; > + const struct dpll_pin_ops *ops; > + enum dpll_pin_state old_state; > + struct dpll_pin *ref_sync_pin; > + struct dpll_device *dpll; > + unsigned long i; > + int ret; > + > + ref_sync_pin =3D xa_find(&pin->ref_sync_pins, &ref_sync_pin_idx, > + ULONG_MAX, XA_PRESENT); > + if (!ref_sync_pin) { > + NL_SET_ERR_MSG(extack, "reference sync pin not found"); > + return -EINVAL; > + } > + if (!dpll_pin_available(ref_sync_pin)) { > + NL_SET_ERR_MSG(extack, "reference sync pin not available"); > + return -EINVAL; > + } > + ref =3D dpll_xa_ref_dpll_first(&pin->dpll_refs); > + ASSERT_NOT_NULL(ref); why the assert? The next line will crash very.. "informatively" if ref is NULL =F0=9F=A4=B7=EF=B8=8F > +static int > +dpll_pin_ref_sync_set(struct dpll_pin *pin, struct nlattr *nest, > + struct netlink_ext_ack *extack) > +{ > + struct nlattr *tb[DPLL_A_PIN_MAX + 1]; > + enum dpll_pin_state state; > + u32 sync_pin_id; > + > + nla_parse_nested(tb, DPLL_A_PIN_MAX, nest, > + dpll_reference_sync_nl_policy, extack); > + if (!tb[DPLL_A_PIN_ID]) { NL_REQ_ATTR_CHECK(), please if (NL_REQ_ATTR_CHECK(extack, nest, tb, DPLL_A_PIN_ID) || NL_REQ_ATTR_CHECK(extack, nest, tb, DPLL_A_PIN_STATE)) return -EINVAL; it will set ATTR_MISS metadata for you. Not 100% sure if Python YNL can decode miss attrs in nests but that's a SMOP :) C YNL can do it. > + NL_SET_ERR_MSG(extack, "sync pin id expected"); > + return -EINVAL; > + } > + sync_pin_id =3D nla_get_u32(tb[DPLL_A_PIN_ID]); > + > + if (!tb[DPLL_A_PIN_STATE]) { > + NL_SET_ERR_MSG(extack, "sync pin state expected"); > + return -EINVAL; > + } > + state =3D nla_get_u32(tb[DPLL_A_PIN_STATE]); > + > + return dpll_pin_ref_sync_state_set(pin, sync_pin_id, state, extack); > +} From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F68AD5E; Fri, 30 May 2025 00:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748566589; cv=none; b=VMsPbteKLiaclB44YiADWoblI/tTxZ2/yC+Yg4glal7KCM8tjC3iNcHToZ3yCPG9mrOeqr9I5YBj3wfF8GwRUr7Xgedfyzj/FoPKLu2w8QHBBD3NJZd+htZcCOYEnFAm168K3pUqm8MU2mKM9y1zk+bPVNd8NmFJfAeaoWzm9Gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748566589; c=relaxed/simple; bh=yg6Wh8XDP53XOaEfOboKxLKTBHVS/nUo2gmPowtLxbo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fY9x/DbKqMFpWfvtpuXq8fsC0a6PvNmX1YlLQFvA3MIpQ1qZzfDSKcNOR0kSThWfvgex26A9wAmFr1CXFarHk23DaqlQ+TFRjj32OEM/L8hIw663pcWNVxqm9Xxi0rqMXQES/51qFu3GVy+OPl8aztxE3ZLaueholW7wa+ypCoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D5yTMsUX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D5yTMsUX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51CDEC4CEE7; Fri, 30 May 2025 00:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748566589; bh=yg6Wh8XDP53XOaEfOboKxLKTBHVS/nUo2gmPowtLxbo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D5yTMsUXYJkXKA/3AcLLVZtYKMkrbG7yBjq6Hz2CnCLmzDpTU+WuwJY/phWaP7LWK DH4sGRZP5sNjiuZI2lbzQ42iNVCv7M0Lqom0Yvd9yfFjLlLPun+tW5laqn3p8EPiO6 VhGLVjm8KUzTfHtQPYo9eDBQnBW6wmwRx5MTcO3HPFAmIWG/wBR2Tn7rVV4fgCHfUF buiRCeXTUvQPm9FWsgGuzQBy2kAfzGJAMk+NYCX5cWZivNmpmV7UDFhsAFL+3BQwo6 gsjjyQFKCMLAJ0P8cRIkGgi58XLvnhBBxXbrTn0iq0kNZELtg4Aj+XGs1NTiEORLZN Cx4g/jqxeB+WA== Date: Thu, 29 May 2025 17:56:27 -0700 From: Jakub Kicinski To: Arkadiusz Kubalewski Cc: donald.hunter@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, vadim.fedorenko@linux.dev, jiri@resnulli.us, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com, corbet@lwn.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org, Milena Olech Subject: Re: [PATCH net-next v4 2/3] dpll: add reference sync get/set Message-ID: <20250529175627.4e6a3b07@kernel.org> In-Reply-To: <20250523172650.1517164-3-arkadiusz.kubalewski@intel.com> References: <20250523172650.1517164-1-arkadiusz.kubalewski@intel.com> <20250523172650.1517164-3-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 23 May 2025 19:26:49 +0200 Arkadiusz Kubalewski wrote: > +static int > +dpll_pin_ref_sync_state_set(struct dpll_pin *pin, > + unsigned long ref_sync_pin_idx, > + const enum dpll_pin_state state, > + struct netlink_ext_ack *extack) > + > +{ > + struct dpll_pin_ref *ref, *failed; > + const struct dpll_pin_ops *ops; > + enum dpll_pin_state old_state; > + struct dpll_pin *ref_sync_pin; > + struct dpll_device *dpll; > + unsigned long i; > + int ret; > + > + ref_sync_pin =3D xa_find(&pin->ref_sync_pins, &ref_sync_pin_idx, > + ULONG_MAX, XA_PRESENT); > + if (!ref_sync_pin) { > + NL_SET_ERR_MSG(extack, "reference sync pin not found"); > + return -EINVAL; > + } > + if (!dpll_pin_available(ref_sync_pin)) { > + NL_SET_ERR_MSG(extack, "reference sync pin not available"); > + return -EINVAL; > + } > + ref =3D dpll_xa_ref_dpll_first(&pin->dpll_refs); > + ASSERT_NOT_NULL(ref); why the assert? The next line will crash very.. "informatively" if ref is NULL =F0=9F=A4=B7=EF=B8=8F > +static int > +dpll_pin_ref_sync_set(struct dpll_pin *pin, struct nlattr *nest, > + struct netlink_ext_ack *extack) > +{ > + struct nlattr *tb[DPLL_A_PIN_MAX + 1]; > + enum dpll_pin_state state; > + u32 sync_pin_id; > + > + nla_parse_nested(tb, DPLL_A_PIN_MAX, nest, > + dpll_reference_sync_nl_policy, extack); > + if (!tb[DPLL_A_PIN_ID]) { NL_REQ_ATTR_CHECK(), please if (NL_REQ_ATTR_CHECK(extack, nest, tb, DPLL_A_PIN_ID) || NL_REQ_ATTR_CHECK(extack, nest, tb, DPLL_A_PIN_STATE)) return -EINVAL; it will set ATTR_MISS metadata for you. Not 100% sure if Python YNL can decode miss attrs in nests but that's a SMOP :) C YNL can do it. > + NL_SET_ERR_MSG(extack, "sync pin id expected"); > + return -EINVAL; > + } > + sync_pin_id =3D nla_get_u32(tb[DPLL_A_PIN_ID]); > + > + if (!tb[DPLL_A_PIN_STATE]) { > + NL_SET_ERR_MSG(extack, "sync pin state expected"); > + return -EINVAL; > + } > + state =3D nla_get_u32(tb[DPLL_A_PIN_STATE]); > + > + return dpll_pin_ref_sync_state_set(pin, sync_pin_id, state, extack); > +}