From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C3741A2643; Thu, 29 May 2025 04:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748494036; cv=none; b=uCBxPPCkoOck1PnG3HX0A5Lzp1Ws8pn2T/DlZKYJZbvOpos8Yl3rxMuqmn4iBtoFQlPe69vLfqWXHQVS7zOTb3qVYeD+Td2jiOjNWZBa6WJ/gp+L9NKe1vZtxvJ1hqRpPPZFgX+agWDEu1ximWulZFHvZzicdVtUsqRjuR6qAfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748494036; c=relaxed/simple; bh=AQvpGrvVHzdCNOLS7M9nxYozPa3Upe+YZyZ3oSHoX3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=psk1atU7Xkv+4xD2yJ0FzBtkr8/k0WLxWjNbzwgS5s4R3ezNou+RpHBOB1I2P6lWLDG4j2y+G7pvNSn5f4ygaVHKuUpTfaB+o4nJA28gk0QMrelgdlns7QyyOnwUXhp9B9Uj/7DOpvTn8t/HXM8yZoXg/+actjSGRQPqNrKZhU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DUfKqDlk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DUfKqDlk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59C19C4CEEA; Thu, 29 May 2025 04:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748494036; bh=AQvpGrvVHzdCNOLS7M9nxYozPa3Upe+YZyZ3oSHoX3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DUfKqDlkrBNAb7Lvw4Jsi1V79xhOjxioV6vvrabCW+Srd0/hgPkfLQLWXKluXHP0/ zmPreT6qInfrDLrba9GvmhB6nThh+SBKUJbuDEmy12Hl0dYIVRd9qPItmi8WFSVzhA U1KDPsgBmSlVM2wEpOfdz8uttahDXid6Q+rs8R/A= Date: Thu, 29 May 2025 06:47:12 +0200 From: Greg KH To: Kees Cook Cc: Nathan Chancellor , Justin Stitt , Eric Biggers , Arnd Bergmann , Jann Horn , Marco Elver , llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this out of CI Message-ID: <2025052937-certainty-encode-4085@gregkh> References: <20250528182616.work.296-kees@kernel.org> <20250528213223.GA3885532@ax162> <202505281559.FD37A978F@keescook> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202505281559.FD37A978F@keescook> On Wed, May 28, 2025 at 04:00:03PM -0700, Kees Cook wrote: > On Wed, May 28, 2025 at 02:32:23PM -0700, Nathan Chancellor wrote: > > On Wed, May 28, 2025 at 11:26:22AM -0700, Kees Cook wrote: > > > Depending on !COMPILE_TEST isn't sufficient to keep this feature out of > > > CI because we can't stop it from being included in randconfig builds. > > > This feature is still highly experimental, and is developed in lock-step > > > with Clang's Overflow Behavior Types[1]. Depend on BROKEN to keep it > > > from being enabled by anyone not expecting it. > > > > > > Link: https://discourse.llvm.org/t/rfc-v2-clang-introduce-overflowbehaviortypes-for-wrapping-and-non-wrapping-arithmetic/86507 [1] > > > Signed-off-by: Kees Cook > > > > Should this have a 'Cc: stable@vger.kernel.org' on it? There might not > > be much randconfig testing on stable but it is still very much possible > > for some random user to turn this on and report problems. > > Ah yeah, I should probably do this via a proper Fixes: tag. I'll add > this. Nit, "Fixes:" tags alone without a cc: stable do not guarantee they will end up in the stable trees. Always explicitly add a cc: please. thanks, greg k-h