diff for duplicates of <202505300251.vkfxetWu-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 5e6fb77..39af912 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,27 +1,48 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +In-Reply-To: <20250527164003.1068118-6-himal.prasad.ghimiray@intel.com> +References: <20250527164003.1068118-6-himal.prasad.ghimiray@intel.com> +TO: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> +TO: intel-xe@lists.freedesktop.org +CC: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> + Hi Himal, kernel test robot noticed the following build warnings: +[auto build test WARNING on drm-xe/drm-xe-next] +[also build test WARNING on linus/master v6.15 next-20250529] +[If your patch is applied to the wrong git tree, kindly drop us a note. +And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Himal-Prasad-Ghimiray/Introduce-drm_gpuvm_sm_map_ops_flags-enums-for-sm_map_ops/20250528-041919 base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next patch link: https://lore.kernel.org/r/20250527164003.1068118-6-himal.prasad.ghimiray%40intel.com patch subject: [PATCH v3 05/19] drm/xe/vma: Modify new_vma to accept struct xe_vma_mem_attr as parameter +:::::: branch date: 2 days ago +:::::: commit date: 2 days ago config: loongarch-randconfig-r073-20250529 (https://download.01.org/0day-ci/archive/20250530/202505300251.vkfxetWu-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202505300251.vkfxetWu-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/xe/xe_vm.c:2492 new_vma() error: 'vma' dereferencing possible ERR_PTR() +Old smatch warnings: +drivers/gpu/drm/xe/xe_vm.c:2480 new_vma() error: we previously assumed 'bo' could be null (see line 2454) +drivers/gpu/drm/xe/xe_vm.c:2919 prefetch_ranges() warn: iterator 'i' not incremented +arch/loongarch/include/asm/atomic.h:135 arch_atomic_fetch_add_unless() warn: inconsistent indenting +drivers/gpu/drm/xe/xe_vm.c:4082 xe_vm_snapshot_print() warn: passing zero to 'PTR_ERR' + vim +/vma +2492 drivers/gpu/drm/xe/xe_vm.c +341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2443 b06d47be7c83165 Matthew Brost 2023-07-07 2444 static struct xe_vma *new_vma(struct xe_vm *vm, struct drm_gpuva_op_map *op, 341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2445 struct xe_vma_mem_attr attr, unsigned int flags) b06d47be7c83165 Matthew Brost 2023-07-07 2446 { @@ -55,9 +76,6 @@ b06d47be7c83165 Matthew Brost 2023-07-07 2473 op->va.addr, op-> 341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2474 op->va.range - 1, attr.pat_index, flags); 33991ae8f40a824 Matthew Brost 2024-06-17 2475 if (IS_ERR(vma)) 33991ae8f40a824 Matthew Brost 2024-06-17 2476 goto err_unlock; - -Missing "err = PTR_ERR(vma);" - dd08ebf6c3525a7 Matthew Brost 2023-03-30 2477 33991ae8f40a824 Matthew Brost 2024-06-17 2478 if (xe_vma_is_userptr(vma)) 5bd24e78829ad56 Thomas Hellström 2024-01-31 2479 err = xe_vma_userptr_pin_pages(to_userptr_vma(vma)); @@ -74,17 +92,11 @@ b06d47be7c83165 Matthew Brost 2023-07-07 2489 xe_vma_destroy_unlocke 33991ae8f40a824 Matthew Brost 2024-06-17 2490 vma = ERR_PTR(err); 341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2491 } else { 341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 @2492 cp_vma_mem_attr(&vma->attr, &attr); - ^^^^ -leads to error pointer dereference. - dd08ebf6c3525a7 Matthew Brost 2023-03-30 2493 } dd08ebf6c3525a7 Matthew Brost 2023-03-30 2494 b06d47be7c83165 Matthew Brost 2023-07-07 2495 return vma; - -I was wondering why Smatch doesn't catch the missing error code but -actually we return the error code... #ABitConfusing - b06d47be7c83165 Matthew Brost 2023-07-07 2496 } +b06d47be7c83165 Matthew Brost 2023-07-07 2497 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 7223fcd..e812b73 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,39 +1,56 @@ - "ref\020250527164003.1068118-6-himal.prasad.ghimiray@intel.com\0" - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH v3 05/19] drm/xe/vma: Modify new_vma to accept struct xe_vma_mem_attr as parameter\0" - "Date\0Mon, 2 Jun 2025 09:19:15 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> - " intel-xe@lists.freedesktop.org\0" + "Date\0Fri, 30 May 2025 02:52:09 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - " Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "In-Reply-To: <20250527164003.1068118-6-himal.prasad.ghimiray@intel.com>\n" + "References: <20250527164003.1068118-6-himal.prasad.ghimiray@intel.com>\n" + "TO: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>\n" + "TO: intel-xe@lists.freedesktop.org\n" + "CC: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>\n" + "\n" "Hi Himal,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" + "[auto build test WARNING on drm-xe/drm-xe-next]\n" + "[also build test WARNING on linus/master v6.15 next-20250529]\n" + "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" + "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Himal-Prasad-Ghimiray/Introduce-drm_gpuvm_sm_map_ops_flags-enums-for-sm_map_ops/20250528-041919\n" "base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next\n" "patch link: https://lore.kernel.org/r/20250527164003.1068118-6-himal.prasad.ghimiray%40intel.com\n" "patch subject: [PATCH v3 05/19] drm/xe/vma: Modify new_vma to accept struct xe_vma_mem_attr as parameter\n" + ":::::: branch date: 2 days ago\n" + ":::::: commit date: 2 days ago\n" "config: loongarch-randconfig-r073-20250529 (https://download.01.org/0day-ci/archive/20250530/202505300251.vkfxetWu-lkp@intel.com/config)\n" "compiler: loongarch64-linux-gcc (GCC) 15.1.0\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202505300251.vkfxetWu-lkp@intel.com/\n" "\n" "New smatch warnings:\n" "drivers/gpu/drm/xe/xe_vm.c:2492 new_vma() error: 'vma' dereferencing possible ERR_PTR()\n" "\n" + "Old smatch warnings:\n" + "drivers/gpu/drm/xe/xe_vm.c:2480 new_vma() error: we previously assumed 'bo' could be null (see line 2454)\n" + "drivers/gpu/drm/xe/xe_vm.c:2919 prefetch_ranges() warn: iterator 'i' not incremented\n" + "arch/loongarch/include/asm/atomic.h:135 arch_atomic_fetch_add_unless() warn: inconsistent indenting\n" + "drivers/gpu/drm/xe/xe_vm.c:4082 xe_vm_snapshot_print() warn: passing zero to 'PTR_ERR'\n" + "\n" "vim +/vma +2492 drivers/gpu/drm/xe/xe_vm.c\n" "\n" + "341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2443 \n" "b06d47be7c83165 Matthew Brost 2023-07-07 2444 static struct xe_vma *new_vma(struct xe_vm *vm, struct drm_gpuva_op_map *op,\n" "341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2445 \t\t\t struct xe_vma_mem_attr attr, unsigned int flags)\n" "b06d47be7c83165 Matthew Brost 2023-07-07 2446 {\n" @@ -67,9 +84,6 @@ "341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2474 \t\t\t op->va.range - 1, attr.pat_index, flags);\n" "33991ae8f40a824 Matthew Brost 2024-06-17 2475 \tif (IS_ERR(vma))\n" "33991ae8f40a824 Matthew Brost 2024-06-17 2476 \t\tgoto err_unlock;\n" - "\n" - "Missing \"err = PTR_ERR(vma);\"\n" - "\n" "dd08ebf6c3525a7 Matthew Brost 2023-03-30 2477 \n" "33991ae8f40a824 Matthew Brost 2024-06-17 2478 \tif (xe_vma_is_userptr(vma))\n" "5bd24e78829ad56 Thomas Hellstr\303\266m 2024-01-31 2479 \t\terr = xe_vma_userptr_pin_pages(to_userptr_vma(vma));\n" @@ -86,20 +100,14 @@ "33991ae8f40a824 Matthew Brost 2024-06-17 2490 \t\tvma = ERR_PTR(err);\n" "341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 2491 \t} else {\n" "341ac2942dd2087 Himal Prasad Ghimiray 2025-05-27 @2492 \t\tcp_vma_mem_attr(&vma->attr, &attr);\n" - " ^^^^\n" - "leads to error pointer dereference.\n" - "\n" "dd08ebf6c3525a7 Matthew Brost 2023-03-30 2493 \t}\n" "dd08ebf6c3525a7 Matthew Brost 2023-03-30 2494 \n" "b06d47be7c83165 Matthew Brost 2023-07-07 2495 \treturn vma;\n" - "\n" - "I was wondering why Smatch doesn't catch the missing error code but\n" - "actually we return the error code... #ABitConfusing\n" - "\n" "b06d47be7c83165 Matthew Brost 2023-07-07 2496 }\n" + "b06d47be7c83165 Matthew Brost 2023-07-07 2497 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -02ad160b7d3454530d263d194f11881e0f8bdb335aebcfe13c50a090f33d6b87 +f5d464b1a41dae9838ac17acdb0696783728b71a0cede22820f119de204b89a6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.