From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FBA188587 for ; Mon, 2 Jun 2025 06:20:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748845219; cv=none; b=c+dQ5plWopggR7gfQeAVphKMBl2q0bn+iJVnq3SuJpQmbpLMdnRKk4T/4+JZ+kHX5i5IKnKnvDGFamewgBREj0URCzymsc+heqN+NqUL9aHlqCH+d5S15hxtbMgubgSHszUuoy9Fhxret/9h7QhlKukZAx8VNxF/wqB/EGeYcgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748845219; c=relaxed/simple; bh=uqhiVvUTjJUz12WNnC5vQ4AYx38ysdEHyQ+YwgWYwRo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=Ic5Ghzok8rsRJzIKYlDD1CUIIyB7u0mH57yjOSME2hluaZQ+jhtTiMW65izqqlWuAIIWWZFtx8OGJFRNLmb4JWbSvbpAJFWvDyfUJalAcV1DYLp8ZsI8EMfkRs9DPeUsB/tqHc5OQuW1lY55xzRUEw9VBA9LZwC0zdwsrtoHzYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sSU7IPnO; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sSU7IPnO" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so46216115e9.2 for ; Sun, 01 Jun 2025 23:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748845215; x=1749450015; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tOEMUoWDeDY5mzeOr4SEl8dbwxhrqozXvwOKEHtHeUk=; b=sSU7IPnOUUi7yGcTpR5L7oLOSaKVyOCpIH90T675LubPUAtDorfV2PnXkARETVOF4E eSN21BtaPO4Mp3AboQeI7H5hEH9x+yuudFzdhZ+IGQe8mN4Eb3yDjXRYywwANhgBKPuD zmar0EDkt2RZmDoC4L5cW3BoNNUnhffc7AxjZ1AUc1sybPS27ySDo8Fu61u+rbgtVcMj WmMqNQf9DLHfYY0PsgSN69SvMfiXRmMi8Vbjv9weRrJKcyUhZZXgv2hajgB/hw4BwSoG Or1YGfToONsRlikOEfBQx5kAyQSaaIwvQ/AW4DG5BXD67E2STBTZgIYGmg99JuXluCF1 rSBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748845215; x=1749450015; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tOEMUoWDeDY5mzeOr4SEl8dbwxhrqozXvwOKEHtHeUk=; b=A7vLBx9asN8Dzk7lkmfNUB+JhBoTyWFVygGAKrecL7JG1yAVNjBHa2F9U2b0F2Z3Ir 2q88qItTg/rgmYq5ihuUAm8f+0SLca6HtrVpEuoGmkmxdgaMekydrra1QBMsGVh2lHm+ pPl8Q9QQKd75oTffCoVPl7ZOHtWeuLq5GB7ekkIg1fD6xzWSnU66k8WGxNsPDn9dkKW/ yMKoOhCpeZ/0HdpNODh4RwYrUPFoN61EKYfGAu/ARABEDfeU26QNSpjQEYao4JyGViVV ZVeL2O7gKqmazvIRxsqbwwjWYli6Nuvk0Wh9mUh1k+QXQQUaHKYVChiRM6jptx3QPlxU 04eg== X-Forwarded-Encrypted: i=1; AJvYcCXFRrnBftrv+9BxGGyBuWH9Z+27uX86vzseAlrDS9uCrsOaTibUgXTjD67ahrgOHH6i5cE=@vger.kernel.org X-Gm-Message-State: AOJu0YzeBUTxnPr3SWlIfxQxIstSubHLLw3yxQonrfP6pxN5gg2j7dES Rjl9K7frtTlwGdv2OxAXszEgZUMb9IqV6hn05+exi1AsOa7ilAaBQknYXELZ3SWPBvM= X-Gm-Gg: ASbGncsL5/37biWMIWNMAobT9KLAjnGkrsINfKgDVjX6UFaDwCI668tDsK90tK4Kgfk S3J6APPVCoIsOotxSSfUE9Mix+St2MyvRxfN70GVBoj8IiP8puPERYGy1kVj96JFfchUPjFT2J1 Eo2J+1/gbk9hx5rwW0gF24NXd4w++ncsFtH1SJByfu7ISmT/2Y8l1i1M/e/FJLnABkpYH8pzK04 YGw4tzGTCZNBHnJH3W5+2oU5Pc1zuJ4slLJXc758veTgTvFziDHz3cVBzqD+m4U2TVO8TXm8Rip 6mJhNIOTDrCRj8/RAxVYFRAtWr4+74Qfo2n/1ap9mDLlYDTpRc9fWH8= X-Google-Smtp-Source: AGHT+IEhg9lSTzexUaVbkdcQrdyWsGg7a4BXZ1AHF91UKUvvwVHEH4xwEI9JAg73XATTsIBgax4M7A== X-Received: by 2002:a05:600c:4f05:b0:43c:ea1a:720c with SMTP id 5b1f17b1804b1-4511ee13fb8mr65790875e9.18.1748845215311; Sun, 01 Jun 2025 23:20:15 -0700 (PDT) Received: from localhost ([41.210.143.146]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-450d7fa24c6sm108973155e9.12.2025.06.01.23.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Jun 2025 23:20:14 -0700 (PDT) Date: Mon, 2 Jun 2025 09:20:10 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Rong Tao , ast@kernel.org, daniel@iogearbox.net Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, rtoax@foxmail.com, rongtao@cestc.cn, Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , Juntong Deng , Amery Hung , Dave Marchevsky , Hou Tao , "(open list:BPF (Safe Dynamic Programs and Tools))" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf-next 1/2] bpf: Add bpf_task_cwd_from_pid() kfunc Message-ID: <202505300432.nZC50gOu-lkp@intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Rong, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Rong-Tao/selftests-bpf-Add-selftests-for-bpf_task_cwd_from_pid/20250529-113933 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/tencent_97F8B56B340F51DB604B482FEBF012460505%40qq.com patch subject: [PATCH bpf-next 1/2] bpf: Add bpf_task_cwd_from_pid() kfunc config: x86_64-randconfig-161-20250529 (https://download.01.org/0day-ci/archive/20250530/202505300432.nZC50gOu-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202505300432.nZC50gOu-lkp@intel.com/ smatch warnings: kernel/bpf/helpers.c:2687 bpf_task_cwd_from_pid() warn: inconsistent returns 'rcu_read'. vim +/rcu_read +2687 kernel/bpf/helpers.c b24383bde5a454 Rong Tao 2025-05-29 2657 __bpf_kfunc int bpf_task_cwd_from_pid(s32 pid, char *buf, u32 buf_len) b24383bde5a454 Rong Tao 2025-05-29 2658 { b24383bde5a454 Rong Tao 2025-05-29 2659 struct path pwd; b24383bde5a454 Rong Tao 2025-05-29 2660 char kpath[256], *path; b24383bde5a454 Rong Tao 2025-05-29 2661 struct task_struct *task; b24383bde5a454 Rong Tao 2025-05-29 2662 b24383bde5a454 Rong Tao 2025-05-29 2663 if (!buf || buf_len == 0) b24383bde5a454 Rong Tao 2025-05-29 2664 return -EINVAL; b24383bde5a454 Rong Tao 2025-05-29 2665 b24383bde5a454 Rong Tao 2025-05-29 2666 rcu_read_lock(); b24383bde5a454 Rong Tao 2025-05-29 2667 task = pid_task(find_vpid(pid), PIDTYPE_PID); b24383bde5a454 Rong Tao 2025-05-29 2668 if (!task) { b24383bde5a454 Rong Tao 2025-05-29 2669 rcu_read_unlock(); b24383bde5a454 Rong Tao 2025-05-29 2670 return -ESRCH; b24383bde5a454 Rong Tao 2025-05-29 2671 } b24383bde5a454 Rong Tao 2025-05-29 2672 task_lock(task); b24383bde5a454 Rong Tao 2025-05-29 2673 if (!task->fs) { b24383bde5a454 Rong Tao 2025-05-29 2674 task_unlock(task); b24383bde5a454 Rong Tao 2025-05-29 2675 return -ENOENT; rcu_read_unlock(); b24383bde5a454 Rong Tao 2025-05-29 2676 } b24383bde5a454 Rong Tao 2025-05-29 2677 get_fs_pwd(task->fs, &pwd); b24383bde5a454 Rong Tao 2025-05-29 2678 task_unlock(task); b24383bde5a454 Rong Tao 2025-05-29 2679 rcu_read_unlock(); b24383bde5a454 Rong Tao 2025-05-29 2680 b24383bde5a454 Rong Tao 2025-05-29 2681 path = d_path(&pwd, kpath, sizeof(kpath)); b24383bde5a454 Rong Tao 2025-05-29 2682 path_put(&pwd); b24383bde5a454 Rong Tao 2025-05-29 2683 if (IS_ERR(path)) b24383bde5a454 Rong Tao 2025-05-29 2684 return PTR_ERR(path); b24383bde5a454 Rong Tao 2025-05-29 2685 b24383bde5a454 Rong Tao 2025-05-29 2686 strncpy(buf, path, buf_len); b24383bde5a454 Rong Tao 2025-05-29 @2687 return 0; b24383bde5a454 Rong Tao 2025-05-29 2688 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A7B1E32BE for ; Thu, 29 May 2025 20:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550718; cv=none; b=JCHuDaH8LB7VzdV+Rxs5YfNKnhAUgBZmISYrI5zrY4zFOCs2w56Lx816jQesyX9yWeNQbJmYCb7uZhKqVPJ9NO3lwyO1XpYaLXPyQ1w/XzEF1N0jPP3lpp/nIpScityKtDgn/meKoKvTzVw5cfp9f1T80i6tjGRWUN57rY91DqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748550718; c=relaxed/simple; bh=9gU63y35s+MhsQx02DMjin3lHacBIrXpQmpY+NFK4mw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dbpHCvEgBfGGubsvFuPr2KxYBfIEu+95ltT6bI3kZgjHjCJER6P4qHaH1mA9bD4bx6guj0Rp759vjp9q5gkQ59ZSP4jSd03I26K3WYC9dhFSv7FKoymWGzhLERlnytnDxInshc7IX1Rap0aNDiIo291jDwgF0lFJTwbJgEtDf14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cQNG9kBX; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cQNG9kBX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748550716; x=1780086716; h=date:from:to:cc:subject:message-id:mime-version; bh=9gU63y35s+MhsQx02DMjin3lHacBIrXpQmpY+NFK4mw=; b=cQNG9kBXhzlsCos+gjXIheoC3gYKHJjDp0M/SGkiuPsvPiMfR0zWYEZS UJsBSGEQLheyeP50woO5hGIm6KccOHrZo293ertDO64owLUZq4PH+ElGc v600KnbRS+KZXxDx4DNcWjJt4AdTWp8Wv07JRoCmlMPtSQ73QI1up1eK5 H85iga2g7kRZNJlHth5B0Z25RlzALO/dhuTL3hsqfUfAKcavCuTRLGht5 WxSKYTmXA1zfbnCxFhRfoAYCxvvG8vcb+z83snUtUSrwY7qNocdkrBZYK GgAyxHLI2JFeSKn2TQZMg7jQNtuVhY971j8dEYFjqEsdVutPsqSnYZIsC g==; X-CSE-ConnectionGUID: hcfZPNmESBahjBDT8/l8kA== X-CSE-MsgGUID: oLqNUy0rTMSofrY6LO3udg== X-IronPort-AV: E=McAfee;i="6700,10204,11448"; a="61296602" X-IronPort-AV: E=Sophos;i="6.16,193,1744095600"; d="scan'208";a="61296602" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2025 13:31:55 -0700 X-CSE-ConnectionGUID: 7fx5kIsbRtioZUQRhiyT+g== X-CSE-MsgGUID: Ju92TXBgRW+IN31zZossvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,193,1744095600"; d="scan'208";a="143694648" Received: from lkp-server01.sh.intel.com (HELO 1992f890471c) ([10.239.97.150]) by orviesa009.jf.intel.com with ESMTP; 29 May 2025 13:31:53 -0700 Received: from kbuild by 1992f890471c with local (Exim 4.96) (envelope-from ) id 1uKjup-000X4G-00; Thu, 29 May 2025 20:31:51 +0000 Date: Fri, 30 May 2025 04:30:59 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: Re: [PATCH bpf-next 1/2] bpf: Add bpf_task_cwd_from_pid() kfunc Message-ID: <202505300432.nZC50gOu-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: References: TO: Rong Tao TO: ast@kernel.org TO: daniel@iogearbox.net CC: rtoax@foxmail.com CC: rongtao@cestc.cn CC: Andrii Nakryiko CC: Martin KaFai Lau CC: Eduard Zingerman CC: Song Liu CC: Yonghong Song CC: John Fastabend CC: KP Singh CC: Stanislav Fomichev CC: Hao Luo CC: Jiri Olsa CC: Mykola Lysenko CC: Shuah Khan CC: Juntong Deng CC: Amery Hung CC: Dave Marchevsky CC: Hou Tao CC: "(open list:BPF \(Safe Dynamic Programs and Tools\))" (open list:BPF (Safe Dynamic Programs and Tools)) CC: linux-kernel@vger.kernel.org CC: linux-kselftest@vger.kernel.org Hi Rong, kernel test robot noticed the following build warnings: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Rong-Tao/selftests-bpf-Add-selftests-for-bpf_task_cwd_from_pid/20250529-113933 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/tencent_97F8B56B340F51DB604B482FEBF012460505%40qq.com patch subject: [PATCH bpf-next 1/2] bpf: Add bpf_task_cwd_from_pid() kfunc :::::: branch date: 17 hours ago :::::: commit date: 17 hours ago config: x86_64-randconfig-161-20250529 (https://download.01.org/0day-ci/archive/20250530/202505300432.nZC50gOu-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202505300432.nZC50gOu-lkp@intel.com/ smatch warnings: kernel/bpf/helpers.c:2687 bpf_task_cwd_from_pid() warn: inconsistent returns 'rcu_read'. vim +/rcu_read +2687 kernel/bpf/helpers.c 675c3596ff32c0 Juntong Deng 2024-10-14 2649 b24383bde5a454 Rong Tao 2025-05-29 2650 /** b24383bde5a454 Rong Tao 2025-05-29 2651 * bpf_task_cwd_from_pid - Get a task's absolute pathname of the current b24383bde5a454 Rong Tao 2025-05-29 2652 * working directory from its pid. b24383bde5a454 Rong Tao 2025-05-29 2653 * @pid: The pid of the task being looked up. b24383bde5a454 Rong Tao 2025-05-29 2654 * @buf: The array pointed to by buf. b24383bde5a454 Rong Tao 2025-05-29 2655 * @buf_len: buf length. b24383bde5a454 Rong Tao 2025-05-29 2656 */ b24383bde5a454 Rong Tao 2025-05-29 2657 __bpf_kfunc int bpf_task_cwd_from_pid(s32 pid, char *buf, u32 buf_len) b24383bde5a454 Rong Tao 2025-05-29 2658 { b24383bde5a454 Rong Tao 2025-05-29 2659 struct path pwd; b24383bde5a454 Rong Tao 2025-05-29 2660 char kpath[256], *path; b24383bde5a454 Rong Tao 2025-05-29 2661 struct task_struct *task; b24383bde5a454 Rong Tao 2025-05-29 2662 b24383bde5a454 Rong Tao 2025-05-29 2663 if (!buf || buf_len == 0) b24383bde5a454 Rong Tao 2025-05-29 2664 return -EINVAL; b24383bde5a454 Rong Tao 2025-05-29 2665 b24383bde5a454 Rong Tao 2025-05-29 2666 rcu_read_lock(); b24383bde5a454 Rong Tao 2025-05-29 2667 task = pid_task(find_vpid(pid), PIDTYPE_PID); b24383bde5a454 Rong Tao 2025-05-29 2668 if (!task) { b24383bde5a454 Rong Tao 2025-05-29 2669 rcu_read_unlock(); b24383bde5a454 Rong Tao 2025-05-29 2670 return -ESRCH; b24383bde5a454 Rong Tao 2025-05-29 2671 } b24383bde5a454 Rong Tao 2025-05-29 2672 task_lock(task); b24383bde5a454 Rong Tao 2025-05-29 2673 if (!task->fs) { b24383bde5a454 Rong Tao 2025-05-29 2674 task_unlock(task); b24383bde5a454 Rong Tao 2025-05-29 2675 return -ENOENT; b24383bde5a454 Rong Tao 2025-05-29 2676 } b24383bde5a454 Rong Tao 2025-05-29 2677 get_fs_pwd(task->fs, &pwd); b24383bde5a454 Rong Tao 2025-05-29 2678 task_unlock(task); b24383bde5a454 Rong Tao 2025-05-29 2679 rcu_read_unlock(); b24383bde5a454 Rong Tao 2025-05-29 2680 b24383bde5a454 Rong Tao 2025-05-29 2681 path = d_path(&pwd, kpath, sizeof(kpath)); b24383bde5a454 Rong Tao 2025-05-29 2682 path_put(&pwd); b24383bde5a454 Rong Tao 2025-05-29 2683 if (IS_ERR(path)) b24383bde5a454 Rong Tao 2025-05-29 2684 return PTR_ERR(path); b24383bde5a454 Rong Tao 2025-05-29 2685 b24383bde5a454 Rong Tao 2025-05-29 2686 strncpy(buf, path, buf_len); b24383bde5a454 Rong Tao 2025-05-29 @2687 return 0; b24383bde5a454 Rong Tao 2025-05-29 2688 } b24383bde5a454 Rong Tao 2025-05-29 2689 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki