From: 李哲 <sensor1010@163.com>
To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, jonas@kwiboo.se,
rmk+kernel@armlinux.org.uk, david.wu@rock-chips.com,
jan.petrous@oss.nxp.com, detlev.casanova@collabora.com
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, 李哲 <sensor1010@163.com>
Subject: [PATCH] net: dwmac-rk: No need to check the return value of the phy_power_on()
Date: Fri, 30 May 2025 09:20:17 -0700 [thread overview]
Message-ID: <20250530162017.3661-1-sensor1010@163.com> (raw)
phy_power_on() is a local scope one within the driver, since the return
value of the phy_power_on() function is always 0, checking its return
value is redundant.
Signed-off-by: 李哲 <sensor1010@163.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 700858ff6f7c..f7c32934f8a4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -1645,23 +1645,18 @@ static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable)
return 0;
}
-static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
+static void phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
{
struct regulator *ldo = bsp_priv->regulator;
- int ret;
struct device *dev = &bsp_priv->pdev->dev;
if (enable) {
- ret = regulator_enable(ldo);
- if (ret)
+ if (regulator_enable(ldo))
dev_err(dev, "fail to enable phy-supply\n");
} else {
- ret = regulator_disable(ldo);
- if (ret)
+ if (regulator_disable(ldo))
dev_err(dev, "fail to disable phy-supply\n");
}
-
- return 0;
}
static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
@@ -1839,11 +1834,7 @@ static int rk_gmac_powerup(struct rk_priv_data *bsp_priv)
dev_err(dev, "NO interface defined!\n");
}
- ret = phy_power_on(bsp_priv, true);
- if (ret) {
- gmac_clk_enable(bsp_priv, false);
- return ret;
- }
+ phy_power_on(bsp_priv, true);
pm_runtime_get_sync(dev);
--
2.17.1
next reply other threads:[~2025-05-30 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 16:20 李哲 [this message]
2025-05-30 16:37 ` [PATCH] net: dwmac-rk: No need to check the return value of the phy_power_on() Russell King (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2025-05-26 16:16 李哲
2025-05-26 17:05 ` Andrew Lunn
2025-05-27 5:43 ` Christophe JAILLET
2025-05-27 13:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250530162017.3661-1-sensor1010@163.com \
--to=sensor1010@163.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=detlev.casanova@collabora.com \
--cc=edumazet@google.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jonas@kwiboo.se \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.