From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: platform-driver-x86@vger.kernel.org,
intel-xe@lists.freedesktop.org, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com,
rodrigo.vivi@intel.com
Cc: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Subject: [PATCH 01/10] drm/xe: Correct BMG VSEC header sizing
Date: Fri, 30 May 2025 16:33:38 -0400 [thread overview]
Message-ID: <20250530203356.190234-1-michael.j.ruhl@intel.com> (raw)
The intel_vsec_header information for the crashlog feature
is incorrect.
Update the VSEC header with correct sizing and count.
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
drivers/gpu/drm/xe/xe_vsec.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 3e573b0b7ebd..67238fc57a4d 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -32,28 +32,18 @@ static struct intel_vsec_header bmg_telemetry = {
.offset = BMG_DISCOVERY_OFFSET,
};
-static struct intel_vsec_header bmg_punit_crashlog = {
- .length = 0x10,
+static struct intel_vsec_header bmg_crashlog = {
+ .length = 0x18,
.id = VSEC_ID_CRASHLOG,
- .num_entries = 1,
- .entry_size = 4,
+ .num_entries = 2,
+ .entry_size = 6,
.tbir = 0,
.offset = BMG_DISCOVERY_OFFSET + 0x60,
};
-static struct intel_vsec_header bmg_oobmsm_crashlog = {
- .length = 0x10,
- .id = VSEC_ID_CRASHLOG,
- .num_entries = 1,
- .entry_size = 4,
- .tbir = 0,
- .offset = BMG_DISCOVERY_OFFSET + 0x78,
-};
-
static struct intel_vsec_header *bmg_capabilities[] = {
&bmg_telemetry,
- &bmg_punit_crashlog,
- &bmg_oobmsm_crashlog,
+ &bmg_crashlog,
NULL
};
--
2.49.0
next reply other threads:[~2025-05-30 20:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 20:33 Michael J. Ruhl [this message]
2025-05-30 20:33 ` [PATCH 02/10] platform/x86/intel/pmt: white space cleanup Michael J. Ruhl
2025-05-31 5:19 ` Ilpo Järvinen
2025-05-30 20:33 ` [PATCH 03/10] platform/x86/intel/pmt: use guard(mutex) Michael J. Ruhl
2025-05-31 5:23 ` Ilpo Järvinen
2025-06-02 14:59 ` Ruhl, Michael J
2025-06-02 15:37 ` Ilpo Järvinen
2025-05-30 20:33 ` [PATCH 04/10] platform/x86/intel: refactor endpoint usage Michael J. Ruhl
2025-05-31 5:29 ` Ilpo Järvinen
2025-06-02 15:01 ` Ruhl, Michael J
2025-05-30 20:33 ` [PATCH 05/10] platform/x86/intel/pmt: crashlog binary file endpoint Michael J. Ruhl
2025-05-31 5:36 ` Ilpo Järvinen
2025-06-02 15:02 ` Ruhl, Michael J
2025-05-30 20:33 ` [PATCH 06/10] platform/x86/intel/pmt: decouple sysfs and namespace Michael J. Ruhl
2025-05-30 20:33 ` [PATCH 07/10] platform/x86/intel/pmt: use a version struct Michael J. Ruhl
2025-05-31 5:46 ` Ilpo Järvinen
2025-06-02 17:57 ` Ruhl, Michael J
2025-06-03 7:06 ` Ilpo Järvinen
2025-05-30 20:33 ` [PATCH 08/10] platform/x86/intel/pmt: support BMG crashlog Michael J. Ruhl
2025-05-31 5:52 ` Ilpo Järvinen
2025-06-02 18:00 ` Ruhl, Michael J
2025-05-30 20:33 ` [PATCH 09/10] sysfs debug Michael J. Ruhl
2025-05-31 5:53 ` Ilpo Järvinen
2025-06-02 15:07 ` Ruhl, Michael J
2025-05-31 5:17 ` [PATCH 01/10] drm/xe: Correct BMG VSEC header sizing Ilpo Järvinen
2025-05-31 5:18 ` Ilpo Järvinen
2025-06-02 14:54 ` Ruhl, Michael J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250530203356.190234-1-michael.j.ruhl@intel.com \
--to=michael.j.ruhl@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.