From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Shiju Jose" <shiju.jose@huawei.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Ani Sinha" <anisinha@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available
Date: Fri, 30 May 2025 22:18:10 +0200 [thread overview]
Message-ID: <20250530221810.694ce02e@foz.lan> (raw)
In-Reply-To: <20250530164903.0f9f8444@imammedo.users.ipa.redhat.com>
Em Fri, 30 May 2025 16:49:03 +0200
Igor Mammedov <imammedo@redhat.com> escreveu:
> On Fri, 30 May 2025 08:01:28 -0400
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Wed, May 28, 2025 at 05:42:12PM +0200, Igor Mammedov wrote:
> > > On Tue, 20 May 2025 08:41:31 +0200
> > > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> > >
> > > > Create a new property (x-has-hest-addr) and use it to detect if
> > > > the GHES table offsets can be calculated from the HEST address
> > > > (qemu 10.0 and upper) or via the legacy way via an offset obtained
> > > > from the hardware_errors firmware file.
> > >
> > >
> > > it doesn't apply to current master anymore
> >
> > indeed. Mauro?
>
> Michael,
> it's trivial conflict in machine compat,
> could you fix it up while applying?
IMHO, that's the best. The thing is, as code gets merged upstream with
backports, conflicts happen.
I can re-send the series, if you prefer, as I'm keeping it rebasing it
from time to time at:
https://gitlab.com/mchehab_kernel/qemu/-/tree/qemu_submitted?ref_type=heads
(it is on the top of upstream/master)
But even that might have conflicts on your test tree if you pick
other patches touching this backport table:
> -GlobalProperty hw_compat_10_0[] = {};
> +GlobalProperty hw_compat_10_0[] = {
> + { TYPE_ACPI_GED, "x-has-hest-addr", "false" },
> +};
(this was the code when I sent the PR. When applying upstream,
such hunk is now(*):
GlobalProperty hw_compat_10_0[] = {
{ "scsi-hd", "dpofua", "off" },
+ { TYPE_ACPI_GED, "x-has-hest-addr", "false" },
};
(*) https://gitlab.com/mchehab_kernel/qemu/-/commit/08c4859f8c6f36d7dccf2b773be88847e5d1fe0c
If you still prefer that I resubmit the entire PR, let me know.
Regards,
Mauro
next prev parent reply other threads:[~2025-05-30 20:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 6:41 [PATCH v9 00/20] Change ghes to use HEST-based offsets and add support for error inject Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 01/20] tests/acpi: virt: add an empty HEST file Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 02/20] tests/qtest/bios-tables-test: extend to also check HEST table Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 03/20] tests/acpi: virt: update HEST file with its current data Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 04/20] Revert "hw/acpi/ghes: Make ghes_record_cper_errors() static" Mauro Carvalho Chehab
2025-05-20 8:34 ` Jonathan Cameron
2025-05-20 8:34 ` Jonathan Cameron via
2025-05-20 6:41 ` [PATCH v9 05/20] acpi/ghes: Cleanup the code which gets ghes ged state Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 06/20] acpi/ghes: prepare to change the way HEST offsets are calculated Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 07/20] acpi/ghes: add a firmware file with HEST address Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 08/20] acpi/ghes: Use HEST table offsets when preparing GHES records Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 09/20] acpi/ghes: don't hard-code the number of sources for HEST table Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 10/20] acpi/ghes: add a notifier to notify when error data is ready Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 11/20] acpi/generic_event_device: Update GHES migration to cover hest addr Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available Mauro Carvalho Chehab
2025-05-28 15:42 ` Igor Mammedov
2025-05-30 12:01 ` Michael S. Tsirkin
2025-05-30 14:49 ` Igor Mammedov
2025-05-30 20:18 ` Mauro Carvalho Chehab [this message]
2025-06-02 10:22 ` Igor Mammedov
2025-06-02 12:57 ` [PATCH v10 12/20 RESEND] " Mauro Carvalho Chehab
2025-06-02 12:52 ` [PATCH v10 12/26] " Mauro Carvalho Chehab
2025-06-02 11:28 ` [PATCH v9 12/20] " Mauro Carvalho Chehab
2025-06-02 12:52 ` [PATCH v10 12/26] " Mauro Carvalho Chehab
2025-06-02 12:52 ` Mauro Carvalho Chehab
2025-06-02 12:52 ` Mauro Carvalho Chehab
2025-06-02 12:57 ` [PATCH v10 12/20 RESEND] " Mauro Carvalho Chehab
2025-06-02 12:57 ` Mauro Carvalho Chehab
2025-06-02 12:57 ` Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 13/20] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 14/20] tests/acpi: virt: allow acpi table changes at DSDT and HEST tables Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 15/20] arm/virt: Wire up a GED error device for ACPI / GHES Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 16/20] qapi/acpi-hest: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 17/20] acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 18/20] tests/acpi: virt: update HEST and DSDT tables Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 19/20] docs: hest: add new "etc/acpi_table_hest_addr" and update workflow Mauro Carvalho Chehab
2025-05-20 6:41 ` [PATCH v9 20/20] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250530221810.694ce02e@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=shiju.jose@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.