All of lore.kernel.org
 help / color / mirror / Atom feed
From: deller@kernel.org
To: linux-kernel@vger.kernel.org, apparmor@lists.ubuntu.com,
	John Johansen <john.johansen@canonical.com>,
	linux-security-module@vger.kernel.org
Cc: Helge Deller <deller@gmx.de>
Subject: [PATCH 2/2] apparmor: Fix unaligned memory accesses in KUnit test
Date: Sat, 31 May 2025 17:08:22 +0200	[thread overview]
Message-ID: <20250531150822.135803-3-deller@kernel.org> (raw)
In-Reply-To: <20250531150822.135803-1-deller@kernel.org>

From: Helge Deller <deller@gmx.de>

The testcase triggers some unneccessary unaligned memory accesses on the
parisc architecture:
  Kernel: unaligned access to 0x12f28e27 in policy_unpack_test_init+0x180/0x374 (iir 0x0cdc1280)
  Kernel: unaligned access to 0x12f28e67 in policy_unpack_test_init+0x270/0x374 (iir 0x64dc00ce)

Use the existing helper functions put_unaligned_le32() and
put_unaligned_le16() to avoid such warnings on architectures which
prefer aligned memory accesses.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 security/apparmor/policy_unpack_test.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
index 5b2ba88ae9e2..cf18744dafe2 100644
--- a/security/apparmor/policy_unpack_test.c
+++ b/security/apparmor/policy_unpack_test.c
@@ -9,6 +9,8 @@
 #include "include/policy.h"
 #include "include/policy_unpack.h"
 
+#include <linux/unaligned.h>
+
 #define TEST_STRING_NAME "TEST_STRING"
 #define TEST_STRING_DATA "testing"
 #define TEST_STRING_BUF_OFFSET \
@@ -80,7 +82,7 @@ static struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
 	*(buf + 1) = strlen(TEST_U32_NAME) + 1;
 	strscpy(buf + 3, TEST_U32_NAME, e->end - (void *)(buf + 3));
 	*(buf + 3 + strlen(TEST_U32_NAME) + 1) = AA_U32;
-	*((__le32 *)(buf + 3 + strlen(TEST_U32_NAME) + 2)) = cpu_to_le32(TEST_U32_DATA);
+	put_unaligned_le32(TEST_U32_DATA, buf + 3 + strlen(TEST_U32_NAME) + 2);
 
 	buf = e->start + TEST_NAMED_U64_BUF_OFFSET;
 	*buf = AA_NAME;
@@ -103,7 +105,7 @@ static struct aa_ext *build_aa_ext_struct(struct policy_unpack_fixture *puf,
 	*(buf + 1) = strlen(TEST_ARRAY_NAME) + 1;
 	strscpy(buf + 3, TEST_ARRAY_NAME, e->end - (void *)(buf + 3));
 	*(buf + 3 + strlen(TEST_ARRAY_NAME) + 1) = AA_ARRAY;
-	*((__le16 *)(buf + 3 + strlen(TEST_ARRAY_NAME) + 2)) = cpu_to_le16(TEST_ARRAY_SIZE);
+	put_unaligned_le16(TEST_ARRAY_SIZE, buf + 3 + strlen(TEST_ARRAY_NAME) + 2);
 
 	return e;
 }
-- 
2.47.0


  parent reply	other threads:[~2025-05-31 15:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-31 15:08 [PATCH 0/2] apparmor unaligned memory fixes deller
2025-05-31 15:08 ` [PATCH 1/2] apparmor: Fix 8-byte alignment for initial dfa blob streams deller
2025-05-31 15:08 ` deller [this message]
2025-11-18  9:04 ` [PATCH 0/2] apparmor unaligned memory fixes John Paul Adrian Glaubitz
2025-11-18 11:09   ` Helge Deller
2025-11-18 11:43     ` John Paul Adrian Glaubitz
2025-11-18 12:49       ` Helge Deller
2025-11-23  2:08         ` John Johansen
2025-11-25 15:11           ` Helge Deller
2025-11-25 19:20             ` John Johansen
2025-11-25 21:13               ` Helge Deller
2025-11-26  9:11                 ` John Johansen
2025-11-26 10:44                   ` david laight
2025-11-26 11:03                     ` Helge Deller
2025-11-26 11:31                       ` Helge Deller
2025-11-26 16:16                         ` John Paul Adrian Glaubitz
2025-11-26 16:58                           ` Helge Deller
2025-11-26 17:26                             ` John Paul Adrian Glaubitz
2025-11-26 14:22                       ` david laight
2025-11-26 15:12                         ` Helge Deller
2025-11-26 19:33                           ` John Johansen
2025-11-26 20:15                             ` Helge Deller
2025-11-26 21:10                               ` John Johansen
2025-11-27  9:25                               ` John Paul Adrian Glaubitz
2025-11-27  9:43                                 ` John Paul Adrian Glaubitz
2025-11-28  9:54                               ` John Paul Adrian Glaubitz
2025-11-26 21:23                           ` david laight
2025-11-26 22:18                             ` John Johansen
2025-11-26 19:22                     ` John Johansen
2025-11-26  7:27             ` John Paul Adrian Glaubitz
2025-11-26  7:52             ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250531150822.135803-3-deller@kernel.org \
    --to=deller@kernel.org \
    --cc=apparmor@lists.ubuntu.com \
    --cc=deller@gmx.de \
    --cc=john.johansen@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.