Re: [Buildroot] [PATCH v2 4/6] package/qt6/qt6tools: fix assistant build failure

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Roy,

On Sun,  1 Jun 2025 12:12:58 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> +config BR2_PACKAGE_QT6TOOLS_ASSISTANT
> +	bool "assistant"
> +	select BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT # qhelpgenerator
> +	select BR2_PACKAGE_QT6BASE_GUI
> +	select BR2_PACKAGE_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_QT6BASE_PRINTSUPPORT # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_QT6BASE_SQL # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_QT6BASE_SQLITE # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	help
> +	  Viewer for Qt help files (.qch), providing searchable and
> +	  navigable documentation for Qt and custom projects.

Same question: why would we want this on the target at all?


>  if BR2_PACKAGE_HOST_QT6TOOLS
>  
> +config BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT
> +	bool "host assistant"
> +	select BR2_PACKAGE_HOST_QT6BASE_GUI
> +	select BR2_PACKAGE_HOST_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_HOST_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_HOST_QT6BASE_SQL # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_HOST_QT6BASE_SQLITE # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_HOST_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	help
> +	  Viewer for Qt help files (.qch), providing searchable and
> +	  navigable documentation for Qt and custom projects.

And even on the host. What is the use-case for this in the context of
Buildroot?

If there's no use-case and you don't need it, better keep it
unconditionally disabled and save some complexity.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot