All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: amd-gfx@lists.freedesktop.org
Cc: Chris Bainbridge <chris.bainbridge@gmail.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 0/3] Handle aborted suspend better
Date: Sun,  1 Jun 2025 20:44:29 -0500	[thread overview]
Message-ID: <20250602014432.3538345-1-superm1@kernel.org> (raw)

From: Mario Limonciello <mario.limonciello@amd.com>

Chris Bainbridge reported some list corruption occurring around the
suspend sequence when an aborted suspend occurs.

I couldn't reproduce this specific problem, but when I tried I found
some other issues where the cached DM state isn't properly destroyed.

This is because there isn't a complete() callback to match the prepare()
callback used by amdgpu. Normally the PM core will call complete() after
every suspend attempt (succesful or not).

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/4280

Mario Limonciello (3):
  drm/amd: Add support for a complete pmops action
  drm/amd/display: Stop storing failures into adev->dm.cached_state
  drm/amd/display: Destroy cached state in complete() callback

 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  22 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |   2 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 125 +++++++++++-------
 drivers/gpu/drm/amd/include/amd_shared.h      |   1 +
 5 files changed, 103 insertions(+), 48 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-06-02  1:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02  1:44 Mario Limonciello [this message]
2025-06-02  1:44 ` [PATCH 1/3] drm/amd: Add support for a complete pmops action Mario Limonciello
2025-06-02  1:44 ` [PATCH 2/3] drm/amd/display: Stop storing failures into adev->dm.cached_state Mario Limonciello
2025-06-02  1:44 ` [PATCH 3/3] drm/amd/display: Destroy cached state in complete() callback Mario Limonciello
2025-06-02 12:22 ` [PATCH 0/3] Handle aborted suspend better Chris Bainbridge
2025-06-10 20:11 ` Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602014432.3538345-1-superm1@kernel.org \
    --to=superm1@kernel.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chris.bainbridge@gmail.com \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.