From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0996BC5B549 for ; Mon, 2 Jun 2025 05:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WrZuUrhRSdJCo7mSITt/V9wdT6s7FT+tTLloxbV6xzQ=; b=jQvGy1/dD27t3UZeG2eiSFstHq PQU2RUQnzbAH5QcHU/iXcO1tp4TWCTiJyqF5HYvOczp4f+Xk83EcAEoOXsJ/h1WBZm4zixEDRBOKm ufQthSNExdZ+H2cbnvWv5bCP+ZMUbbVJ2C0+Tq6ytwcodVoAGlwe7DwmgaRngOGB2jVA=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uLxI5-0007fD-M4; Mon, 02 Jun 2025 05:00:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uLxI4-0007f5-K1 for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Jun 2025 05:00:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lLEiW0T2qHCHUZjRLRubTtc7et929ZxcBizZQho0DTQ=; b=dyqKRUW/XC9NdEpwRf53pdZbFo xi1mH3X9DtSa6O3/43U8g3RqRGpC0b7pwG6+zTpNLFrEWzTJNLUOWkRH2mkTquN7J+7ys13+ujukQ 6wi35PFj2JTq0K1gcvfHjL2XptIvh8r1KztMw+evnstvC84qRejB31eaYXP8Zn+GGPvc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lLEiW0T2qHCHUZjRLRubTtc7et929ZxcBizZQho0DTQ=; b=LR7lBipHjKg9eoJf3Kn/A6OlxZ 0GbGYbbbFmr8Xa1Gf9R7fLSJhYgOMPRdIiDs6lCAj0+pCy9E98RgzwkzXTIWZu2gBA77Q6UTwKGEV qRY4SUsIiVWBV3NN+lTc2bENEpkfYanQqf4lH5JQvWvdKNBcCiEfFw2B7IGfxoGpeySU=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uLxHy-0004tP-6E for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Jun 2025 05:00:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 577DB68CFE; Mon, 2 Jun 2025 07:00:31 +0200 (CEST) Date: Mon, 2 Jun 2025 07:00:30 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Message-ID: <20250602050030.GA21716@lst.de> References: <20250601002709.4094344-1-willy@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250601002709.4094344-1-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1uLxHy-0004tP-6E Subject: Re: [f2fs-dev] [PATCH] f2fs: Fix __write_node_folio() conversion X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sun, Jun 01, 2025 at 01:26:54AM +0100, Matthew Wilcox (Oracle) wrote: > This conversion moved the folio_unlock() to inside __write_node_folio(), > but missed one caller so we had a double-unlock on this path. Looks good, thanks! Reviewed-by: Christoph Hellwig _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783701DFF7 for ; Mon, 2 Jun 2025 05:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748840438; cv=none; b=PFOmzIYHuRHsSGNJQaJ59u6dtrKqs8dInfvmslkIzbBP+xdTxPosS3wJP/NjV741FNjw8KLxgV0AUhAF1OcxpVi1GBSL0n2j+63u17oBC6GUlGbCI6jwuzmMjxPmGHGXRmcLRTN+LOxYlC+CDkhwqiITw9A0wuhA8a0WkvHPl8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748840438; c=relaxed/simple; bh=lLEiW0T2qHCHUZjRLRubTtc7et929ZxcBizZQho0DTQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R0Ke/pzaS5T6L1LAF01fBAUiaH/xluGPXEFkPMDNACPkvIobk2PzlMlnTg42Y8rrEoOwsyVd/inZCtWmuKKjXJCT+aUzeXuxlO7UFnIBBdsdBJEPPfJdg2O/9KE3B3xunlGU3gAfocI6X87GS9WXj7RJpQsVUoYpjWGF1CBr+8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 577DB68CFE; Mon, 2 Jun 2025 07:00:31 +0200 (CEST) Date: Mon, 2 Jun 2025 07:00:30 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Chao Yu , Jaegeuk Kim , syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com Subject: Re: [PATCH] f2fs: Fix __write_node_folio() conversion Message-ID: <20250602050030.GA21716@lst.de> References: <20250601002709.4094344-1-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250601002709.4094344-1-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Sun, Jun 01, 2025 at 01:26:54AM +0100, Matthew Wilcox (Oracle) wrote: > This conversion moved the folio_unlock() to inside __write_node_folio(), > but missed one caller so we had a double-unlock on this path. Looks good, thanks! Reviewed-by: Christoph Hellwig