From: Peter Zijlstra <peterz@infradead.org>
To: David Wang <00107082@163.com>
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
mingo@kernel.org, yeoreum.yun@arm.com, leo.yan@arm.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf/core: restore __perf_remove_from_context when DETACH_EXIT not set
Date: Tue, 3 Jun 2025 14:50:56 +0200 [thread overview]
Message-ID: <20250603125056.GI39944@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <2633d43d.ae30.1973564f5e5.Coremail.00107082@163.com>
On Tue, Jun 03, 2025 at 06:44:58PM +0800, David Wang wrote:
> (As yeoreum.yun@arm.com pointed out, the change in perf_remove_from_context() made
> perf_event_set_state() happened before list_del_event(), resulting in perf_cgroup_event_disable()
> not called.)
Aah, d'0h. Let me see what we should do there.
> My suggestion here is to confine the effect of commit a3c3c66670ce only to call chain
> perf_event_exit_event() --> __perf_remove_from_context()
>
>
> (But this v2 version is totally wrong, should be ignored; it breaks commit a3c3c66670ce)
Right. Because we moved that state update earlier because
perf_child_detach() wants up-to-date timestamps.
next prev parent reply other threads:[~2025-06-03 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 3:26 [PATCH] perf/core: restore __perf_remove_from_context when DETACH_EXIT not set David Wang
2025-06-03 8:33 ` [PATCH v2] " David Wang
2025-06-03 9:13 ` Peter Zijlstra
2025-06-03 10:44 ` David Wang
2025-06-03 12:50 ` Peter Zijlstra [this message]
2025-06-03 12:54 ` Peter Zijlstra
2025-06-03 13:03 ` David Wang
2025-06-03 13:49 ` David Wang
2025-06-03 13:22 ` Yeoreum Yun
2025-06-03 14:08 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603125056.GI39944@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=00107082@163.com \
--cc=acme@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.