From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9CF233707 for ; Tue, 3 Jun 2025 14:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748959492; cv=none; b=NBs4WJMf2wue8bJeL/KDn73ffYirXhB30eIyCgqppu51g2sI12OULtJeC0vmNcNB81uZbQT8CZWMcDnFkVBVm/8I31UeNmxyOi68cRdSynpxV8mMHwTcNKxz/qCHNbE2Bhv6vbOSlKfAti9MC4co93a/ZZ/RLq7fA9aSds5Q4XQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748959492; c=relaxed/simple; bh=5QBnuiPhzjYB0sKEZkcAP5Cku3jQz7UexqyVVVNRdKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WdWuo36ZTsntMQqElhy1EmIq/B/IkfyHSgmAn1u8fAQ/GVXL68hFg4MJKic5QGv/IkGCkWeY7AyLKZgSxOR+ZxafD4Pgf+/j16JdueEKHmaMK9cnjIA7LT9R1zQUIqrXAFBtzPcIGhRYpjGzW6SU5BJGRQxkgrnnl6fWNPn2fqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 727C668D0F; Tue, 3 Jun 2025 16:04:45 +0200 (CEST) Date: Tue, 3 Jun 2025 16:04:45 +0200 From: Christoph Hellwig To: Anuj gupta Cc: Christoph Hellwig , Anuj Gupta/Anuj Gupta , Kundan Kumar , jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, kundanthebest@gmail.com Subject: Re: [PATCH 00/13] Parallelizing filesystem writeback Message-ID: <20250603140445.GA14351@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250602141904.GA21996@lst.de> <20250603132434.GA10865@lst.de> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jun 03, 2025 at 07:22:18PM +0530, Anuj gupta wrote: > > A mount option is about the worst possible interface for behavior > > that depends on file system implementation and possibly hardware > > chacteristics. This needs to be set by the file systems, possibly > > using generic helpers using hardware information. > > Right, that makes sense. Instead of using a mount option, we can > introduce generic helpers to initialize multiple writeback contexts > based on underlying hardware characteristics — e.g., number of CPUs or > NUMA topology. Filesystems like XFS and EXT4 can then call these helpers > during mount to opt into parallel writeback in a controlled way. Yes. A mount option might still be useful to override this default, but it should not be needed for the normal use case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89654C5AE59 for ; Tue, 3 Jun 2025 14:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vQyjWM5erEyUQWo8vWFpz55ugHEBmHDD8/lG4lpTUqM=; b=CS9KskWdeovhHLWGQvvc9yScIc nbLMZuve2HaEz71s71GBC7iqdElS5EQzMz+z0JNlRi3YziKiEH30CsPEz90BEWDo4E6MOqAJQOnFQ gkP79PDqjruZ9El6zKpp6L+TkMoG+mDBs175R1FWRXpj7UmkltnZ5A81nFMOuirItT08=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uMSGF-00062m-56; Tue, 03 Jun 2025 14:05:03 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uMSGD-000625-2V for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Jun 2025 14:05:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KdeN+C81na59VFN4VjFpqchIQBdH9hme8BVMcCk6vsQ=; b=IY6sn5LEMAUI3FRMu+EnAXnmnh WLHv2Gk6VAmTEfEvl1le268Vjx0r0fXoxrmT1cn56nfyOmAIYMNC9ob7vg0dhpv3Fz/Z7e7p8ByBW w+Ni55BKSVyT5QEZgtGzvX1dqDjIIBsUzkF8O0pOFIJ6T6UoOUHzZVtn9xZ8moYmHSRo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KdeN+C81na59VFN4VjFpqchIQBdH9hme8BVMcCk6vsQ=; b=FyMXnHCoTH6XnNm85WDOz3LdO0 cDoz1QVM5b1i/UHcvv/ae6/C1Y0sdmOPvMZ3vyVPhdQU2qeyaegsf/E8KOwUvB3hNnZPZCNkkw5Eu elr1axTOHRazaT+p7JOu62CXWsqYUVZWX7OPK9MLDOnGz/qs5rsDqX8C3vXDLBOd0scA=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uMSGC-0004MS-BR for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Jun 2025 14:05:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 727C668D0F; Tue, 3 Jun 2025 16:04:45 +0200 (CEST) Date: Tue, 3 Jun 2025 16:04:45 +0200 From: Christoph Hellwig To: Anuj gupta Message-ID: <20250603140445.GA14351@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250602141904.GA21996@lst.de> <20250603132434.GA10865@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1uMSGC-0004MS-BR Subject: Re: [f2fs-dev] [PATCH 00/13] Parallelizing filesystem writeback X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ritesh.list@gmail.com, jack@suse.cz, djwong@kernel.org, amir73il@gmail.com, david@fromorbit.com, gfs2@lists.linux.dev, linux-mm@kvack.org, clm@meta.com, Christoph Hellwig , dave@stgolabs.net, agruenba@redhat.com, miklos@szeredi.hu, Kundan Kumar , willy@infradead.org, p.raghav@samsung.com, Anuj Gupta/Anuj Gupta , linux-nfs@vger.kernel.org, da.gomez@samsung.com, viro@zeniv.linux.org.uk, kundanthebest@gmail.com, jaegeuk@kernel.org, axboe@kernel.dk, brauner@kernel.org, linux-f2fs-devel@lists.sourceforge.net, mcgrof@kernel.org, anna@kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, trondmy@kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gVHVlLCBKdW4gMDMsIDIwMjUgYXQgMDc6MjI6MThQTSArMDUzMCwgQW51aiBndXB0YSB3cm90 ZToKPiA+IEEgbW91bnQgb3B0aW9uIGlzIGFib3V0IHRoZSB3b3JzdCBwb3NzaWJsZSBpbnRlcmZh Y2UgZm9yIGJlaGF2aW9yCj4gPiB0aGF0IGRlcGVuZHMgb24gZmlsZSBzeXN0ZW0gaW1wbGVtZW50 YXRpb24gYW5kIHBvc3NpYmx5IGhhcmR3YXJlCj4gPiBjaGFjdGVyaXN0aWNzLiAgVGhpcyBuZWVk cyB0byBiZSBzZXQgYnkgdGhlIGZpbGUgc3lzdGVtcywgcG9zc2libHkKPiA+IHVzaW5nIGdlbmVy aWMgaGVscGVycyB1c2luZyBoYXJkd2FyZSBpbmZvcm1hdGlvbi4KPiAKPiBSaWdodCwgdGhhdCBt YWtlcyBzZW5zZS4gSW5zdGVhZCBvZiB1c2luZyBhIG1vdW50IG9wdGlvbiwgd2UgY2FuCj4gaW50 cm9kdWNlIGdlbmVyaWMgaGVscGVycyB0byBpbml0aWFsaXplIG11bHRpcGxlIHdyaXRlYmFjayBj b250ZXh0cwo+IGJhc2VkIG9uIHVuZGVybHlpbmcgaGFyZHdhcmUgY2hhcmFjdGVyaXN0aWNzIOKA lCBlLmcuLCBudW1iZXIgb2YgQ1BVcyBvcgo+IE5VTUEgdG9wb2xvZ3kuIEZpbGVzeXN0ZW1zIGxp a2UgWEZTIGFuZCBFWFQ0IGNhbiB0aGVuIGNhbGwgdGhlc2UgaGVscGVycwo+IGR1cmluZyBtb3Vu dCB0byBvcHQgaW50byBwYXJhbGxlbCB3cml0ZWJhY2sgaW4gYSBjb250cm9sbGVkIHdheS4KClll cy4gIEEgbW91bnQgb3B0aW9uIG1pZ2h0IHN0aWxsIGJlIHVzZWZ1bCB0byBvdmVycmlkZSB0aGlz IGRlZmF1bHQsCmJ1dCBpdCBzaG91bGQgbm90IGJlIG5lZWRlZCBmb3IgdGhlIG5vcm1hbCB1c2Ug Y2FzZS4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3Vy Y2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8v bGludXgtZjJmcy1kZXZlbAo=