From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CB28C5AD49 for ; Wed, 4 Jun 2025 02:30:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD0D710E60D; Wed, 4 Jun 2025 02:30:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Cb1ohwlp"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4974F10E262; Wed, 4 Jun 2025 02:29:56 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 74D6961127; Wed, 4 Jun 2025 02:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 327BFC4CEED; Wed, 4 Jun 2025 02:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749004191; bh=bPqB4UZU6V2fT7jBdDYxwFtvGjfygIA1UIxiMxSiYi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Cb1ohwlpgzrn2LhpNWN9eSYPo632mfVce3z+QmIb31Ycm7qWykyjpbyuBRd8porrQ DN6aG/r6DntLjj7aAMoCw8yzFKlQ5Y+t5nt8SXZd2gIWdE4whVNA68hyTmeQrU4V+B ZBMVPfrJGmN5LEZcQm13UliqEQEm+7aBIZWm2lbyZ7T61I+Puj37un75lo9qyq4TND bC0rdTS64c9HmoIix8EU+KFY9lm9DdWV1vsq3HEHMScaeRst7JXJDpvhdzBb8m1TU7 r0IsZPBrLEbM2GtVExYC/BNRT2AjA9skoeRlT92Z+JszUNQUPf3VO245g1s1+N6muI v+M/uhmVxT38g== Date: Tue, 3 Jun 2025 19:29:49 -0700 From: Jakub Kicinski To: Jeff Layton Cc: Andrew Morton , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Krzysztof Karas , Kuniyuki Iwashima , Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Subject: Re: [PATCH v13 0/9] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir Message-ID: <20250603192949.3a7fc085@kernel.org> In-Reply-To: <20250603-reftrack-dbgfs-v13-0-7b2a425019d8@kernel.org> References: <20250603-reftrack-dbgfs-v13-0-7b2a425019d8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 03 Jun 2025 07:27:11 -0400 Jeff Layton wrote: > For those just joining in, this series adds a new top-level > "ref_tracker" debugfs directory, and has each ref_tracker_dir register a > file in there as part of its initialization. It also adds the ability to > register a symlink with a more human-usable name that points to the > file, and does some general cleanup of how the ref_tracker object names > are handled. > > This reposting is mostly to address Krzysztof's comments. I've dropped > the i915 patch, and rebased the rest of the series on top. > > Note that I still see debugfs: warnings in the i915 driver even when we > gate the registration of the debugfs file on the classname pointer being > NULL. Here is a CI report from v12: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_148490v8/bat-arls-6/igt@i915_selftest@live@workarounds.html > > I think the i915 driver is doing something it shouldn't with these > objects. They seem to be initialized more than once, which could lead > to leaked ref_tracker objects. It would be good for one of the i915 > maintainers to comment on whether this is a real problem. I still see the fs crashes: https://netdev-3.bots.linux.dev/vmksft-packetdrill-dbg/results/149560/2-tcp-slow-start-slow-start-app-limited-pkt/stderr I'll hide this series from patchwork for now. We will pull from Linus on Thu, I'll reactivate it and let's see if the problem was already fixed.