All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	Klara Modin <klarasmodin@gmail.com>
Subject: Re: [PATCH v3] btrfs_get_tree_subvol(): switch from fc_mount() to vfs_create_mount()
Date: Tue, 3 Jun 2025 21:38:15 +0200	[thread overview]
Message-ID: <20250603193815.GL4037@suse.cz> (raw)
In-Reply-To: <74260737-f153-437f-bf98-1f3944f493d6@gmx.com>

On Tue, Jun 03, 2025 at 06:53:47PM +0930, Qu Wenruo wrote:
> 
> 
> 在 2025/6/3 17:29, David Sterba 写道:
> > On Thu, May 08, 2025 at 06:59:04PM +0930, Qu Wenruo wrote:
> >>
> >>
> >> 在 2025/5/7 05:28, Al Viro 写道:
> >>> [Aaarghh...]
> >>> it's simpler to do btrfs_reconfigure_for_mount() right after vfs_get_tree() -
> >>> no need to mess with ->s_umount.
> >>>       
> >>> [fix for braino(s) folded in - kudos to Klara Modin <klarasmodin@gmail.com>]
> >>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >>
> >> Reviewed-by: Qu Wenruo <wqu@suse.com>
> >> Test-by: Qu Wenruo <wqu@suse.com>
> >>
> >> Although the commit message can be enhanced a little, I can handle it at
> >> merge time, no need to re-send.
> > 
> > If you're going to add the patch to for-next, please fix the subject
> > line and update the changelog. Thanks.
> > 
> 
> I have merged this one to for-next just minutes ago.
> 
> However the version I pushed doesn't only have its commit 
> message/subject modified, but also modified its error handling, to align 
> with our error-first behavior.
> (Which is much easier to read compared to the one in the patch)
> 
> So I have sent the updated version to the mail list just for reference.

Perfect, thanks.

      reply	other threads:[~2025-06-03 19:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05  3:03 [RFC][PATCH] btrfs_get_tree_subvol(): switch from fc_mount() to vfs_create_mount() Al Viro
2025-05-05 17:58 ` David Sterba
2025-05-05 19:21   ` Al Viro
2025-05-06 13:36 ` Klara Modin
2025-05-06 16:43   ` Al Viro
2025-05-06 16:48     ` Klara Modin
2025-05-06 17:25   ` Al Viro
2025-05-06 17:47     ` Klara Modin
2025-05-06 17:51       ` Al Viro
2025-05-06 17:54         ` Klara Modin
2025-05-06 18:16           ` Al Viro
2025-05-06 18:34             ` Klara Modin
2025-05-06 19:05               ` Al Viro
2025-05-06 19:20                 ` Klara Modin
2025-05-06 19:48                   ` Al Viro
2025-05-06 18:58             ` Klara Modin
2025-05-06 19:33               ` Al Viro
2025-05-06 19:44                 ` Klara Modin
2025-05-06 19:34 ` [PATCH v2] " Al Viro
2025-05-06 19:52   ` Klara Modin
2025-05-06 20:00     ` Al Viro
2025-05-06 19:58   ` [PATCH v3] " Al Viro
2025-05-08  9:29     ` Qu Wenruo
2025-06-03  7:59       ` David Sterba
2025-06-03  9:23         ` Qu Wenruo
2025-06-03 19:38           ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250603193815.GL4037@suse.cz \
    --to=dsterba@suse.cz \
    --cc=klarasmodin@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.