From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
Cc: "Dan Carpenter" <dan.carpenter@linaro.org>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges
Date: Tue, 3 Jun 2025 19:29:52 -0300 [thread overview]
Message-ID: <20250603222952.GD407166@ziepe.ca> (raw)
In-Reply-To: <0183ca8d-4347-48d9-a783-361c6543db14@intel.com>
On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote:
>
>
> On 26-05-2025 20:36, Dan Carpenter wrote:
> > Hello Himal Prasad Ghimiray,
> >
> > Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch support for SVM
> > ranges") from May 13, 2025 (linux-next), leads to the following
> > Smatch static checker warning:
> >
> > drivers/gpu/drm/xe/xe_vm.c:2922 prefetch_ranges()
> > warn: passing positive error code 's32min-(-96),(-94)-(-15),(-13)-(-12),(-10)-(-2),1' to 'ERR_PTR'
>
> Hi Dan,
>
> Thanks for pointing this out. I see there's a gap in how hmm_range_fault()
> adheres to its documented behavior. I believe the function should sanitize
> positive return values from walk_page_range() to ensure consistency.
>
> Jason can comment further on same.
Yeah, I don't think it should return positive error code, whatever is
doing that should be fixed. Can you send a patch?
Jason
next prev parent reply other threads:[~2025-06-03 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 15:06 [bug report] drm/xe/svm: Implement prefetch support for SVM ranges Dan Carpenter
2025-05-26 16:45 ` Ghimiray, Himal Prasad
2025-06-03 22:29 ` Jason Gunthorpe [this message]
2025-06-04 14:54 ` Simona Vetter
2025-06-04 14:56 ` Jason Gunthorpe
2025-06-04 17:30 ` Dan Carpenter
2025-06-04 17:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603222952.GD407166@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.