From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5005FC5AD49 for ; Wed, 4 Jun 2025 01:05:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E7D2C41A53; Wed, 4 Jun 2025 01:05:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 69MSB13TZ65G; Wed, 4 Jun 2025 01:05:19 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2AD9D419CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1748999119; bh=Nz94+KoidGnKFdADkLD4pYLS5sMw+KuF4u0gEy9SqAs=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pEpOrOQHJSIjAxgYiTsVfX3ynJXxz6WNBAZJK8/GkG8vb48Psp/oIIRuNm1tLoJeq rqVcT1Rmmf95gxUqd4loxFflH6cyip6GfVDe/ZKOD+83SN1m57U63OCUptK/+7tC5o G4UFB5wv91XYukN5HJSS0qShc5apszqZp5th8RmxiIQv9pgX5PSk4J0uCowK5cd8Np m7hT4HitoLMk4dCMWfmZv8ALKsWHb7xS28S2MUCOHkl7NSeWKrNjfAUb+/5aZQzvHJ w8fBst1c0OCmQ98i/up+T9ZcfX7jpAco6GhmCu49QSr2JZAvr/nqLBAlTRaLnhDzsZ HNd2ZDJR30DIQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 2AD9D419CA; Wed, 4 Jun 2025 01:05:19 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 2809FB07 for ; Wed, 4 Jun 2025 01:05:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0EA2561740 for ; Wed, 4 Jun 2025 01:05:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id RTGSHN670M_d for ; Wed, 4 Jun 2025 01:05:17 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=sashal@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 222656078B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 222656078B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id 222656078B for ; Wed, 4 Jun 2025 01:05:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D03304A75E; Wed, 4 Jun 2025 01:05:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B5DC4CEF1; Wed, 4 Jun 2025 01:05:15 +0000 (UTC) From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Kyungwook Boo , Przemek Kitszel , Simon Horman , Aleksandr Loktionov , Rinitha S , Tony Nguyen , Sasha Levin , intel-wired-lan@lists.osuosl.org Date: Tue, 3 Jun 2025 21:04:00 -0400 Message-Id: <20250604010404.5109-42-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250604010404.5109-1-sashal@kernel.org> References: <20250604010404.5109-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.140 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748999116; bh=1fSbznBp596yMlGi68YCCoqnmQuZIxPeCrcJ/64XA30=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bk25naxIYnz3pgQgECs12MUylZ/T6llBO19ulNsoDF/VNSPT2VJfsFzhVbgcv31jh GRPPUw01Dx+0NZUemV8hYRUd5iWUQ/UPhguswUwoN6NZEiAX6krsvXUa4UOLkHUuMx LRi0Hd4ctM2HR3LNgWI+UoEPxMCnA+Wdeb1Y93NVLHp9k8aOp20BvEAzo3xpL+9QSf 78lgfakpDgetvN7P+P8F9EKqnPx/ItqF8tx0gXTbB6MdvoiNH6q2tC/xt9KjQYi3Gz ORNi6QsOv3ENvLpcIj4I8nYntl5KmX5KVMUbvuplxLS+pZuMmJzVDT5z/NNkP6WDrD nUejQtoU5CDTg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Bk25naxI Subject: [Intel-wired-lan] [PATCH AUTOSEL 6.1 42/46] i40e: fix MMIO write access to an invalid page in i40e_clear_hw X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: Kyungwook Boo [ Upstream commit 015bac5daca978448f2671478c553ce1f300c21e ] When the device sends a specific input, an integer underflow can occur, leading to MMIO write access to an invalid page. Prevent the integer underflow by changing the type of related variables. Signed-off-by: Kyungwook Boo Link: https://lore.kernel.org/lkml/ffc91764-1142-4ba2-91b6-8c773f6f7095@gmail.com/T/ Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman Reviewed-by: Aleksandr Loktionov Tested-by: Rinitha S (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees. Here's my extensive analysis: ## Analysis of Code Changes The commit changes variable types in `i40e_clear_hw()` from unsigned (`u32`) to signed (`s32`) for: 1. `num_pf_int` - number of PF interrupts 2. `num_vf_int` - number of VF interrupts 3. `i` - loop counter variable **Critical Security Issue**: The problem occurs when hardware registers contain malicious values where `num_pf_int` or `num_vf_int` could be 0 or 1. In the loops at lines 852-853 and 858-859: ```c for (i = 0; i < num_pf_int - 2; i++) wr32(hw, I40E_PFINT_DYN_CTLN(i), val); ``` If `num_pf_int` is 0 or 1, then `num_pf_int - 2` becomes a large positive number due to unsigned integer underflow (0xFFFFFFFE or 0xFFFFFFFF), causing the loop to iterate billions of times and write to invalid MMIO addresses, leading to system crashes or potential security vulnerabilities. ## Comparison with Similar Commits This fix follows the **exact same pattern** as Similar Commit #2 (fc6f716a5069), which was marked **YES** for backporting. That commit addressed the same class of vulnerability in the same function: - **Similar Commit #2**: Added bounds checking (`j >= base_queue`, `j >= i`) to prevent underflow in queue/VF calculations - **Current Commit**: Changes variable types to signed to prevent underflow in interrupt calculations Both fixes address **integer underflow vulnerabilities in `i40e_clear_hw()`** that can lead to **MMIO writes to invalid memory pages**. ## Backport Suitability Criteria ✅ **Fixes important security bug**: Prevents system crashes and potential memory corruption ✅ **Small, contained change**: Only changes variable types, no logic changes ✅ **Minimal side effects**: Type changes are safe and don't affect functionality ✅ **No architectural changes**: Simple type fix ✅ **Critical subsystem**: Network driver, but change is isolated ✅ **Clear commit message**: Explicitly describes the security issue ✅ **Follows stable rules**: Important security bugfix with minimal risk ## Historical Context The vulnerability was introduced in commit 838d41d92a90 ("i40e: clear all queues and interrupts") from 2014. A related fix (fc6f716a5069) was already applied for similar underflow issues in the same function and was backported. This commit completes the fix by addressing the remaining underflow vectors. ## Risk Assessment **Risk: MINIMAL** - This is a simple type change that: - Makes signed arithmetic behave correctly - Prevents undefined behavior from unsigned underflow - Has no functional impact on normal operation - Only affects error conditions with malformed hardware registers The fix is **essential for security** and has **virtually zero regression risk**, making it an ideal candidate for stable backporting. drivers/net/ethernet/intel/i40e/i40e_common.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index 6266756b47b9d..a707974e42794 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_common.c +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c @@ -1063,10 +1063,11 @@ int i40e_pf_reset(struct i40e_hw *hw) void i40e_clear_hw(struct i40e_hw *hw) { u32 num_queues, base_queue; - u32 num_pf_int; - u32 num_vf_int; + s32 num_pf_int; + s32 num_vf_int; u32 num_vfs; - u32 i, j; + s32 i; + u32 j; u32 val; u32 eol = 0x7ff; -- 2.39.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34BC819CC2E; Wed, 4 Jun 2025 01:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748999117; cv=none; b=ujC+n9mFhEFRmwcWPsW5qrP8JDRv8dBkdT4Qr6rPUNXz07g330+TTNlmuKyYcPUk4oOWUz4myJTsU4M8D8PS8cD3RsmxFgvB7jtbu31bAmhhuZl0jNpaRM3vR4szyR/Q3EOelUYvzf1JrnKzaP8KyChfn8KzCf1ywRxyWc7djdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748999117; c=relaxed/simple; bh=1fSbznBp596yMlGi68YCCoqnmQuZIxPeCrcJ/64XA30=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=VOsmygPTCgKLu/WNIt8j9f688MG6weMg1yE5RNEcJAZc71IbMTXaNrMIncHpCyqzogYVuP+7phhcQODzKDuWra0qnlDTMbu+xCbr+XL10UEj04YWB6bbUKoF3NXjEz5UutQ3nxNLF+k2K1O0R5Z19EvfVR0IKTxHMx80ctDByTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bk25naxI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bk25naxI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B5DC4CEF1; Wed, 4 Jun 2025 01:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748999116; bh=1fSbznBp596yMlGi68YCCoqnmQuZIxPeCrcJ/64XA30=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bk25naxIYnz3pgQgECs12MUylZ/T6llBO19ulNsoDF/VNSPT2VJfsFzhVbgcv31jh GRPPUw01Dx+0NZUemV8hYRUd5iWUQ/UPhguswUwoN6NZEiAX6krsvXUa4UOLkHUuMx LRi0Hd4ctM2HR3LNgWI+UoEPxMCnA+Wdeb1Y93NVLHp9k8aOp20BvEAzo3xpL+9QSf 78lgfakpDgetvN7P+P8F9EKqnPx/ItqF8tx0gXTbB6MdvoiNH6q2tC/xt9KjQYi3Gz ORNi6QsOv3ENvLpcIj4I8nYntl5KmX5KVMUbvuplxLS+pZuMmJzVDT5z/NNkP6WDrD nUejQtoU5CDTg== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Kyungwook Boo , Przemek Kitszel , Simon Horman , Aleksandr Loktionov , Rinitha S , Tony Nguyen , Sasha Levin , intel-wired-lan@lists.osuosl.org Subject: [PATCH AUTOSEL 6.1 42/46] i40e: fix MMIO write access to an invalid page in i40e_clear_hw Date: Tue, 3 Jun 2025 21:04:00 -0400 Message-Id: <20250604010404.5109-42-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250604010404.5109-1-sashal@kernel.org> References: <20250604010404.5109-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.140 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Kyungwook Boo [ Upstream commit 015bac5daca978448f2671478c553ce1f300c21e ] When the device sends a specific input, an integer underflow can occur, leading to MMIO write access to an invalid page. Prevent the integer underflow by changing the type of related variables. Signed-off-by: Kyungwook Boo Link: https://lore.kernel.org/lkml/ffc91764-1142-4ba2-91b6-8c773f6f7095@gmail.com/T/ Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman Reviewed-by: Aleksandr Loktionov Tested-by: Rinitha S (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees. Here's my extensive analysis: ## Analysis of Code Changes The commit changes variable types in `i40e_clear_hw()` from unsigned (`u32`) to signed (`s32`) for: 1. `num_pf_int` - number of PF interrupts 2. `num_vf_int` - number of VF interrupts 3. `i` - loop counter variable **Critical Security Issue**: The problem occurs when hardware registers contain malicious values where `num_pf_int` or `num_vf_int` could be 0 or 1. In the loops at lines 852-853 and 858-859: ```c for (i = 0; i < num_pf_int - 2; i++) wr32(hw, I40E_PFINT_DYN_CTLN(i), val); ``` If `num_pf_int` is 0 or 1, then `num_pf_int - 2` becomes a large positive number due to unsigned integer underflow (0xFFFFFFFE or 0xFFFFFFFF), causing the loop to iterate billions of times and write to invalid MMIO addresses, leading to system crashes or potential security vulnerabilities. ## Comparison with Similar Commits This fix follows the **exact same pattern** as Similar Commit #2 (fc6f716a5069), which was marked **YES** for backporting. That commit addressed the same class of vulnerability in the same function: - **Similar Commit #2**: Added bounds checking (`j >= base_queue`, `j >= i`) to prevent underflow in queue/VF calculations - **Current Commit**: Changes variable types to signed to prevent underflow in interrupt calculations Both fixes address **integer underflow vulnerabilities in `i40e_clear_hw()`** that can lead to **MMIO writes to invalid memory pages**. ## Backport Suitability Criteria ✅ **Fixes important security bug**: Prevents system crashes and potential memory corruption ✅ **Small, contained change**: Only changes variable types, no logic changes ✅ **Minimal side effects**: Type changes are safe and don't affect functionality ✅ **No architectural changes**: Simple type fix ✅ **Critical subsystem**: Network driver, but change is isolated ✅ **Clear commit message**: Explicitly describes the security issue ✅ **Follows stable rules**: Important security bugfix with minimal risk ## Historical Context The vulnerability was introduced in commit 838d41d92a90 ("i40e: clear all queues and interrupts") from 2014. A related fix (fc6f716a5069) was already applied for similar underflow issues in the same function and was backported. This commit completes the fix by addressing the remaining underflow vectors. ## Risk Assessment **Risk: MINIMAL** - This is a simple type change that: - Makes signed arithmetic behave correctly - Prevents undefined behavior from unsigned underflow - Has no functional impact on normal operation - Only affects error conditions with malformed hardware registers The fix is **essential for security** and has **virtually zero regression risk**, making it an ideal candidate for stable backporting. drivers/net/ethernet/intel/i40e/i40e_common.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index 6266756b47b9d..a707974e42794 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_common.c +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c @@ -1063,10 +1063,11 @@ int i40e_pf_reset(struct i40e_hw *hw) void i40e_clear_hw(struct i40e_hw *hw) { u32 num_queues, base_queue; - u32 num_pf_int; - u32 num_vf_int; + s32 num_pf_int; + s32 num_vf_int; u32 num_vfs; - u32 i, j; + s32 i; + u32 j; u32 val; u32 eol = 0x7ff; -- 2.39.5