Re: [LTP] [PATCH 1/2] configure: Fix build on kernel 6.14 headers

[Petr Vorel <pvorel@suse.cz>]

Hi all,

> On Tue, Jun 3, 2025 at 6:12 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi all,

> > > Hi!
> > > Let's push this now, it's simple enough and fixes the CI.

> > I'm sorry, it did not fix the problem due the old problem of indirect include
> > <linux/mount.h> by <linux/fs.h> on Alpine v3.22 (the default Alpine version in
> > GitHub action), which uses 6.14.2 kernel headers:

> >     In file included from /usr/include/linux/fs.h:19,
> >                      from /usr/include/linux/btrfs.h:29,
> >                      from statmount02.c:23:

> from statmount02.c:

> The btrfs validation is currently skipped due to the lack of support for VFS
> ...
> #include <linux/btrfs.h>

> Does the test actually need linux/btrfs.h ?

Jan, very good point, it really was not needed. Removal merged as fe8c0dac5a,
thank you!

> > I suppose we should have 2 or 3 lapi files:

> > 1) lapi/mount.h
> > mount definitions (guarded by #ifndef) - the old ones from <sys/mount.h> e.g.
> > MS_REC, MS_PRIVATE and probably the new ones from <linux/mount.h>, e.g.
> > MNT_ID_REQ_SIZE_VER0. None of <sys/mount.h> <linux/mount.h> should be included
> > in it.

> > 2) lapi/linux_mount.h
> > mount structs (nowadays vast majority if not all from <linux/mount.h> only).
> > This header can include <linux/mount.h> and lapi/mount.h.
> > That allows to have configure.ac to safely use <linux/mount.h> for detection.

> > 3) lapi/sys_mount.h
> > Optional helper header which would include lapi/mount.h and <sys/mount.h>
> > (to keep the current approach that lapi headers include system headers so that
> > tests does not need to do it.

I'll be pragmatic and although the above would be an improvement, I'll postpone
doing it until it's really needed.

Kind regards,
Petr

> > WDYT?

> > Kind regards,
> > Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp