From: Jason Gunthorpe <jgg@ziepe.ca>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs
Date: Wed, 4 Jun 2025 12:14:32 -0300 [thread overview]
Message-ID: <20250604151432.GC17991@ziepe.ca> (raw)
In-Reply-To: <20250604140544.688711-1-david@redhat.com>
On Wed, Jun 04, 2025 at 04:05:44PM +0200, David Hildenbrand wrote:
> Especially once we hit one of the assertions in
> sanity_check_pinned_pages(), observing follow-up assertions failing
> in other code can give good clues about what went wrong, so use
> VM_WARN_ON_ONCE instead.
>
> While at it, let's just convert all VM_BUG_ON to VM_WARN_ON_ONCE as
> well. Add one comment for the pfn_valid() check.
>
> We have to introduce VM_WARN_ON_ONCE_VMA() to make that fly.
I'm fine with this, but IMHO, using ON_ONCE is wasteful here.
They have been BUG_ONs for ages, they really do never happen. If there
was ever a case to justify not using ON_ONCE this is it..
Jason
next prev parent reply other threads:[~2025-06-04 15:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 14:05 [PATCH v1] mm/gup: remove (VM_)BUG_ONs David Hildenbrand
2025-06-04 14:22 ` Vlastimil Babka
2025-06-04 14:26 ` Suren Baghdasaryan
2025-06-04 14:48 ` Lorenzo Stoakes
2025-06-04 14:58 ` David Hildenbrand
2025-06-04 15:44 ` Lorenzo Stoakes
2025-06-04 15:42 ` Linus Torvalds
2025-06-04 16:05 ` Lorenzo Stoakes
2025-06-04 15:14 ` Jason Gunthorpe [this message]
2025-06-04 16:01 ` David Hildenbrand
2025-06-04 17:25 ` SeongJae Park
2025-06-04 19:12 ` Liam R. Howlett
2025-06-04 19:16 ` David Hildenbrand
2025-06-05 1:07 ` John Hubbard
2025-06-05 5:37 ` Vlastimil Babka
2025-06-05 6:08 ` David Hildenbrand
2025-06-05 8:48 ` Vlastimil Babka
2025-06-05 12:29 ` David Hildenbrand
2025-06-05 7:10 ` Michal Hocko
2025-06-06 8:10 ` David Hildenbrand
2025-06-06 8:31 ` Michal Hocko
2025-06-06 9:01 ` David Hildenbrand
2025-06-06 10:13 ` Michal Hocko
2025-06-06 10:19 ` Lorenzo Stoakes
2025-06-06 10:28 ` David Hildenbrand
2025-06-06 11:04 ` Lorenzo Stoakes
2025-06-06 11:44 ` David Hildenbrand
2025-06-06 11:56 ` Michal Hocko
2025-06-06 12:12 ` Lorenzo Stoakes
2025-06-06 12:17 ` David Hildenbrand
2025-06-06 17:57 ` John Hubbard
2025-06-06 18:06 ` Lorenzo Stoakes
2025-06-06 18:15 ` David Hildenbrand
2025-06-06 18:21 ` John Hubbard
2025-06-06 18:23 ` David Hildenbrand
2025-06-06 18:31 ` John Hubbard
2025-06-06 18:36 ` David Hildenbrand
2025-06-06 18:39 ` John Hubbard
2025-06-06 18:34 ` Lorenzo Stoakes
2025-06-06 18:42 ` Jason Gunthorpe
2025-06-06 18:46 ` Lorenzo Stoakes
2025-06-06 19:03 ` Lorenzo Stoakes
2025-06-07 13:42 ` Jason Gunthorpe
2025-06-07 13:53 ` Lorenzo Stoakes
2025-06-07 18:00 ` John Hubbard
2025-06-09 9:57 ` Vlastimil Babka
2025-07-24 10:54 ` Vlastimil Babka
2025-07-24 10:56 ` Lorenzo Stoakes
2025-07-24 17:27 ` John Hubbard
2025-06-11 9:32 ` David Hildenbrand
2025-06-11 12:03 ` Jason Gunthorpe
2025-06-11 12:06 ` Lorenzo Stoakes
2025-06-06 10:28 ` Michal Hocko
2025-06-06 10:27 ` David Hildenbrand
2025-06-06 8:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604151432.GC17991@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.