From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
" Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH v2 3/3] docs: CSS: make cross-reference links more evident
Date: Wed, 4 Jun 2025 16:59:02 +0200 [thread overview]
Message-ID: <20250604165902.08265fe7@sal.lan> (raw)
In-Reply-To: <20250604143645.78367-4-corbet@lwn.net>
Em Wed, 4 Jun 2025 08:36:45 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:
> The Sphinx Alabaster theme uses border-bottom to mark reference links; the
> result does not render correctly (the underline is missing) in some browser
> configurations. Switch to using the standard text-underline property, and
> use text-underline-offset to place that underline below any underscores in
> the underlined text.
>
> Suggested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
While I didn't test, it looks good enough for me.
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> Documentation/sphinx-static/custom.css | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/sphinx-static/custom.css b/Documentation/sphinx-static/custom.css
> index f4285417c71a..c9991566f914 100644
> --- a/Documentation/sphinx-static/custom.css
> +++ b/Documentation/sphinx-static/custom.css
> @@ -136,3 +136,10 @@ div.language-selection:hover ul {
> div.language-selection ul li:hover {
> background: #dddddd;
> }
> +
> +/* Make xrefs more universally visible */
> +a.reference, a.reference:hover {
> + border-bottom: none;
> + text-decoration: underline;
> + text-underline-offset: 0.3em;
> +}
next prev parent reply other threads:[~2025-06-04 14:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 14:36 [PATCH v2 0/3] docs: some automarkup improvements Jonathan Corbet
2025-06-04 14:36 ` [PATCH v2 1/3] docs: automarkup: Remove some Sphinx 2 holdovers Jonathan Corbet
2025-06-04 14:56 ` Mauro Carvalho Chehab
2025-06-04 14:36 ` [PATCH v2 2/3] docs: automarkup: Mark up undocumented entities too Jonathan Corbet
2025-06-04 14:57 ` Mauro Carvalho Chehab
2025-06-04 14:36 ` [PATCH v2 3/3] docs: CSS: make cross-reference links more evident Jonathan Corbet
2025-06-04 14:59 ` Mauro Carvalho Chehab [this message]
2025-06-04 22:05 ` [PATCH v2 0/3] docs: some automarkup improvements Nícolas F. R. A. Prado
2025-06-05 3:00 ` Bagas Sanjaya
2025-06-05 16:32 ` Jonathan Corbet
2025-06-06 15:57 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604165902.08265fe7@sal.lan \
--to=mchehab+huawei@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.