All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Timur Tabi <ttabi@nvidia.com>
Cc: "miguel.ojeda.sandonis@gmail.com"
	<miguel.ojeda.sandonis@gmail.com>,
	"ojeda@kernel.org" <ojeda@kernel.org>,
	"dakr@kernel.org" <dakr@kernel.org>,
	"aliceryhl@google.com" <aliceryhl@google.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] rust: introduce sfile macro for easier code tracing
Date: Thu, 5 Jun 2025 08:07:40 +0200	[thread overview]
Message-ID: <2025060508-spool-twistable-66af@gregkh> (raw)
In-Reply-To: <874ffd400b0632cff99b618661adffe472abbf8d.camel@nvidia.com>

On Wed, Jun 04, 2025 at 08:38:12PM +0000, Timur Tabi wrote:
> On Wed, 2025-06-04 at 12:28 +0200, Miguel Ojeda wrote:
> > 
> > > I could add a sdbg!() if you think it would be useful.
> > 
> > Yeah, that was what I was thinking, though it is sadly one more letter.
> 
> Maybe dbs!(), or just d!() ?

Wait, why are we trying to reimplement the existing pr_dbg() code in a
non-standard-way?

Please just do exactly what that provides, we don't want different
logging functions in rust code from the c code, that way lies madness
and very grumpy maintainers who have to read code on both sides.

Let's just do EXACTLY what the C code does, both in functionality AND in
output to the kernel log please.

thanks,

greg k-h

  reply	other threads:[~2025-06-05  6:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 18:45 [PATCH] rust: introduce sfile macro for easier code tracing Timur Tabi
2025-05-29 20:14 ` Benno Lossin
2025-06-03 17:15   ` Timur Tabi
2025-06-03 21:54     ` Benno Lossin
2025-05-29 20:21 ` Miguel Ojeda
2025-06-03 18:15   ` Timur Tabi
2025-06-03 21:58     ` Benno Lossin
2025-06-03 22:05       ` Timur Tabi
2025-06-03 22:15         ` Miguel Ojeda
2025-06-04 23:12           ` Timur Tabi
2025-06-05  3:20             ` Miguel Ojeda
2025-06-03 22:15     ` Miguel Ojeda
2025-06-03 23:29       ` Timur Tabi
2025-06-04 10:28         ` Miguel Ojeda
2025-06-04 15:16           ` Benno Lossin
2025-06-04 15:41             ` Miguel Ojeda
2025-06-05  6:05             ` Greg KH
2025-06-04 20:38           ` Timur Tabi
2025-06-05  6:07             ` Greg KH [this message]
2025-06-05 15:02               ` Timur Tabi
2025-06-05 15:21                 ` gregkh
2025-06-05 15:38                   ` Miguel Ojeda
2025-06-05 16:42                     ` gregkh
2025-06-05 17:39                       ` Miguel Ojeda
2025-06-06 15:50                 ` Miguel Ojeda
2025-05-30  3:47 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025060508-spool-twistable-66af@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=aliceryhl@google.com \
    --cc=dakr@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.