From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>
Cc: stable@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>
Subject: [PATCH v3 1/5] drm/dp: Change AUX DPCD probe address from DPCD_REV to LANE0_1_STATUS
Date: Thu, 5 Jun 2025 11:28:46 +0300 [thread overview]
Message-ID: <20250605082850.65136-2-imre.deak@intel.com> (raw)
In-Reply-To: <20250605082850.65136-1-imre.deak@intel.com>
Reading DPCD registers has side-effects in general. In particular
accessing registers outside of the link training register range
(0x102-0x106, 0x202-0x207, 0x200c-0x200f, 0x2216) is explicitly
forbidden by the DP v2.1 Standard, see
3.6.5.1 DPTX AUX Transaction Handling Mandates
3.6.7.4 128b/132b DP Link Layer LTTPR Link Training Mandates
Based on my tests, accessing the DPCD_REV register during the link
training of an UHBR TBT DP tunnel sink leads to link training failures.
Solve the above by using the DP_LANE0_1_STATUS (0x202) register for the
DPCD register access quirk.
Cc: <stable@vger.kernel.org>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/display/drm_dp_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index f2a6559a27100..dc622c78db9d4 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -725,7 +725,7 @@ ssize_t drm_dp_dpcd_read(struct drm_dp_aux *aux, unsigned int offset,
* monitor doesn't power down exactly after the throw away read.
*/
if (!aux->is_remote) {
- ret = drm_dp_dpcd_probe(aux, DP_DPCD_REV);
+ ret = drm_dp_dpcd_probe(aux, DP_LANE0_1_STATUS);
if (ret < 0)
return ret;
}
--
2.44.2
next prev parent reply other threads:[~2025-06-05 8:29 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 8:28 [PATCH v3 0/5] drm/dp: Limit the DPCD probe quirk to the affected monitor Imre Deak
2025-06-05 8:28 ` Imre Deak [this message]
2025-06-05 8:28 ` [PATCH v3 2/5] drm/edid: Define the quirks in an enum list Imre Deak
2025-06-05 13:05 ` Jani Nikula
2025-06-05 13:06 ` Jani Nikula
2025-06-05 8:28 ` [PATCH v3 3/5] drm/edid: Add support for quirks visible to DRM core and drivers Imre Deak
2025-06-05 13:07 ` Jani Nikula
2025-06-05 13:23 ` Imre Deak
2025-06-05 8:28 ` [PATCH v3 4/5] drm/dp: Add an EDID quirk for the DPCD register access probe Imre Deak
2025-06-05 13:11 ` Jani Nikula
2025-06-05 13:33 ` Imre Deak
2025-06-09 12:55 ` [PATCH v4 " Imre Deak
2025-06-05 8:28 ` [PATCH v3 5/5] drm/i915/dp: Disable the AUX DPCD probe quirk if it's not required Imre Deak
2025-06-05 13:13 ` Jani Nikula
2025-06-06 13:44 ` Jani Nikula
2025-06-06 13:50 ` Imre Deak
2025-06-06 13:55 ` Imre Deak
2025-06-06 14:04 ` Jani Nikula
2025-06-06 14:34 ` Imre Deak
2025-06-09 12:55 ` [PATCH v4 " Imre Deak
2025-06-10 13:39 ` Kahola, Mika
2025-06-11 13:06 ` Jani Nikula
2025-06-05 9:05 ` ✗ Fi.CI.CHECKPATCH: warning for drm/dp: Limit the DPCD probe quirk to the affected monitor (rev4) Patchwork
2025-06-05 9:06 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-06-05 9:28 ` ✓ i915.CI.BAT: success " Patchwork
2025-06-05 10:36 ` ✓ CI.Patch_applied: " Patchwork
2025-06-05 10:36 ` ✗ CI.checkpatch: warning " Patchwork
2025-06-05 10:38 ` ✓ CI.KUnit: success " Patchwork
2025-06-05 10:48 ` ✓ CI.Build: " Patchwork
2025-06-05 10:51 ` ✓ CI.Hooks: " Patchwork
2025-06-05 10:52 ` ✗ CI.checksparse: warning " Patchwork
2025-06-05 11:07 ` ✗ i915.CI.Full: failure " Patchwork
2025-06-05 11:43 ` ✓ Xe.CI.BAT: success " Patchwork
2025-06-06 20:13 ` ✗ Xe.CI.Full: failure " Patchwork
2025-06-09 13:47 ` ✗ Fi.CI.CHECKPATCH: warning for drm/dp: Limit the DPCD probe quirk to the affected monitor (rev6) Patchwork
2025-06-09 13:47 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-06-09 14:09 ` ✓ i915.CI.BAT: success " Patchwork
2025-06-09 17:12 ` ✓ CI.Patch_applied: " Patchwork
2025-06-09 17:12 ` ✗ CI.checkpatch: warning " Patchwork
2025-06-09 17:13 ` ✓ CI.KUnit: success " Patchwork
2025-06-09 17:24 ` ✓ CI.Build: " Patchwork
2025-06-09 17:27 ` ✓ CI.Hooks: " Patchwork
2025-06-09 17:28 ` ✗ CI.checksparse: warning " Patchwork
2025-06-09 18:05 ` ✓ Xe.CI.BAT: success " Patchwork
2025-06-09 18:17 ` ✗ i915.CI.Full: failure " Patchwork
2025-06-09 19:44 ` ✗ Xe.CI.Full: " Patchwork
2025-06-10 15:42 ` [PATCH v3 0/5] drm/dp: Limit the DPCD probe quirk to the affected monitor Imre Deak
2025-06-12 13:29 ` Imre Deak
2025-06-12 13:54 ` Thomas Zimmermann
2025-06-12 17:56 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605082850.65136-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.