From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Donald Hunter <donald.hunter@gmail.com>,
Rob Herring <robh@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v12 05/13] net: ethtool: Add support for new power domains index description
Date: Thu, 5 Jun 2025 18:32:20 -0700 [thread overview]
Message-ID: <20250605183220.1cf1b00b@kernel.org> (raw)
In-Reply-To: <20250524-feature_poe_port_prio-v12-5-d65fd61df7a7@bootlin.com>
On Sat, 24 May 2025 12:56:07 +0200 Kory Maincent wrote:
> + if (st->pw_d_id > 0)
nit: here..
> + len += nla_total_size(sizeof(u32)); /* _PSE_PW_D_ID */
> if (st->podl_admin_state > 0)
> len += nla_total_size(sizeof(u32)); /* _PODL_PSE_ADMIN_STATE */
> if (st->podl_pw_status > 0)
> @@ -148,6 +150,11 @@ static int pse_fill_reply(struct sk_buff *skb,
> const struct pse_reply_data *data = PSE_REPDATA(reply_base);
> const struct ethtool_pse_control_status *st = &data->status;
>
> + if (st->pw_d_id > 0 &&
and here -- it's unsigned so just if (st->pw_d_id &&
no need to add > 0
next prev parent reply other threads:[~2025-06-06 1:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 10:56 [PATCH net-next v12 00/13] Add support for PSE budget evaluation strategy Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 01/13] net: pse-pd: Introduce attached_phydev to pse control Kory Maincent
2025-05-24 11:01 ` Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 02/13] net: pse-pd: Add support for reporting events Kory Maincent
2025-05-24 11:02 ` Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 03/13] net: pse-pd: tps23881: Add support for PSE events and interrupts Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 04/13] net: pse-pd: Add support for PSE power domains Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 05/13] net: ethtool: Add support for new power domains index description Kory Maincent
2025-06-06 1:32 ` Jakub Kicinski [this message]
2025-05-24 10:56 ` [PATCH net-next v12 06/13] net: pse-pd: Add helper to report hardware enable status of the PI Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 07/13] net: pse-pd: Add support for budget evaluation strategies Kory Maincent
2025-05-24 11:03 ` Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 08/13] net: ethtool: Add PSE port priority support feature Kory Maincent
2025-06-06 1:34 ` Jakub Kicinski
2025-05-24 10:56 ` [PATCH net-next v12 09/13] net: pse-pd: pd692x0: Add support for PSE PI priority feature Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 10/13] net: pse-pd: pd692x0: Add support for controller and manager power supplies Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 11/13] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 12/13] net: pse-pd: tps23881: Add support for static port priority feature Kory Maincent
2025-05-24 10:56 ` [PATCH net-next v12 13/13] dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description Kory Maincent
2025-05-26 9:49 ` [PATCH net-next v12 00/13] Add support for PSE budget evaluation strategy Oleksij Rempel
2025-05-28 7:31 ` Paolo Abeni
2025-05-28 13:17 ` Kory Maincent
2025-06-06 1:35 ` Jakub Kicinski
2025-06-08 6:17 ` Gal Pressman
2025-06-09 8:36 ` Kory Maincent
2025-06-09 11:03 ` Gal Pressman
2025-06-09 14:03 ` Kory Maincent
2025-06-09 14:41 ` Gal Pressman
2025-06-09 15:12 ` Andrew Lunn
2025-06-11 6:05 ` Gal Pressman
2025-06-11 13:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605183220.1cf1b00b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.