From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCBABC5B552 for ; Fri, 6 Jun 2025 01:43:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7158283DB3; Fri, 6 Jun 2025 01:43:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aa6PyKCkIX_R; Fri, 6 Jun 2025 01:43:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F343783E25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1749174224; bh=oE0emLIVHGE4UZ6APnSBgjHY/ntihXqOoYqp9iNxr2k=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nvD8cDCJxK7sMCGzAIJov/VgF4Cq/NKtFvVhRp34fccCCaIgOAYa1bJuYZbOhb4mC BW8UGYvWG7+L9Kg7ugGOghF8lIgL3/BjpU+8UMh9B6mTsr3bZLT+MIaLQsS+KiKNCF LMS8SGUYGNEfIkg80PKpQzurtTaI7AZIlRx5pV9wFnHUBJJAkMjdUWI3PnjCx/8n3o 5fUkH4ulWS9Rd0piy8FwbiT22kLH3wEZ/KdpbsMjOeJvdzTu4iGl+Af5Pu7RATBfHw Ycc4ir0kj27I+YFOqN/s6/9gS028yo0nzgaUIbj7qyADDMPv6yI8HAXGWtfRMA5vFv lGaYgd40wskzw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id F343783E25; Fri, 6 Jun 2025 01:43:43 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 2621BC8 for ; Fri, 6 Jun 2025 01:43:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1810940343 for ; Fri, 6 Jun 2025 01:43:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id GNSvD4T01UTX for ; Fri, 6 Jun 2025 01:43:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 92C3740068 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 92C3740068 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 92C3740068 for ; Fri, 6 Jun 2025 01:43:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 669595C5419; Fri, 6 Jun 2025 01:41:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25719C4CEE7; Fri, 6 Jun 2025 01:43:40 +0000 (UTC) Date: Thu, 5 Jun 2025 18:43:39 -0700 From: Jakub Kicinski To: Ian Ray Cc: horms@kernel.org, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , brian.ruley@gehealthcare.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20250605184339.7a4e0f96@kernel.org> In-Reply-To: <20250603080949.1681-1-ian.ray@gehealthcare.com> References: <20250603080949.1681-1-ian.ray@gehealthcare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749174220; bh=WHD4PuJMG/otH7gj9OW8gaFkbv8GJd+ZMOtkEz6VlI0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KDiBNQFwPOJSHFPrrahSQhMOzBG9hBiS/dxK00kJTNqTOE3QOaOhTkOY9DfSBh6bX ZCgWdmJM1YbRTIOlNFme98LasmYt/0R811/ItDw1NgUZB68+boR2uhQ6IoHqbukGzH UVwmM0lNPIPhNcbSDRMXkQL/OAGg8NK88yWk7z3UAArRUhLYtvL9VTs7eLDihalUlv kY3Gtd7+0Kbqnnk2O3sYzbsQWEbKVSn1OD/M9KQYUH/zp7UVKIl+8hBpnPv0Evcxbr kxsL7dMK+XVSabsh1I6QnVHfrXdeEtQFCOuYwSmpHfJDE0AatbjLmiZekYjJkztQAJ 5UoDPBEOgJbUQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KDiBNQFw Subject: Re: [Intel-wired-lan] [PATCH v2] igb: Fix watchdog_task race with shutdown X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 3 Jun 2025 11:09:49 +0300 Ian Ray wrote: > set_bit(__IGB_DOWN, &adapter->state); > + timer_delete_sync(&adapter->watchdog_timer); > + timer_delete_sync(&adapter->phy_info_timer); > + > + cancel_work_sync(&adapter->watchdog_task); This doesn't look very race-proof as watchdog_task can schedule the timer as its last operation? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 532CC2BD1B; Fri, 6 Jun 2025 01:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749174221; cv=none; b=dKL0HU8nA5u8Ay4ZEUwIG00jcqxHY98F8IJO3SDDyXLJs1IcgOxZgwRvP2cxOOttG6wbyjLm6kD/CuotY/3WUQkY1OQwdS3TX3RozDCK+JrpJ3CMdlcLuS3QxhwrmavoYVXRBvyF+6RqpyIs1EkOm3mSh3E5gJM+CkY/OjEDhhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749174221; c=relaxed/simple; bh=WHD4PuJMG/otH7gj9OW8gaFkbv8GJd+ZMOtkEz6VlI0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oPxulKgK7FXfACyUs4/SV75M4vwsw+mZpXbnyL854hKKrM8Ix0OV7frHmICXmeTWnZMADQWAf/rirybF5OCpXOtpVpNFqwclAx/hcs3MskzmHmkDAoGT4Et8U4TuiuLG92hf4SJHv4xld8BtLR3mNzgwKyISq14YvAs9O1VyVTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KDiBNQFw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KDiBNQFw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25719C4CEE7; Fri, 6 Jun 2025 01:43:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749174220; bh=WHD4PuJMG/otH7gj9OW8gaFkbv8GJd+ZMOtkEz6VlI0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KDiBNQFwPOJSHFPrrahSQhMOzBG9hBiS/dxK00kJTNqTOE3QOaOhTkOY9DfSBh6bX ZCgWdmJM1YbRTIOlNFme98LasmYt/0R811/ItDw1NgUZB68+boR2uhQ6IoHqbukGzH UVwmM0lNPIPhNcbSDRMXkQL/OAGg8NK88yWk7z3UAArRUhLYtvL9VTs7eLDihalUlv kY3Gtd7+0Kbqnnk2O3sYzbsQWEbKVSn1OD/M9KQYUH/zp7UVKIl+8hBpnPv0Evcxbr kxsL7dMK+XVSabsh1I6QnVHfrXdeEtQFCOuYwSmpHfJDE0AatbjLmiZekYjJkztQAJ 5UoDPBEOgJbUQ== Date: Thu, 5 Jun 2025 18:43:39 -0700 From: Jakub Kicinski To: Ian Ray Cc: horms@kernel.org, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , brian.ruley@gehealthcare.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] igb: Fix watchdog_task race with shutdown Message-ID: <20250605184339.7a4e0f96@kernel.org> In-Reply-To: <20250603080949.1681-1-ian.ray@gehealthcare.com> References: <20250603080949.1681-1-ian.ray@gehealthcare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 3 Jun 2025 11:09:49 +0300 Ian Ray wrote: > set_bit(__IGB_DOWN, &adapter->state); > + timer_delete_sync(&adapter->watchdog_timer); > + timer_delete_sync(&adapter->phy_info_timer); > + > + cancel_work_sync(&adapter->watchdog_task); This doesn't look very race-proof as watchdog_task can schedule the timer as its last operation?