Re: [LTP] [PATCH v5 7/8] syscalls/mknod07: Convert to new API

[Petr Vorel <pvorel@suse.cz>]

Hi Ricardo,

> +static struct tcase {
>  	char *pathname;
>  	int mode;
>  	int exp_errno;
>  	int major, minor;
> -} test_cases[] = {
> -	{ "testdir_1/tnode_1", SOCKET_MODE, EACCES, 0, 0 },
> -	{ "testdir_1/tnode_2", FIFO_MODE, EACCES, 0, 0 },
> -	{ "tnode_3", CHR_MODE, EPERM, 1, 3 },
> -	{ "tnode_4", BLK_MODE, EPERM, 0, 0 },
> -	{ "mntpoint/tnode_5", SOCKET_MODE, EROFS, 0, 0 },
> -	{ elooppathname, FIFO_MODE, ELOOP, 0, 0 },
> +} tcases[] = {
> +	{ NULL, FIFO_MODE, ELOOP, 0, 0 },
> +	{ TEMP_DIR "/tnode1", SOCKET_MODE, EACCES, 0, 0 },

I would slightly prefer to use designated initializers as it's more descriptive
and allows to avoid setting 0 or NULL:

	{ .mode = FIFO_MODE, .exp_errno = ELOOP },
	{ .pathname = TEMP_DIR "/tnode1", .mode = SOCKET_MODE, .exp_errno = EACCES },

But let's ignore it.

Thanks for the rewrite!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> +	{ TEMP_DIR "/tnode2", FIFO_MODE, EACCES, 0, 0 },
> +	{ "tnode3", CHR_MODE, EPERM, 1, 3 },
> +	{ "tnode4", BLK_MODE, EPERM, 0, 0 },
> +	{ TEMP_MNT "/tnode5", SOCKET_MODE, EROFS, 0, 0 },
>  };

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp