Re: [PATCH v5 0/2] drm/panthor: Add 64-bit register accessors

[Boris Brezillon <boris.brezillon@collabora.com>]

On Fri,  6 Jun 2025 12:18:33 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:

> Hi all,
> 
> This patch series adds support for 64-bit and poll register accessors in
> the Panthor DRM driver and performs a cleanup of the 64-bit register
> definitions.
> 
> The first patch introduces new accessor functions to simplify and
> standardize 64-bit and polling register operations. The second patch
> refactors the existing 64-bit register definitions for improved clarity
> and consistency.
> 
> v5:
> - Rebased so I can apply cleanly with dim b4-shazam
> 
> v4:
> - [PATCH 1/2]:
>   - Fixed missing check against mask value in PWRTRANS register polling.
>   - Removed panthor_gpu_read_timestamp() and
>     panthor_gpu_read_timestamp_offset() in favour of direct register
>     access as they currently only serve as wrapper functions.
> - [PATCH 2/2]:
>   - Updated the register names inline with the removal of the two
>     timestamp functions.
> - Picked up Rb tags from Liviu and Steven
> - Link to v3: https://lore.kernel.org/dri-devel/20250411164805.2015088-1-karunika.choo@arm.com/
> v3:
> - Picked up Rb tags from Boris.
> - Link to v2: https://lore.kernel.org/dri-devel/20250411151140.1815435-1-karunika.choo@arm.com/
> v2:
> - Updated padding of the poll functions as requested
> - Removed *_HI register definitions and renamed *_LO registers
> - Link to v1: https://lore.kernel.org/dri-devel/20250410163546.919749-1-karunika.choo@arm.com/
> 
> Regards,
> 
> Boris
> 
> Karunika Choo (2):
>   drm/panthor: Add 64-bit and poll register accessors
>   drm/panthor: Clean up 64-bit register definitions

Queued to drm-misc-next.

> 
>  drivers/gpu/drm/panthor/panthor_device.h |  71 ++++++++++
>  drivers/gpu/drm/panthor/panthor_drv.c    |   4 +-
>  drivers/gpu/drm/panthor/panthor_fw.c     |   9 +-
>  drivers/gpu/drm/panthor/panthor_gpu.c    | 159 +++++------------------
>  drivers/gpu/drm/panthor/panthor_gpu.h    |  12 +-
>  drivers/gpu/drm/panthor/panthor_mmu.c    |  34 ++---
>  drivers/gpu/drm/panthor/panthor_regs.h   |  90 ++++---------
>  7 files changed, 157 insertions(+), 222 deletions(-)
>