All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: linux-kernel@vger.kernel.org, masahiroy@kernel.org,
	ojeda@kernel.org, bpf@vger.kernel.org, kernel-team@meta.com,
	Eduard Zingerman <eddyz87@gmail.com>
Subject: Re: [PATCH] .gitignore: ignore compile_commands.json globally
Date: Fri, 6 Jun 2025 10:40:47 -0700	[thread overview]
Message-ID: <20250606174047.GA4035746@ax162> (raw)
In-Reply-To: <20250605181426.2845741-1-andrii@kernel.org>

On Thu, Jun 05, 2025 at 11:14:26AM -0700, Andrii Nakryiko wrote:
> compile_commands.json can be used with clangd to enable language server
> protocol-based assistance. For kernel itself this can be built with
> scripts/gen_compile_commands.py, but other projects (e.g., libbpf, or
> BPF selftests) can benefit from their own compilation database file,
> which can be generated successfully using external tools, like bear [0].
> 
> So, instead of adding compile_commands.json to .gitignore in respective
> individual projects, let's just ignore it globally anywhere in Linux repo.
> 
>   [0] https://github.com/rizsotto/Bear
> 
> Suggested-by: Eduard Zingerman <eddyz87@gmail.com>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

Sure, I cannot imagine anyone actually wanting to check these in,
regardless of where they exists.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  .gitignore | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitignore b/.gitignore
> index bf5ee6e01cd4..451dff66275d 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -175,7 +175,7 @@ x509.genkey
>  *.kdev4
>  
>  # Clang's compilation database file
> -/compile_commands.json
> +compile_commands.json
>  
>  # Documentation toolchain
>  sphinx_*/
> -- 
> 2.47.1
> 

  reply	other threads:[~2025-06-06 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 18:14 [PATCH] .gitignore: ignore compile_commands.json globally Andrii Nakryiko
2025-06-06 17:40 ` Nathan Chancellor [this message]
2025-06-06 19:41 ` Miguel Ojeda
2025-06-06 21:43   ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250606174047.GA4035746@ax162 \
    --to=nathan@kernel.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.