Re: [RFC 03/13] objtool: Disassemble code with libopcodes instead of running objdump

[kernel test robot <lkp@intel.com>]

:::::: 
:::::: Manual check reason: "only suspicious fbc files changed"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250606153440.865808-4-alexandre.chartre@oracle.com>
References: <20250606153440.865808-4-alexandre.chartre@oracle.com>
TO: Alexandre Chartre <alexandre.chartre@oracle.com>

Hi Alexandre,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.15 next-20250606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexandre-Chartre/objtool-Move-disassembly-functions-to-a-separated-file/20250606-233948
base:   linus/master
patch link:    https://lore.kernel.org/r/20250606153440.865808-4-alexandre.chartre%40oracle.com
patch subject: [RFC 03/13] objtool: Disassemble code with libopcodes instead of running objdump
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
reproduce: (https://download.01.org/0day-ci/archive/20250607/202506070147.yRx7HyNf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202506070147.yRx7HyNf-lkp@intel.com/

All errors (new ones prefixed by >>):

   1 error generated.
   make[2]: *** [scripts/Makefile.build:98: scripts/mod/devicetable-offsets.s] Error 1
   make[2]: Target 'scripts/mod/' not remade because of errors.
   make[1]: *** [Makefile:1278: prepare0] Error 2
   In file included from disas.c:12:
>> tools/include/tools/dis-asm-compat.h:10:6: error: redefinition of 'disassembler_style'
      10 | enum disassembler_style {DISASSEMBLER_STYLE_NOT_EMPTY};
         |      ^
   /usr/include/dis-asm.h:53:6: note: previous definition is here
      53 | enum disassembler_style
         |      ^
   In file included from disas.c:12:
>> tools/include/tools/dis-asm-compat.h:51:23: error: too few arguments to function call, expected 4, have 3
      50 |         init_disassemble_info(info, stream,
         |         ~~~~~~~~~~~~~~~~~~~~~
      51 |                               unstyled_func);
         |                                            ^
   /usr/include/dis-asm.h:480:13: note: 'init_disassemble_info' declared here


vim +/disassembler_style +10 tools/include/tools/dis-asm-compat.h

a45b3d6926231c Andres Freund 2022-07-31   7  
a45b3d6926231c Andres Freund 2022-07-31   8  /* define types for older binutils version, to centralize ifdef'ery a bit */
a45b3d6926231c Andres Freund 2022-07-31   9  #ifndef DISASM_INIT_STYLED
a45b3d6926231c Andres Freund 2022-07-31 @10  enum disassembler_style {DISASSEMBLER_STYLE_NOT_EMPTY};
a45b3d6926231c Andres Freund 2022-07-31  11  typedef int (*fprintf_styled_ftype) (void *, enum disassembler_style, const char*, ...);
a45b3d6926231c Andres Freund 2022-07-31  12  #endif
a45b3d6926231c Andres Freund 2022-07-31  13  
a45b3d6926231c Andres Freund 2022-07-31  14  /*
a45b3d6926231c Andres Freund 2022-07-31  15   * Trivial fprintf wrapper to be used as the fprintf_styled_func argument to
a45b3d6926231c Andres Freund 2022-07-31  16   * init_disassemble_info_compat() when normal fprintf suffices.
a45b3d6926231c Andres Freund 2022-07-31  17   */
a45b3d6926231c Andres Freund 2022-07-31  18  static inline int fprintf_styled(void *out,
a45b3d6926231c Andres Freund 2022-07-31  19  				 enum disassembler_style style,
a45b3d6926231c Andres Freund 2022-07-31  20  				 const char *fmt, ...)
a45b3d6926231c Andres Freund 2022-07-31  21  {
a45b3d6926231c Andres Freund 2022-07-31  22  	va_list args;
a45b3d6926231c Andres Freund 2022-07-31  23  	int r;
a45b3d6926231c Andres Freund 2022-07-31  24  
a45b3d6926231c Andres Freund 2022-07-31  25  	(void)style;
a45b3d6926231c Andres Freund 2022-07-31  26  
a45b3d6926231c Andres Freund 2022-07-31  27  	va_start(args, fmt);
a45b3d6926231c Andres Freund 2022-07-31  28  	r = vfprintf(out, fmt, args);
a45b3d6926231c Andres Freund 2022-07-31  29  	va_end(args);
a45b3d6926231c Andres Freund 2022-07-31  30  
a45b3d6926231c Andres Freund 2022-07-31  31  	return r;
a45b3d6926231c Andres Freund 2022-07-31  32  }
a45b3d6926231c Andres Freund 2022-07-31  33  
a45b3d6926231c Andres Freund 2022-07-31  34  /*
a45b3d6926231c Andres Freund 2022-07-31  35   * Wrapper for init_disassemble_info() that hides version
a45b3d6926231c Andres Freund 2022-07-31  36   * differences. Depending on binutils version and architecture either
a45b3d6926231c Andres Freund 2022-07-31  37   * fprintf_func or fprintf_styled_func will be called.
a45b3d6926231c Andres Freund 2022-07-31  38   */
a45b3d6926231c Andres Freund 2022-07-31  39  static inline void init_disassemble_info_compat(struct disassemble_info *info,
a45b3d6926231c Andres Freund 2022-07-31  40  						void *stream,
a45b3d6926231c Andres Freund 2022-07-31  41  						fprintf_ftype unstyled_func,
a45b3d6926231c Andres Freund 2022-07-31  42  						fprintf_styled_ftype styled_func)
a45b3d6926231c Andres Freund 2022-07-31  43  {
a45b3d6926231c Andres Freund 2022-07-31  44  #ifdef DISASM_INIT_STYLED
a45b3d6926231c Andres Freund 2022-07-31  45  	init_disassemble_info(info, stream,
a45b3d6926231c Andres Freund 2022-07-31  46  			      unstyled_func,
a45b3d6926231c Andres Freund 2022-07-31  47  			      styled_func);
a45b3d6926231c Andres Freund 2022-07-31  48  #else
a45b3d6926231c Andres Freund 2022-07-31  49  	(void)styled_func;
a45b3d6926231c Andres Freund 2022-07-31  50  	init_disassemble_info(info, stream,
a45b3d6926231c Andres Freund 2022-07-31 @51  			      unstyled_func);
a45b3d6926231c Andres Freund 2022-07-31  52  #endif
a45b3d6926231c Andres Freund 2022-07-31  53  }
a45b3d6926231c Andres Freund 2022-07-31  54  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki