From: Rosen Penev <rosenp@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
nbd@nbd.name, "Johannes Berg" <johannes@sipsolutions.net>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list),
linux-mips@vger.kernel.org (open list:MIPS)
Subject: [PATCHv5 1/5] wifi: ath9k: ahb: reorder declarations
Date: Sun, 8 Jun 2025 20:08:47 -0700 [thread overview]
Message-ID: <20250609030851.17739-2-rosenp@gmail.com> (raw)
In-Reply-To: <20250609030851.17739-1-rosenp@gmail.com>
Easier to look at. Follows netdev style.
Also remove ret assignment. Because of all of these devm conversions,
ret = 0 is a path that never gets hit. The first time it does it when
request_irq fails, but that ends up reassigning it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/net/wireless/ath/ath9k/ahb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
index 49b7ab26c477..d2a97e74f451 100644
--- a/drivers/net/wireless/ath/ath9k/ahb.c
+++ b/drivers/net/wireless/ath/ath9k/ahb.c
@@ -71,14 +71,14 @@ static const struct ath_bus_ops ath_ahb_bus_ops = {
static int ath_ahb_probe(struct platform_device *pdev)
{
- void __iomem *mem;
- struct ath_softc *sc;
- struct ieee80211_hw *hw;
const struct platform_device_id *id = platform_get_device_id(pdev);
- int irq;
- int ret = 0;
+ struct ieee80211_hw *hw;
+ struct ath_softc *sc;
struct ath_hw *ah;
+ void __iomem *mem;
char hw_name[64];
+ int irq;
+ int ret;
if (!dev_get_platdata(&pdev->dev)) {
dev_err(&pdev->dev, "no platform data specified\n");
--
2.49.0
next prev parent reply other threads:[~2025-06-09 3:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 3:08 [PATCHv5 0/5] wifi: ath9k: add ahb OF support Rosen Penev
2025-06-09 3:08 ` Rosen Penev [this message]
2025-06-09 3:08 ` [PATCHv5 2/5] wifi: ath9k: ahb: reorder includes Rosen Penev
2025-06-09 3:08 ` [PATCHv5 3/5] dt-bindings: net: wireless: ath9k: add WIFI bindings Rosen Penev
2025-06-09 3:08 ` [PATCHv5 4/5] wifi: ath9k: ahb: replace id_table with of Rosen Penev
2025-06-09 3:08 ` [PATCHv5 5/5] mips: dts: qca: add wmac support Rosen Penev
2025-07-02 12:28 ` Thomas Bogendoerfer
2025-06-20 0:33 ` [PATCHv5 0/5] wifi: ath9k: add ahb OF support Jeff Johnson
2025-06-20 5:32 ` Krzysztof Kozlowski
2025-06-20 5:39 ` Krzysztof Kozlowski
2025-06-20 15:27 ` Jeff Johnson
2025-06-20 15:45 ` Krzysztof Kozlowski
2025-06-20 8:50 ` Toke Høiland-Jørgensen
2025-06-26 23:15 ` (subset) " Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609030851.17739-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=robh@kernel.org \
--cc=toke@toke.dk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.