From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD2A1F19A for ; Mon, 9 Jun 2025 04:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749441664; cv=none; b=kFTB3umlVSnngAEq6FKRYrhusHh9nRlKITp7oDEM6dg55xdrHUEEygB+nyAC9jRpP7eQKbqZi4/CeFUwNDut3o6BB5bJcbTgj6LSWwicv5K0MkSbJ/tPwXEEdzcT/lAw//MW3+5Hqk7Us3L5mLlpv0RVXiINWo+orervwVQEsNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749441664; c=relaxed/simple; bh=MYaJ4/v+wAL52dUFMwiWFuCt2eoCt7JsNodSlWf6DJw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IvcfzVbVUmXG7PKaKuOC069RnWTFIINKkdKCd5cNf6VpHeYM0CQGMGBhRYCpjpoql14L90ygAXLnGl5AP2AZa8/2Q2tIIyvodMfTvixThjSj5te9FEIVhETWnDip9uMibFglUwt94I8hJZWNrGeJsTMlmliz9SIDXf6M019u4NA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 4222168AFE; Mon, 9 Jun 2025 06:00:57 +0200 (CEST) Date: Mon, 9 Jun 2025 06:00:56 +0200 From: Christoph Hellwig To: Kundan Kumar Cc: Christoph Hellwig , Anuj gupta , Anuj Gupta/Anuj Gupta , Kundan Kumar , jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com Subject: Re: [PATCH 00/13] Parallelizing filesystem writeback Message-ID: <20250609040056.GA26101@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250602141904.GA21996@lst.de> <20250603132434.GA10865@lst.de> <20250603140445.GA14351@lst.de> <20250603140513.GB14351@lst.de> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Jun 06, 2025 at 10:34:42AM +0530, Kundan Kumar wrote: > Thanks for the suggestion β€” I agree the default should come from a > filesystem-level helper, not a mount option. > > I looked into the sysfs override idea, but one challenge is that > nr_wb_ctx must be finalized before any writes occur. That leaves only > a narrow window β€” after the bdi is registered but before any inodes > are dirtied β€” where changing it is safe. > > This makes the sysfs knob a bit fragile unless we tightly guard it > (e.g., mark it read-only after init). A mount option, even just as an > override, feels simpler and more predictable, since it’s set before > the FS becomes active. The mount option has a few issues: - the common VFS code only support flags, not value options, so you'd have to wire this up in every file system - some file system might not want to allow changing it - changing it at runtime is actuallyt quite useful So you'll need to quiesce writeback or maybe even do a full fs freeze when changing it a runtime, but that seems ok for a change this invasive. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F0BC61DB2 for ; Mon, 9 Jun 2025 04:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HnJ6p0TfCyzSbc0y7rvsMsmGTiCb4NfGex5zjuDhbE0=; b=iUUDobDS74rAfWTXCHikwguOD9 69oMv1oA8dm3yDTAmRciez6yu6CpBVZRCddgKVJEjADcrVLk7+Kje0xJv/WRg726SrUS0jCSfUsZv k9jgYGBtymyLh1LT9S6JGtn7tdnBXx+dWv6Z8C/J1MfpJrNv/qwvDE1nAANR4It0Mdvk=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1uOTh7-0003uX-U0; Mon, 09 Jun 2025 04:01:09 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uOTh6-0003uQ-Dk for linux-f2fs-devel@lists.sourceforge.net; Mon, 09 Jun 2025 04:01:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+OrUcEIJpkzIqPSaSMapcl8mkrvVwMc4GV6bBX9ZsrI=; b=hFV30pFUVHRvaYSKuehaJuZEO2 S0FHwVH/gKf3rzx94kyccHqO4u1T48AlpCpmEUvGQvE3yqErZAxNmxwdnpWeBoi10KtmID+c2xIUP im8JhKlFKEM1LsPs9OMbxjLi31lO0vYiQSDwLYCFqegESzILDjHpiqjQ64hYtOnd3OS8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+OrUcEIJpkzIqPSaSMapcl8mkrvVwMc4GV6bBX9ZsrI=; b=GjPU/aZehsuaEPEAjrSCN06TH2 D3AbbXyYZswj+iAI7CGiMK02SodPux6X+TPi1Ko67C23OyXCXHM8PbE17drvuv+asWQx9Aw5M21+r UwrA1IEBBfgcfjvxVDR6Nus2rbzl3MxO8zXhcy6pZURO8L68RGgsRGRJBsDMHjbaAQtE=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1uOTh5-0007QY-R4 for linux-f2fs-devel@lists.sourceforge.net; Mon, 09 Jun 2025 04:01:08 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4222168AFE; Mon, 9 Jun 2025 06:00:57 +0200 (CEST) Date: Mon, 9 Jun 2025 06:00:56 +0200 From: Christoph Hellwig To: Kundan Kumar Message-ID: <20250609040056.GA26101@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250602141904.GA21996@lst.de> <20250603132434.GA10865@lst.de> <20250603140445.GA14351@lst.de> <20250603140513.GB14351@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1uOTh5-0007QY-R4 Subject: Re: [f2fs-dev] [PATCH 00/13] Parallelizing filesystem writeback X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ritesh.list@gmail.com, Anuj gupta , jack@suse.cz, djwong@kernel.org, amir73il@gmail.com, david@fromorbit.com, gfs2@lists.linux.dev, linux-mm@kvack.org, clm@meta.com, Christoph Hellwig , dave@stgolabs.net, agruenba@redhat.com, miklos@szeredi.hu, Kundan Kumar , willy@infradead.org, p.raghav@samsung.com, Anuj Gupta/Anuj Gupta , linux-nfs@vger.kernel.org, da.gomez@samsung.com, viro@zeniv.linux.org.uk, jaegeuk@kernel.org, axboe@kernel.dk, brauner@kernel.org, linux-f2fs-devel@lists.sourceforge.net, mcgrof@kernel.org, anna@kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, trondmy@kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gRnJpLCBKdW4gMDYsIDIwMjUgYXQgMTA6MzQ6NDJBTSArMDUzMCwgS3VuZGFuIEt1bWFyIHdy b3RlOgo+IFRoYW5rcyBmb3IgdGhlIHN1Z2dlc3Rpb24g4oCUIEkgYWdyZWUgdGhlIGRlZmF1bHQg c2hvdWxkIGNvbWUgZnJvbSBhCj4gZmlsZXN5c3RlbS1sZXZlbCBoZWxwZXIsIG5vdCBhIG1vdW50 IG9wdGlvbi4KPiAKPiBJIGxvb2tlZCBpbnRvIHRoZSBzeXNmcyBvdmVycmlkZSBpZGVhLCBidXQg b25lIGNoYWxsZW5nZSBpcyB0aGF0Cj4gbnJfd2JfY3R4IG11c3QgYmUgZmluYWxpemVkIGJlZm9y ZSBhbnkgd3JpdGVzIG9jY3VyLiBUaGF0IGxlYXZlcyBvbmx5Cj4gYSBuYXJyb3cgd2luZG93IOKA lCBhZnRlciB0aGUgYmRpIGlzIHJlZ2lzdGVyZWQgYnV0IGJlZm9yZSBhbnkgaW5vZGVzCj4gYXJl IGRpcnRpZWQg4oCUIHdoZXJlIGNoYW5naW5nIGl0IGlzIHNhZmUuCj4gCj4gVGhpcyBtYWtlcyB0 aGUgc3lzZnMga25vYiBhIGJpdCBmcmFnaWxlIHVubGVzcyB3ZSB0aWdodGx5IGd1YXJkIGl0Cj4g KGUuZy4sIG1hcmsgaXQgcmVhZC1vbmx5IGFmdGVyIGluaXQpLiBBIG1vdW50IG9wdGlvbiwgZXZl biBqdXN0IGFzIGFuCj4gb3ZlcnJpZGUsIGZlZWxzIHNpbXBsZXIgYW5kIG1vcmUgcHJlZGljdGFi bGUsIHNpbmNlIGl04oCZcyBzZXQgYmVmb3JlCj4gdGhlIEZTIGJlY29tZXMgYWN0aXZlLgoKVGhl IG1vdW50IG9wdGlvbiBoYXMgYSBmZXcgaXNzdWVzOgoKIC0gdGhlIGNvbW1vbiBWRlMgY29kZSBv bmx5IHN1cHBvcnQgZmxhZ3MsIG5vdCB2YWx1ZSBvcHRpb25zLCBzbyB5b3UnZAogICBoYXZlIHRv IHdpcmUgdGhpcyB1cCBpbiBldmVyeSBmaWxlIHN5c3RlbQogLSBzb21lIGZpbGUgc3lzdGVtIG1p Z2h0IG5vdCB3YW50IHRvIGFsbG93IGNoYW5naW5nIGl0CiAtIGNoYW5naW5nIGl0IGF0IHJ1bnRp bWUgaXMgYWN0dWFsbHl0IHF1aXRlIHVzZWZ1bAoKU28geW91J2xsIG5lZWQgdG8gcXVpZXNjZSB3 cml0ZWJhY2sgb3IgbWF5YmUgZXZlbiBkbyBhIGZ1bGwgZnMgZnJlZXplCndoZW4gY2hhbmdpbmcg aXQgYSBydW50aW1lLCBidXQgdGhhdCBzZWVtcyBvayBmb3IgYSBjaGFuZ2UgdGhpcyBpbnZhc2l2 ZS4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZv cmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51 eC1mMmZzLWRldmVsCg==