From: Stephen Hemminger <stephen@networkplumber.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Vitaly Lifshits <vitaly.lifshits@intel.com>
Subject: Re: [PATCH v1 1/2] net/e1000: better clock synchronization workaround
Date: Mon, 9 Jun 2025 09:23:10 -0700 [thread overview]
Message-ID: <20250609092310.0d19c68c@hermes.local> (raw)
In-Reply-To: <1a8eb4a20513e1856bba0d6df25ce378aa8d7fae.1749464159.git.anatoly.burakov@intel.com>
On Mon, 9 Jun 2025 11:16:41 +0100
Anatoly Burakov <anatoly.burakov@intel.com> wrote:
> + ret_val = hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG,
> + phy_timeout);
> +
> + return ret_val;
Why use temporary value (ret_val) and not just a return statement?
return hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG, phy_timeout);
next prev parent reply other threads:[~2025-06-09 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 10:16 [PATCH v1 0/2] e1000 base code update Anatoly Burakov
2025-06-09 10:16 ` [PATCH v1 1/2] net/e1000: better clock synchronization workaround Anatoly Burakov
2025-06-09 16:23 ` Stephen Hemminger [this message]
2025-06-12 11:16 ` Burakov, Anatoly
2025-06-09 10:16 ` [PATCH v1 2/2] net/e1000: update README Anatoly Burakov
2025-06-09 15:53 ` [PATCH v1 0/2] e1000 base code update Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609092310.0d19c68c@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.