All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Holmberg <Hans.Holmberg@wdc.com>
To: Zorro Lang <zlang@kernel.org>
Cc: hch <hch@lst.de>, "tytso@mit.edu" <tytso@mit.edu>,
	"djwong@kernel.org" <djwong@kernel.org>,
	"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	Hans Holmberg <Hans.Holmberg@wdc.com>
Subject: [PATCH 2/2] ext4/002: make generic to support xfs
Date: Mon, 9 Jun 2025 11:03:54 +0000	[thread overview]
Message-ID: <20250609110307.17455-3-hans.holmberg@wdc.com> (raw)
In-Reply-To: <20250609110307.17455-1-hans.holmberg@wdc.com>

xfs supports separate log devices and as this test now passes, share
it by turning it into a generic test.

This should not result in a new failure for other file systems as only
ext2/ext3/ext4 and xfs supports mkfs with SCRATCH_LOGDEVs.

Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
---
 tests/{ext4/002 => generic/766}         | 11 ++++++++++-
 tests/{ext4/002.out => generic/766.out} |  2 +-
 2 files changed, 11 insertions(+), 2 deletions(-)
 rename tests/{ext4/002 => generic/766} (91%)
 rename tests/{ext4/002.out => generic/766.out} (98%)

diff --git a/tests/ext4/002 b/tests/generic/766
similarity index 91%
rename from tests/ext4/002
rename to tests/generic/766
index 6c1e1d926973..3b6911f0bdb9 100755
--- a/tests/ext4/002
+++ b/tests/generic/766
@@ -3,10 +3,11 @@
 # Copyright (c) 2009 Christoph Hellwig.
 # Copyright (c) 2020 Lukas Czerner.
 #
-# FS QA Test No. 002
+# FS QA Test No. 766
 #
 # Copied from tests generic/050 and adjusted to support testing
 # read-only external journal device on ext4.
+# Moved to generic from ext4/002 to support xfs as well
 #
 # Check out various mount/remount/unmount scenarious on a read-only
 # logdev blockdev.
@@ -31,6 +32,14 @@ _cleanup()
 
 _exclude_fs ext2
 
+[ $FSTYP == "ext4" ] && \
+        _fixed_by_kernel_commit 273108fa5015 \
+        "ext4: handle read only external journal device"
+
+[ $FSTYP == "xfs" ] && \
+        _fixed_by_kernel_commit bfecc4091e07 \
+        "xfs: allow ro mounts if rtdev or logdev are read-only"
+
 _require_scratch_nocheck
 _require_scratch_shutdown
 _require_logdev
diff --git a/tests/ext4/002.out b/tests/generic/766.out
similarity index 98%
rename from tests/ext4/002.out
rename to tests/generic/766.out
index 579bc7e0cd78..975751751749 100644
--- a/tests/ext4/002.out
+++ b/tests/generic/766.out
@@ -1,4 +1,4 @@
-QA output created by 002
+QA output created by 766
 setting log device read-only
 mounting with read-only log device:
 mount: device write-protected, mounting read-only
-- 
2.34.1

  parent reply	other threads:[~2025-06-09 11:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 11:03 [PATCH 0/2] Add xfs test coverage for ro external dev mounts Hans Holmberg
2025-06-09 11:03 ` [PATCH 1/2] xfs: add mount test for read only rt devices Hans Holmberg
2025-06-09 16:18   ` Darrick J. Wong
2025-06-10  3:36   ` hch
2025-06-09 11:03 ` Hans Holmberg [this message]
2025-06-09 16:20   ` [PATCH 2/2] ext4/002: make generic to support xfs Darrick J. Wong
2025-06-10  3:37   ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609110307.17455-3-hans.holmberg@wdc.com \
    --to=hans.holmberg@wdc.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.