From: Jakub Kicinski <kuba@kernel.org>
To: Abin Joseph <abin.joseph@amd.com>
Cc: <nicolas.ferre@microchip.com>, <claudiu.beznea@tuxon.dev>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <git@amd.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] net: macb: Add shutdown operation support
Date: Mon, 9 Jun 2025 14:20:27 -0700 [thread overview]
Message-ID: <20250609142027.25d1e58c@kernel.org> (raw)
In-Reply-To: <20250607075713.1829282-1-abin.joseph@amd.com>
On Sat, 7 Jun 2025 13:27:13 +0530 Abin Joseph wrote:
> + rtnl_lock();
> + netif_device_detach(netdev);
> +
> + if (netif_running(netdev))
> + dev_close(netdev);
> +
> + rtnl_unlock();
nit: could you move the netif_device_detach() after
the dev_close() call? It feels a little backwards, even
tho I think it will work just fine with current code.
Also nit2: you added an empty line before the unlock
but not after lock?
--
pw-bot: cr
prev parent reply other threads:[~2025-06-09 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 7:57 [PATCH net-next v2] net: macb: Add shutdown operation support Abin Joseph
2025-06-07 12:28 ` Claudiu Beznea
2025-06-07 16:24 ` Heiner Kallweit
2025-06-09 21:20 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609142027.25d1e58c@kernel.org \
--to=kuba@kernel.org \
--cc=abin.joseph@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.