From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F03AA2940D for ; Mon, 9 Jun 2025 22:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749507187; cv=none; b=iYXsEXALp6V6BhQ/MNqJtFipt/CJ8hk8EWYig5XVoEFbFAvwtENoXQMDhWjMsXDBTlPpqpoNC/FeowHO6C9kXGYDCBu5DPnjzWfWjpzAhu1lEZODJ4MG/D4n0EeuBoEuzBsRPAr23f+2OmLK9SdwV6MSPH6krCYVczSOuN40wLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749507187; c=relaxed/simple; bh=VXXxkbnNgdRRyoozij7mqZ/QWwrqGWmsrl4NthqT96M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f7vi0cXbuLSYAMp+RID3i3oWKTs7/IRrdDO4mapJ+ox6kqtYyLvNZyJzjKhaAL0t7+7DMb51VjK8PV10xyUWz/gszmapPASiMWAmjrWySr2PzlLZIXRZZPZZERu9Awb6Cr/ayK+qJ6FZMHR4Q9uZSmA1pc2wZTnXcPWzZ2YxuCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=B+N/RyZ5; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="B+N/RyZ5" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-235ca5eba8cso17275ad.0 for ; Mon, 09 Jun 2025 15:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749507185; x=1750111985; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UHg0wNvqKT3APd6+AuwNT/baU0QPXa/i9UgHGbxzSbA=; b=B+N/RyZ5Uq0Bm+1r4hREmkjP+m4g4+jfaHOxpK2CpaOqosMbEdZOfplcSqc77dRQJ2 6BEUTvLjCywjgEyrS/jdnV2j468V1lbuausXi92vMf6Sho83l00/tQOr+mSPNM+5O0GI biT5shlxSB8jD0ef7BgOajCtn3h7Qqt97oIyQ8AKfaCohilL6yzkOIEjoym7vzASKjWZ OMegc3WvcbBGhP/nQrgXxU5jih1dclMoIILMjR8f85gYWqsPkTmAG5eZBbYcL0gz5OEy 7VKK2Cq+CBn0BQ+2vYUDQSYaxM1X58jxe/Xju/9rErCeUzyx9XemTF6oP+Bv7lsFhByi Ttbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749507185; x=1750111985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UHg0wNvqKT3APd6+AuwNT/baU0QPXa/i9UgHGbxzSbA=; b=bqZaCVTvuuKcWP+9jU2o75HID3dzEF1Xk4sVVuuGC/tkZZQgJ0z8g4HLfSMQSN36FI +7x0KRS7dcFmnJLYnmVhfl/BGDxrgwnYQXTPc+xVNghbXEUBYYGLN/SGrZiWEc27+SIU 8MpnFhFvBSOAuMsGd/hVt30jKDnURqVD+LXfs7GdL4IgnzZEQ8OnNARZcrfSdcr2FRKZ Knt4nJ7Z8UE80OTUTJE1QDLWbj64yPS0vQYgq6urGgoV7fDg2LKbb6xmUPMKgTHgDTgN RTXZlzkaISY4WaXSy7hTARfMTyp3UXXMPVc3xE1rMi+bLKt6znoXMsX+Xl0aWdSfqChX /uNA== X-Forwarded-Encrypted: i=1; AJvYcCWnfBz8WTWm+jIi4aspi3I3K1puYnjFi0kPDa1u+KBUQ9A1ZJOs5+Kdhhm132+DXmXvJrDLYBqr6YuCdyaZ@vger.kernel.org X-Gm-Message-State: AOJu0Yyd6VyhnVZzVd+RlqrGmX0PZj26GhI+a2EeJ5VZEcZ7Ez5E2uS8 5mM4Ski9b070MXik8Nwl0okw1MaaKILB6FzBqNsj7jG5U0bVfDXIztnQ1rWnFAEMSA== X-Gm-Gg: ASbGncvpcRMK0pC8ZXc1P5IvWbBT0VV/qjWbgCKUiybDG0aKiFy4db0QL2Vp5k3dyhU i4XPlyi2dXB32te4z9/rs0Y2wXru8uB5cbEn2B7LItwJbWzIM5qv67FmkwdWK3mjhBuDZ4LNtKt 7tDtnY2aIiLEC1zobSNGdbzdAnS2bn/D8p2va59SfQkVzdbN4q46ZdTNgpOb6iFMgaR086j4hI0 xvXGdaAMDycY2s8Zons4mYjUioXvofK4aVsbGo9l8ufB9om87pcobqi0cqDz8jru6z5tPH+DP6x uPN/LyIPJLTmhcqnOC3MuBFlgLDHi6AMHZBsVSdKuXgd3+niUDJPm1mqutnRsmnWvSPo+2RUjA8 IDTF01pqaqnhX4k7M97NBPsp/EisowsQsg/9ZmA5heyU= X-Google-Smtp-Source: AGHT+IHD8aijVhr7ZJQC34MbeFp7LpXYs0kbLW0dUhVholO8EmoQewaEViVvVyXoYlTBPFUbCzJrzw== X-Received: by 2002:a17:902:dac3:b0:223:ff93:322f with SMTP id d9443c01a7336-23611fcc9a7mr6385345ad.2.1749507185045; Mon, 09 Jun 2025 15:13:05 -0700 (PDT) Received: from google.com (187.137.203.35.bc.googleusercontent.com. [35.203.137.187]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482b0f2ee1sm6391945b3a.175.2025.06.09.15.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 15:13:04 -0700 (PDT) Date: Mon, 9 Jun 2025 22:13:00 +0000 From: Sami Tolvanen To: Petr Pavlu Cc: Luis Chamberlain , Daniel Gomez , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] module: Avoid unnecessary return value initialization in move_module() Message-ID: <20250609221300.GB1439779@google.com> References: <20250607161823.409691-1-petr.pavlu@suse.com> <20250607161823.409691-3-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250607161823.409691-3-petr.pavlu@suse.com> On Sat, Jun 07, 2025 at 06:16:28PM +0200, Petr Pavlu wrote: > All error conditions in move_module() set the return value by updating the > ret variable. Therefore, it is not necessary to the initialize the variable > when declaring it. > > Remove the unnecessary initialization. > > Signed-off-by: Petr Pavlu > --- > kernel/module/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/module/main.c b/kernel/module/main.c > index 322b38c0a782..06511607075c 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -2615,7 +2615,7 @@ static int move_module(struct module *mod, struct load_info *info) > { > int i; > enum mod_mem_type t; > - int ret = -ENOMEM; > + int ret; > bool codetag_section_found = false; > > for_each_mod_mem_type(type) { Reviewed-by: Sami Tolvanen Sami