From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA061519BA; Mon, 9 Jun 2025 22:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749509989; cv=none; b=ZOPa2M06NoGk7s06kB8cZCvRq33J7SjKW4zuJ8o0BhVWQAx2ehJpfhfxd+6A7gokJvoOafdP9IWgYgDU+3gpXv55Ns99+nIfuKq/j1vhdOVJ2zRyVNuaKhuvrEZD6CmzuSZx6M4z7teVKtI7BuOfTtRTQu+z6qIMpeOw9vCWNEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749509989; c=relaxed/simple; bh=U4vhsJXM46e+0Mfc4PBs3bseTa3h9UosBlHtozqeIf8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B7JCme5vD0DNL+6n75FdM5qPiHxCgzKtZ/4pNt3j8hjwHqc1d2wsL3PoGSMdDsvfU0BFtxyQErKVNE9RQC2jNUkf54etvqASNiM+/Upd7+7TlZvYS57oDemdCNiCQLmE5vdGx7pVbf9ZV1qhUVIYc+YmYxu7Vc8u9U1z59GgC3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bZ2q/LWi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZ2q/LWi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21A46C4CEEB; Mon, 9 Jun 2025 22:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749509988; bh=U4vhsJXM46e+0Mfc4PBs3bseTa3h9UosBlHtozqeIf8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bZ2q/LWijEpaEq00igAvU15ZFA2btFmPEoPv0oTqawn+MjrxKEc4/OqXy2N38kxpV AFvy2lrAzn2djDaUY1swfzB9EZ627MitJD6/avaXEMt58zpc+17thB5+o+L/NCFmXx Bbahqr8beEaE9JLR92svUSP/oo9HcH3K/MV2jUx5drdibhmczFNStuOfZD9lCWMysz P11+Cs72P7BkkpWfSW0Wc/UiWNcR1xk5ksNxTizKDn6BSr0mEtJF/ezlntceoWJxAz yys2b1O4D36HQh8H0QW/vQ0doPIIwaleXhHsMUSvkGTKjPZAQluFZIrFMruyPgxt0i IRxGum7RmzoYw== Date: Mon, 9 Jun 2025 15:59:26 -0700 From: Eric Biggers To: Julian Calaby Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, Ard Biesheuvel , "Jason A . Donenfeld" , Linus Torvalds Subject: Re: [PATCH v2 00/12] lib/crc: improve how arch-optimized code is integrated Message-ID: <20250609225926.GE1255@sol> References: <20250607200454.73587-1-ebiggers@kernel.org> <20250609194845.GC1255@sol> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jun 10, 2025 at 08:36:39AM +1000, Julian Calaby wrote: > Hi Eric, > > On Tue, Jun 10, 2025 at 5:49 AM Eric Biggers wrote: > > > > On Mon, Jun 09, 2025 at 06:15:24PM +1000, Julian Calaby wrote: > > > Hi Eric, > > > > > > On Sun, Jun 8, 2025 at 6:07 AM Eric Biggers wrote: > > > > > > > > This series is also available at: > > > > > > > > git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git lib-crc-arch-v2 > > > > > > > > This series improves how lib/crc supports arch-optimized code. First, > > > > instead of the arch-optimized CRC code being in arch/$(SRCARCH)/lib/, it > > > > will now be in lib/crc/$(SRCARCH)/. Second, the API functions (e.g. > > > > crc32c()), arch-optimized functions (e.g. crc32c_arch()), and generic > > > > functions (e.g. crc32c_base()) will now be part of a single module for > > > > each CRC type, allowing better inlining and dead code elimination. The > > > > second change is made possible by the first. > > > > > > > > As an example, consider CONFIG_CRC32=m on x86. We'll now have just > > > > crc32.ko instead of both crc32-x86.ko and crc32.ko. The two modules > > > > were already coupled together and always both got loaded together via > > > > direct symbol dependency, so the separation provided no benefit. > > > > > > > > Note: later I'd like to apply the same design to lib/crypto/ too, where > > > > often the API functions are out-of-line so this will work even better. > > > > In those cases, for each algorithm we currently have 3 modules all > > > > coupled together, e.g. libsha256.ko, libsha256-generic.ko, and > > > > sha256-x86.ko. We should have just one, inline things properly, and > > > > rely on the compiler's dead code elimination to decide the inclusion of > > > > the generic code instead of manually setting it via kconfig. > > > > > > > > Having arch-specific code outside arch/ was somewhat controversial when > > > > Zinc proposed it back in 2018. But I don't think the concerns are > > > > warranted. It's better from a technical perspective, as it enables the > > > > improvements mentioned above. This model is already successfully used > > > > in other places in the kernel such as lib/raid6/. The community of each > > > > architecture still remains free to work on the code, even if it's not in > > > > arch/. At the time there was also a desire to put the library code in > > > > the same files as the old-school crypto API, but that was a mistake; now > > > > that the library is separate, that's no longer a constraint either. > > > > > > Quick question, and apologies if this has been covered elsewhere. > > > > > > Why not just use choice blocks in Kconfig to choose the compiled-in > > > crc32 variant instead of this somewhat indirect scheme? > > > > > > This would keep the dependencies grouped by arch and provide a single place to > > > choose whether the generic or arch-specific method is used. > > > > It's not clear exactly what you're suggesting, but it sounds like you're > > complaining about this: > > > > config CRC32_ARCH > > bool > > depends on CRC32 && CRC_OPTIMIZATIONS > > default y if ARM && KERNEL_MODE_NEON > > default y if ARM64 > > default y if LOONGARCH > > default y if MIPS && CPU_MIPSR6 > > default y if PPC64 && ALTIVEC > > default y if RISCV && RISCV_ISA_ZBC > > default y if S390 > > default y if SPARC64 > > default y if X86 > > I was suggesting something roughly like: > > choice > prompt "CRC32 Variant" > depends on CRC32 && CRC_OPTIMIZATIONS > > config CRC32_ARCH_ARM_NEON > bool "ARM NEON" > default y > depends ARM && KERNEL_MODE_NEON > > ... > > config CRC32_GENERIC > bool "Generic" > > endchoice > > > This patchset strikes a balance where the vast majority of the arch-specific CRC > > code is isolated in lib/crc/$(SRCARCH), and the exceptions are just > > lib/crc/Makefile and lib/crc/Kconfig. I think these exceptions make sense, > > given that we're building a single module per CRC variant. We'd have to go > > through some hoops to isolate the arch-specific Kconfig and Makefile snippets > > into per-arch files, which don't seem worth it here IMO. > > I was only really concerned with the Kconfig structure, I was > expecting Kbuild to look roughly like this: (filenames are wrong) > > crc32-y += crc32-base.o > crc32-$(CRC32_ARCH_ARM_NEON) += arch/arm/crc32-neon.o > ... > crc32-$(CRC32_GENERIC) += crc32-generic.o > > but yeah, your proposal here has grown on me now that I think about it > and the only real "benefit" mine has is that architectures can display > choices for variants that have Kconfig-visible requirements, which > probably isn't that many so it wouldn't be useful in practice. > > Thanks for answering my question, The CRC32 implementation did used to be user-selectable, but that was already removed in v6.14 (except for the coarse-grained knob CONFIG_CRC_OPTIMIZATIONS that remains and can be disabled only when CONFIG_EXPERT=y) since the vast majority of users simply want the optimized CRC32 code enabled. The fact that it wasn't just enabled by default was a longstanding bug. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6778C5B552 for ; Mon, 9 Jun 2025 23:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QV8U5SFbM9rtmzvNapVuj6CUb5V9hir9FNEWpQB0nD4=; b=iRktFSY66FxfDc eYYSy8dwr247DYZ+rsdy/8PUsfl8tv/gx/ah9gFHInza0/2yWhJpChnCSoDDegdCRYldGfC/ovvb9 Pjl8oIWJCYfoy382MnzCLwKhSY0CtSEgSMt7eyOTOwUCetvp1nrMPVoQgNwqe0EK1QHiUdlRmYT6y YcFpxdTgl5wDNB/NbNb9a04iAolYcdTVVXqC6rrughVVGXOmT/mN81IbJK/Mi+vIrwRIXitBkePZa ylGEFk9yvPGia/1KNEpdfD/8ELp92BGygDo2fiGelKS46VOM74KYfJ5quMsBcIGT4MJLd6tMssi6j D9YgmKxWXvOfoK2ycz1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOlVD-00000005PYD-3xuW; Mon, 09 Jun 2025 23:02:03 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOlT3-00000005POT-20nW; Mon, 09 Jun 2025 22:59:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B726D4A946; Mon, 9 Jun 2025 22:59:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21A46C4CEEB; Mon, 9 Jun 2025 22:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749509988; bh=U4vhsJXM46e+0Mfc4PBs3bseTa3h9UosBlHtozqeIf8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bZ2q/LWijEpaEq00igAvU15ZFA2btFmPEoPv0oTqawn+MjrxKEc4/OqXy2N38kxpV AFvy2lrAzn2djDaUY1swfzB9EZ627MitJD6/avaXEMt58zpc+17thB5+o+L/NCFmXx Bbahqr8beEaE9JLR92svUSP/oo9HcH3K/MV2jUx5drdibhmczFNStuOfZD9lCWMysz P11+Cs72P7BkkpWfSW0Wc/UiWNcR1xk5ksNxTizKDn6BSr0mEtJF/ezlntceoWJxAz yys2b1O4D36HQh8H0QW/vQ0doPIIwaleXhHsMUSvkGTKjPZAQluFZIrFMruyPgxt0i IRxGum7RmzoYw== Date: Mon, 9 Jun 2025 15:59:26 -0700 From: Eric Biggers To: Julian Calaby Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, Ard Biesheuvel , "Jason A . Donenfeld" , Linus Torvalds Subject: Re: [PATCH v2 00/12] lib/crc: improve how arch-optimized code is integrated Message-ID: <20250609225926.GE1255@sol> References: <20250607200454.73587-1-ebiggers@kernel.org> <20250609194845.GC1255@sol> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250609_155949_558387_DE4D53DF X-CRM114-Status: GOOD ( 41.43 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMTAsIDIwMjUgYXQgMDg6MzY6MzlBTSArMTAwMCwgSnVsaWFuIENhbGFieSB3 cm90ZToKPiBIaSBFcmljLAo+IAo+IE9uIFR1ZSwgSnVuIDEwLCAyMDI1IGF0IDU6NDnigK9BTSBF cmljIEJpZ2dlcnMgPGViaWdnZXJzQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIE1vbiwg SnVuIDA5LCAyMDI1IGF0IDA2OjE1OjI0UE0gKzEwMDAsIEp1bGlhbiBDYWxhYnkgd3JvdGU6Cj4g PiA+IEhpIEVyaWMsCj4gPiA+Cj4gPiA+IE9uIFN1biwgSnVuIDgsIDIwMjUgYXQgNjowN+KAr0FN IEVyaWMgQmlnZ2VycyA8ZWJpZ2dlcnNAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4g PiBUaGlzIHNlcmllcyBpcyBhbHNvIGF2YWlsYWJsZSBhdDoKPiA+ID4gPgo+ID4gPiA+ICAgICBn aXQgZmV0Y2ggaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQv ZWJpZ2dlcnMvbGludXguZ2l0IGxpYi1jcmMtYXJjaC12Mgo+ID4gPiA+Cj4gPiA+ID4gVGhpcyBz ZXJpZXMgaW1wcm92ZXMgaG93IGxpYi9jcmMgc3VwcG9ydHMgYXJjaC1vcHRpbWl6ZWQgY29kZS4g IEZpcnN0LAo+ID4gPiA+IGluc3RlYWQgb2YgdGhlIGFyY2gtb3B0aW1pemVkIENSQyBjb2RlIGJl aW5nIGluIGFyY2gvJChTUkNBUkNIKS9saWIvLCBpdAo+ID4gPiA+IHdpbGwgbm93IGJlIGluIGxp Yi9jcmMvJChTUkNBUkNIKS8uICBTZWNvbmQsIHRoZSBBUEkgZnVuY3Rpb25zIChlLmcuCj4gPiA+ ID4gY3JjMzJjKCkpLCBhcmNoLW9wdGltaXplZCBmdW5jdGlvbnMgKGUuZy4gY3JjMzJjX2FyY2go KSksIGFuZCBnZW5lcmljCj4gPiA+ID4gZnVuY3Rpb25zIChlLmcuIGNyYzMyY19iYXNlKCkpIHdp bGwgbm93IGJlIHBhcnQgb2YgYSBzaW5nbGUgbW9kdWxlIGZvcgo+ID4gPiA+IGVhY2ggQ1JDIHR5 cGUsIGFsbG93aW5nIGJldHRlciBpbmxpbmluZyBhbmQgZGVhZCBjb2RlIGVsaW1pbmF0aW9uLiAg VGhlCj4gPiA+ID4gc2Vjb25kIGNoYW5nZSBpcyBtYWRlIHBvc3NpYmxlIGJ5IHRoZSBmaXJzdC4K PiA+ID4gPgo+ID4gPiA+IEFzIGFuIGV4YW1wbGUsIGNvbnNpZGVyIENPTkZJR19DUkMzMj1tIG9u IHg4Ni4gIFdlJ2xsIG5vdyBoYXZlIGp1c3QKPiA+ID4gPiBjcmMzMi5rbyBpbnN0ZWFkIG9mIGJv dGggY3JjMzIteDg2LmtvIGFuZCBjcmMzMi5rby4gIFRoZSB0d28gbW9kdWxlcwo+ID4gPiA+IHdl cmUgYWxyZWFkeSBjb3VwbGVkIHRvZ2V0aGVyIGFuZCBhbHdheXMgYm90aCBnb3QgbG9hZGVkIHRv Z2V0aGVyIHZpYQo+ID4gPiA+IGRpcmVjdCBzeW1ib2wgZGVwZW5kZW5jeSwgc28gdGhlIHNlcGFy YXRpb24gcHJvdmlkZWQgbm8gYmVuZWZpdC4KPiA+ID4gPgo+ID4gPiA+IE5vdGU6IGxhdGVyIEkn ZCBsaWtlIHRvIGFwcGx5IHRoZSBzYW1lIGRlc2lnbiB0byBsaWIvY3J5cHRvLyB0b28sIHdoZXJl Cj4gPiA+ID4gb2Z0ZW4gdGhlIEFQSSBmdW5jdGlvbnMgYXJlIG91dC1vZi1saW5lIHNvIHRoaXMg d2lsbCB3b3JrIGV2ZW4gYmV0dGVyLgo+ID4gPiA+IEluIHRob3NlIGNhc2VzLCBmb3IgZWFjaCBh bGdvcml0aG0gd2UgY3VycmVudGx5IGhhdmUgMyBtb2R1bGVzIGFsbAo+ID4gPiA+IGNvdXBsZWQg dG9nZXRoZXIsIGUuZy4gbGlic2hhMjU2LmtvLCBsaWJzaGEyNTYtZ2VuZXJpYy5rbywgYW5kCj4g PiA+ID4gc2hhMjU2LXg4Ni5rby4gIFdlIHNob3VsZCBoYXZlIGp1c3Qgb25lLCBpbmxpbmUgdGhp bmdzIHByb3Blcmx5LCBhbmQKPiA+ID4gPiByZWx5IG9uIHRoZSBjb21waWxlcidzIGRlYWQgY29k ZSBlbGltaW5hdGlvbiB0byBkZWNpZGUgdGhlIGluY2x1c2lvbiBvZgo+ID4gPiA+IHRoZSBnZW5l cmljIGNvZGUgaW5zdGVhZCBvZiBtYW51YWxseSBzZXR0aW5nIGl0IHZpYSBrY29uZmlnLgo+ID4g PiA+Cj4gPiA+ID4gSGF2aW5nIGFyY2gtc3BlY2lmaWMgY29kZSBvdXRzaWRlIGFyY2gvIHdhcyBz b21ld2hhdCBjb250cm92ZXJzaWFsIHdoZW4KPiA+ID4gPiBaaW5jIHByb3Bvc2VkIGl0IGJhY2sg aW4gMjAxOC4gIEJ1dCBJIGRvbid0IHRoaW5rIHRoZSBjb25jZXJucyBhcmUKPiA+ID4gPiB3YXJy YW50ZWQuICBJdCdzIGJldHRlciBmcm9tIGEgdGVjaG5pY2FsIHBlcnNwZWN0aXZlLCBhcyBpdCBl bmFibGVzIHRoZQo+ID4gPiA+IGltcHJvdmVtZW50cyBtZW50aW9uZWQgYWJvdmUuICBUaGlzIG1v ZGVsIGlzIGFscmVhZHkgc3VjY2Vzc2Z1bGx5IHVzZWQKPiA+ID4gPiBpbiBvdGhlciBwbGFjZXMg aW4gdGhlIGtlcm5lbCBzdWNoIGFzIGxpYi9yYWlkNi8uICBUaGUgY29tbXVuaXR5IG9mIGVhY2gK PiA+ID4gPiBhcmNoaXRlY3R1cmUgc3RpbGwgcmVtYWlucyBmcmVlIHRvIHdvcmsgb24gdGhlIGNv ZGUsIGV2ZW4gaWYgaXQncyBub3QgaW4KPiA+ID4gPiBhcmNoLy4gIEF0IHRoZSB0aW1lIHRoZXJl IHdhcyBhbHNvIGEgZGVzaXJlIHRvIHB1dCB0aGUgbGlicmFyeSBjb2RlIGluCj4gPiA+ID4gdGhl IHNhbWUgZmlsZXMgYXMgdGhlIG9sZC1zY2hvb2wgY3J5cHRvIEFQSSwgYnV0IHRoYXQgd2FzIGEg bWlzdGFrZTsgbm93Cj4gPiA+ID4gdGhhdCB0aGUgbGlicmFyeSBpcyBzZXBhcmF0ZSwgdGhhdCdz IG5vIGxvbmdlciBhIGNvbnN0cmFpbnQgZWl0aGVyLgo+ID4gPgo+ID4gPiBRdWljayBxdWVzdGlv biwgYW5kIGFwb2xvZ2llcyBpZiB0aGlzIGhhcyBiZWVuIGNvdmVyZWQgZWxzZXdoZXJlLgo+ID4g Pgo+ID4gPiBXaHkgbm90IGp1c3QgdXNlIGNob2ljZSBibG9ja3MgaW4gS2NvbmZpZyB0byBjaG9v c2UgdGhlIGNvbXBpbGVkLWluCj4gPiA+IGNyYzMyIHZhcmlhbnQgaW5zdGVhZCBvZiB0aGlzIHNv bWV3aGF0IGluZGlyZWN0IHNjaGVtZT8KPiA+ID4KPiA+ID4gVGhpcyB3b3VsZCBrZWVwIHRoZSBk ZXBlbmRlbmNpZXMgZ3JvdXBlZCBieSBhcmNoIGFuZCBwcm92aWRlIGEgc2luZ2xlIHBsYWNlIHRv Cj4gPiA+IGNob29zZSB3aGV0aGVyIHRoZSBnZW5lcmljIG9yIGFyY2gtc3BlY2lmaWMgbWV0aG9k IGlzIHVzZWQuCj4gPgo+ID4gSXQncyBub3QgY2xlYXIgZXhhY3RseSB3aGF0IHlvdSdyZSBzdWdn ZXN0aW5nLCBidXQgaXQgc291bmRzIGxpa2UgeW91J3JlCj4gPiBjb21wbGFpbmluZyBhYm91dCB0 aGlzOgo+ID4KPiA+ICAgICBjb25maWcgQ1JDMzJfQVJDSAo+ID4gICAgICAgICAgICAgYm9vbAo+ ID4gICAgICAgICAgICAgZGVwZW5kcyBvbiBDUkMzMiAmJiBDUkNfT1BUSU1JWkFUSU9OUwo+ID4g ICAgICAgICAgICAgZGVmYXVsdCB5IGlmIEFSTSAmJiBLRVJORUxfTU9ERV9ORU9OCj4gPiAgICAg ICAgICAgICBkZWZhdWx0IHkgaWYgQVJNNjQKPiA+ICAgICAgICAgICAgIGRlZmF1bHQgeSBpZiBM T09OR0FSQ0gKPiA+ICAgICAgICAgICAgIGRlZmF1bHQgeSBpZiBNSVBTICYmIENQVV9NSVBTUjYK PiA+ICAgICAgICAgICAgIGRlZmF1bHQgeSBpZiBQUEM2NCAmJiBBTFRJVkVDCj4gPiAgICAgICAg ICAgICBkZWZhdWx0IHkgaWYgUklTQ1YgJiYgUklTQ1ZfSVNBX1pCQwo+ID4gICAgICAgICAgICAg ZGVmYXVsdCB5IGlmIFMzOTAKPiA+ICAgICAgICAgICAgIGRlZmF1bHQgeSBpZiBTUEFSQzY0Cj4g PiAgICAgICAgICAgICBkZWZhdWx0IHkgaWYgWDg2Cj4gCj4gSSB3YXMgc3VnZ2VzdGluZyBzb21l dGhpbmcgcm91Z2hseSBsaWtlOgo+IAo+IGNob2ljZQo+ICAgICBwcm9tcHQgIkNSQzMyIFZhcmlh bnQiCj4gICAgIGRlcGVuZHMgb24gQ1JDMzIgJiYgQ1JDX09QVElNSVpBVElPTlMKPiAKPiBjb25m aWcgQ1JDMzJfQVJDSF9BUk1fTkVPTgo+ICAgICBib29sICJBUk0gTkVPTiIKPiAgICAgZGVmYXVs dCB5Cj4gICAgIGRlcGVuZHMgQVJNICYmIEtFUk5FTF9NT0RFX05FT04KPiAKPiAuLi4KPiAKPiBj b25maWcgQ1JDMzJfR0VORVJJQwo+ICAgICBib29sICJHZW5lcmljIgo+IAo+IGVuZGNob2ljZQo+ IAo+ID4gVGhpcyBwYXRjaHNldCBzdHJpa2VzIGEgYmFsYW5jZSB3aGVyZSB0aGUgdmFzdCBtYWpv cml0eSBvZiB0aGUgYXJjaC1zcGVjaWZpYyBDUkMKPiA+IGNvZGUgaXMgaXNvbGF0ZWQgaW4gbGli L2NyYy8kKFNSQ0FSQ0gpLCBhbmQgdGhlIGV4Y2VwdGlvbnMgYXJlIGp1c3QKPiA+IGxpYi9jcmMv TWFrZWZpbGUgYW5kIGxpYi9jcmMvS2NvbmZpZy4gIEkgdGhpbmsgdGhlc2UgZXhjZXB0aW9ucyBt YWtlIHNlbnNlLAo+ID4gZ2l2ZW4gdGhhdCB3ZSdyZSBidWlsZGluZyBhIHNpbmdsZSBtb2R1bGUg cGVyIENSQyB2YXJpYW50LiAgV2UnZCBoYXZlIHRvIGdvCj4gPiB0aHJvdWdoIHNvbWUgaG9vcHMg dG8gaXNvbGF0ZSB0aGUgYXJjaC1zcGVjaWZpYyBLY29uZmlnIGFuZCBNYWtlZmlsZSBzbmlwcGV0 cwo+ID4gaW50byBwZXItYXJjaCBmaWxlcywgd2hpY2ggZG9uJ3Qgc2VlbSB3b3J0aCBpdCBoZXJl IElNTy4KPiAKPiBJIHdhcyBvbmx5IHJlYWxseSBjb25jZXJuZWQgd2l0aCB0aGUgS2NvbmZpZyBz dHJ1Y3R1cmUsIEkgd2FzCj4gZXhwZWN0aW5nIEtidWlsZCB0byBsb29rIHJvdWdobHkgbGlrZSB0 aGlzOiAoZmlsZW5hbWVzIGFyZSB3cm9uZykKPiAKPiBjcmMzMi15ICs9IGNyYzMyLWJhc2Uubwo+ IGNyYzMyLSQoQ1JDMzJfQVJDSF9BUk1fTkVPTikgKz0gYXJjaC9hcm0vY3JjMzItbmVvbi5vCj4g Li4uCj4gY3JjMzItJChDUkMzMl9HRU5FUklDKSArPSBjcmMzMi1nZW5lcmljLm8KPiAKPiBidXQg eWVhaCwgeW91ciBwcm9wb3NhbCBoZXJlIGhhcyBncm93biBvbiBtZSBub3cgdGhhdCBJIHRoaW5r IGFib3V0IGl0Cj4gYW5kIHRoZSBvbmx5IHJlYWwgImJlbmVmaXQiIG1pbmUgaGFzIGlzIHRoYXQg YXJjaGl0ZWN0dXJlcyBjYW4gZGlzcGxheQo+IGNob2ljZXMgZm9yIHZhcmlhbnRzIHRoYXQgaGF2 ZSBLY29uZmlnLXZpc2libGUgcmVxdWlyZW1lbnRzLCB3aGljaAo+IHByb2JhYmx5IGlzbid0IHRo YXQgbWFueSBzbyBpdCB3b3VsZG4ndCBiZSB1c2VmdWwgaW4gcHJhY3RpY2UuCj4gCj4gVGhhbmtz IGZvciBhbnN3ZXJpbmcgbXkgcXVlc3Rpb24sCgpUaGUgQ1JDMzIgaW1wbGVtZW50YXRpb24gZGlk IHVzZWQgdG8gYmUgdXNlci1zZWxlY3RhYmxlLCBidXQgdGhhdCB3YXMgYWxyZWFkeQpyZW1vdmVk IGluIHY2LjE0IChleGNlcHQgZm9yIHRoZSBjb2Fyc2UtZ3JhaW5lZCBrbm9iIENPTkZJR19DUkNf T1BUSU1JWkFUSU9OUwp0aGF0IHJlbWFpbnMgYW5kIGNhbiBiZSBkaXNhYmxlZCBvbmx5IHdoZW4g Q09ORklHX0VYUEVSVD15KSBzaW5jZSB0aGUgdmFzdAptYWpvcml0eSBvZiB1c2VycyBzaW1wbHkg d2FudCB0aGUgb3B0aW1pemVkIENSQzMyIGNvZGUgZW5hYmxlZC4gIFRoZSBmYWN0IHRoYXQKaXQg d2Fzbid0IGp1c3QgZW5hYmxlZCBieSBkZWZhdWx0IHdhcyBhIGxvbmdzdGFuZGluZyBidWcuCgot IEVyaWMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK