All of lore.kernel.org
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul@sk.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: willy@infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel_team@skhynix.com, almasrymina@google.com,
	ilias.apalodimas@linaro.org, harry.yoo@oracle.com,
	hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net,
	john.fastabend@gmail.com, andrew+netdev@lunn.ch,
	asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com,
	edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com,
	leon@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	david@redhat.com, lorenzo.stoakes@oracle.com,
	Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, horms@kernel.org,
	linux-rdma@vger.kernel.org, bpf@vger.kernel.org,
	vishal.moola@gmail.com
Subject: Re: [PATCH net-next 1/9] netmem: introduce struct netmem_desc mirroring struct page
Date: Tue, 10 Jun 2025 10:30:01 +0900	[thread overview]
Message-ID: <20250610013001.GA65598@system.software.com> (raw)
In-Reply-To: <20250609123255.18f14000@kernel.org>

On Mon, Jun 09, 2025 at 12:32:55PM -0700, Jakub Kicinski wrote:
> On Mon,  9 Jun 2025 13:32:17 +0900 Byungchul Park wrote:
> > To simplify struct page, the page pool members of struct page should be
> > moved to other, allowing these members to be removed from struct page.
> > 
> > Introduce a network memory descriptor to store the members, struct
> > netmem_desc, and make it union'ed with the existing fields in struct
> > net_iov, allowing to organize the fields of struct net_iov.
> 
> What's the intended relation between the types?

One thing I'm trying to achieve is to remove pp fields from struct page,
and make network code use struct netmem_desc { pp fields; } instead of
sturc page for that purpose.

The reason why I union'ed it with the existing pp fields in struct
net_iov *temporarily* for now is, to fade out the existing pp fields
from struct net_iov so as to make the final form like:

	strcut net_iov {
		struct netmem_desc desc;

		net_iov_specific_variable_1;
		net_iov_specific_variable_2;
		...
	};

> netmem_ref exists to clearly indicate that memory may not be readable.
> Majority of memory we expect to allocate from page pool must be
> kernel-readable. What's the plan for reading the "single pointer"
> memory within the kernel?
> 
> I think you're approaching this problem from the easiest and least

No, I've never looked for the easiest way.  My bad if there are a better
way to achieve it.  What would you recommend?

> relevant direction. Are you coordinating with David Howells?

It's mm's project driven by Matthew Wilcox but as for page pool part,
I'm working alone.

   https://kernelnewbies.org/MatthewWilcox/Memdescs/Path

	Byungchul

  reply	other threads:[~2025-06-10  1:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09  4:32 [PATCH net-next 0/9] Split netmem from struct page Byungchul Park
2025-06-09  4:32 ` [PATCH net-next 1/9] netmem: introduce struct netmem_desc mirroring " Byungchul Park
2025-06-09 19:32   ` Jakub Kicinski
2025-06-10  1:30     ` Byungchul Park [this message]
2025-06-12  1:55       ` Jakub Kicinski
2025-06-13  1:13         ` Byungchul Park
2025-06-14  2:19           ` Mina Almasry
2025-06-17  2:31             ` netmem series needs some love and Acks from MM folks Harry Yoo
2025-06-17 16:09               ` David Hildenbrand
2025-06-17 16:32                 ` Harry Yoo
2025-06-18  0:08                 ` Byungchul Park
2025-06-18  7:51                   ` Pavel Begunkov
2025-06-20  4:12             ` [PATCH net-next 1/9] netmem: introduce struct netmem_desc mirroring struct page Byungchul Park
2025-06-11 20:53     ` Mina Almasry
2025-06-12  1:58       ` Jakub Kicinski
2025-06-17  2:20   ` Harry Yoo
2025-06-19  9:32   ` Vlastimil Babka
2025-06-09  4:32 ` [PATCH net-next 2/9] page_pool: rename page_pool_return_page() to page_pool_return_netmem() Byungchul Park
2025-06-10 11:15   ` Ilias Apalodimas
2025-06-09  4:32 ` [PATCH net-next 3/9] page_pool: rename __page_pool_release_page_dma() to __page_pool_release_netmem_dma() Byungchul Park
2025-06-10 11:11   ` Ilias Apalodimas
2025-06-09  4:32 ` [PATCH net-next 4/9] page_pool: rename __page_pool_alloc_pages_slow() to __page_pool_alloc_netmems_slow() Byungchul Park
2025-06-09  4:32 ` [PATCH net-next 5/9] netmem: use _Generic to cover const casting for page_to_netmem() Byungchul Park
2025-06-09  4:32 ` [PATCH net-next 6/9] netmem: remove __netmem_get_pp() Byungchul Park
2025-06-10 11:11   ` Ilias Apalodimas
2025-06-09  4:32 ` [PATCH net-next 7/9] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Byungchul Park
2025-06-09  4:32 ` [PATCH net-next 8/9] netmem: introduce a netmem API, virt_to_head_netmem() Byungchul Park
2025-06-09  4:32 ` [PATCH net-next 9/9] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() Byungchul Park
2025-06-09 17:39   ` Mina Almasry
2025-06-10  1:45     ` Byungchul Park
2025-06-11 14:30       ` Pavel Begunkov
2025-06-12  0:39         ` Byungchul Park
2025-06-17  2:37         ` Harry Yoo
2025-06-19  9:55   ` Vlastimil Babka
2025-06-19 10:42     ` Byungchul Park
2025-06-09  6:49 ` [PATCH net-next 0/9] Split netmem from struct page Byungchul Park
2025-06-11 14:25 ` Pavel Begunkov
2025-06-11 20:48   ` Mina Almasry
2025-06-12  0:40     ` Byungchul Park
2025-06-16  7:45     ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250610013001.GA65598@system.software.com \
    --to=byungchul@sk.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=asml.silence@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david@redhat.com \
    --cc=edumazet@google.com \
    --cc=harry.yoo@oracle.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=john.fastabend@gmail.com \
    --cc=kernel_team@skhynix.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rppt@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=surenb@google.com \
    --cc=tariqt@nvidia.com \
    --cc=toke@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.