All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Yu Kuai <yukuai1@huaweicloud.com>,
	Ming Lei <ming.lei@redhat.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH 1/2] block: Make __submit_bio_noacct() preserve the bio submission order
Date: Tue, 10 Jun 2025 07:04:15 +0200	[thread overview]
Message-ID: <20250610050415.GA25014@lst.de> (raw)
In-Reply-To: <a0c89df8-4b33-409c-ba43-f9543fb1b091@acm.org>

On Mon, Jun 09, 2025 at 01:48:06PM -0700, Bart Van Assche wrote:
> On 6/8/25 3:47 PM, Damien Le Moal wrote:
>> So yes, we need a fix. Can you work on one ?
>
> The patch below seems to be sufficient but I'm not sure whether this
> approach is acceptable:

It's still the wrong approach.  Please add the splitting needed for
the blk-crypt fallback to __bio_split_to_limits instead.


  reply	other threads:[~2025-06-10  5:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 20:29 [PATCH 0/2] Two bug fixes for zoned block devices Bart Van Assche
2025-05-14 20:29 ` [PATCH 1/2] block: Make __submit_bio_noacct() preserve the bio submission order Bart Van Assche
2025-05-15  7:19   ` Niklas Cassel
2025-05-15 15:58     ` Bart Van Assche
2025-05-16  4:47   ` Christoph Hellwig
2025-05-19 22:12     ` Bart Van Assche
2025-05-20 13:56       ` Christoph Hellwig
2025-05-20 18:09         ` Bart Van Assche
2025-05-21  5:53           ` Christoph Hellwig
2025-05-21 21:18             ` Bart Van Assche
2025-05-22  5:12               ` Damien Le Moal
2025-05-22 17:08                 ` Bart Van Assche
2025-05-23  6:02                   ` Damien Le Moal
2025-05-23 16:30                     ` Bart Van Assche
2025-05-24  8:48                       ` Damien Le Moal
2025-05-24 14:05                         ` Bart Van Assche
2025-05-24 15:36                           ` Damien Le Moal
2025-05-26  5:24                       ` Christoph Hellwig
2025-05-27 16:19                         ` Bart Van Assche
2025-05-31  0:25                           ` Bart Van Assche
2025-06-08 22:07                         ` Bart Van Assche
2025-06-08 22:47                           ` Damien Le Moal
2025-06-09  3:58                             ` Christoph Hellwig
2025-06-09 20:48                             ` Bart Van Assche
2025-06-10  5:04                               ` Christoph Hellwig [this message]
2025-06-09  3:55                           ` Christoph Hellwig
2025-06-10 17:23                             ` Bart Van Assche
2025-06-10 23:18                               ` Keith Busch
2025-06-11  0:46                                 ` Damien Le Moal
2025-06-11  1:00                                   ` Keith Busch
2025-06-11  1:02                                     ` Damien Le Moal
2025-06-11  1:08                                       ` Keith Busch
2025-06-11  1:34                                 ` Keith Busch
2025-06-11  3:40                                 ` Christoph Hellwig
2025-06-11  4:21                                   ` Eric Biggers
2025-06-11 16:15                                     ` Bart Van Assche
2025-06-11 18:15                                       ` Eric Biggers
2025-06-11 19:43                                         ` Bart Van Assche
2025-06-18 22:27                                           ` Bart Van Assche
2025-05-23  4:21               ` Christoph Hellwig
2025-05-14 20:29 ` [PATCH 2/2] block: Fix a deadlock related freezing zoned storage devices Bart Van Assche
2025-05-16  4:51   ` Christoph Hellwig
2025-05-19 22:22     ` Bart Van Assche
2025-05-20 13:57       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250610050415.GA25014@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=yukuai1@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.