From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Franzki <ifranzki@linux.ibm.com>,
freude@linux.ibm.com, dengler@linux.ibm.com
Subject: [PATCH] crypto: hkdf - move to late_initcall
Date: Tue, 10 Jun 2025 12:16:00 -0700 [thread overview]
Message-ID: <20250610191600.54994-1-ebiggers@kernel.org> (raw)
In-Reply-To: <8bf5f1b2-db97-4923-aab0-0d2a8b269221@linux.ibm.com>
From: Eric Biggers <ebiggers@google.com>
The HKDF self-tests depend on the HMAC algorithms being registered.
HMAC is now registered at module_init, which put it at the same level as
HKDF. Move HKDF to late_initcall so that it runs afterwards.
Fixes: ef93f1562803 ("Revert "crypto: run initcalls for generic implementations earlier"")
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/hkdf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/hkdf.c b/crypto/hkdf.c
index f24c2a8d4df99..82d1b32ca6ce4 100644
--- a/crypto/hkdf.c
+++ b/crypto/hkdf.c
@@ -564,10 +564,10 @@ static int __init crypto_hkdf_module_init(void)
return 0;
}
static void __exit crypto_hkdf_module_exit(void) {}
-module_init(crypto_hkdf_module_init);
+late_initcall(crypto_hkdf_module_init);
module_exit(crypto_hkdf_module_exit);
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("HMAC-based Key Derivation Function (HKDF)");
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
--
2.49.0
next prev parent reply other threads:[~2025-06-10 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:26 CI: Another strange crypto message in syslog Ingo Franzki
2025-06-05 14:26 ` Eric Biggers
2025-06-06 7:19 ` Harald Freudenberger
2025-06-06 17:45 ` Eric Biggers
2025-06-16 10:50 ` Harald Freudenberger
2025-06-16 15:58 ` Eric Biggers
2025-06-10 12:37 ` Ingo Franzki
2025-06-10 19:16 ` Eric Biggers [this message]
2025-06-11 3:03 ` [PATCH] crypto: hkdf - move to late_initcall Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610191600.54994-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=dengler@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=ifranzki@linux.ibm.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.