From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, linux@armlinux.org.uk,
hkallweit1@gmail.com, andrew@lunn.ch, davem@davemloft.net,
pabeni@redhat.com
Subject: Re: [net-next PATCH 3/6] fbnic: Replace 'link_mode' with 'aui'
Date: Wed, 11 Jun 2025 14:00:32 -0700 [thread overview]
Message-ID: <20250611140032.1b95633f@kernel.org> (raw)
In-Reply-To: <174956708824.2686723.3456558312805136408.stgit@ahduyck-xeon-server.home.arpa>
On Tue, 10 Jun 2025 07:51:28 -0700 Alexander Duyck wrote:
> -static void fbnic_pcs_get_fw_settings(struct fbnic_dev *fbd)
> +static void fbnic_mac_get_fw_settings(struct fbnic_dev *fbd, u8 *aui, u8 *fec)
We get a transient "unused function" warning on this patch.
Looks like the next patch adds a declaration in the header,
let's do it here to avoid the warning?
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-11 21:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 14:51 [net-next PATCH 0/6] Add support for 25G, 50G, and 100G to fbnic Alexander Duyck
2025-06-10 14:51 ` [net-next PATCH 1/6] net: phy: Add interface types for 50G and 100G Alexander Duyck
2025-06-10 14:51 ` [net-next PATCH 2/6] fbnic: Do not consider mailbox "initialized" until we have verified fw version Alexander Duyck
2025-06-10 14:51 ` [net-next PATCH 3/6] fbnic: Replace 'link_mode' with 'aui' Alexander Duyck
2025-06-11 21:00 ` Jakub Kicinski [this message]
2025-06-11 21:17 ` Alexander Duyck
2025-06-10 14:51 ` [net-next PATCH 4/6] fbnic: Set correct supported modes and speeds based on FW setting Alexander Duyck
2025-06-10 14:51 ` [net-next PATCH 5/6] fbnic: Add support for reporting link config Alexander Duyck
2025-06-10 14:51 ` [net-next PATCH 6/6] fbnic: Add support for setting/getting pause configuration Alexander Duyck
2025-06-12 9:42 ` [net-next PATCH 0/6] Add support for 25G, 50G, and 100G to fbnic Leon Romanovsky
2025-06-12 12:41 ` Andrew Lunn
2025-06-12 17:31 ` Leon Romanovsky
2025-06-12 18:29 ` Andrew Lunn
2025-06-13 16:00 ` Leon Romanovsky
2025-06-13 22:43 ` Russell King (Oracle)
2025-06-14 16:26 ` Alexander Duyck
2025-06-16 9:49 ` Russell King (Oracle)
2025-06-16 15:27 ` Alexander Duyck
2025-06-16 10:33 ` Leon Romanovsky
2025-06-16 11:35 ` Russell King (Oracle)
2025-06-16 15:19 ` Leon Romanovsky
2025-06-16 14:39 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611140032.1b95633f@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.