From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94CE1125B2 for ; Thu, 12 Jun 2025 04:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749703671; cv=none; b=DegzQf9RsuxW++zMtiNzDXHn5/dSK3j7SmoRxK1AjP80xo+2ml/rzlrAPvrOPvQUF1aeF/s+8lVcQMXuL/cS6pUkT7PGLyfuZrFvfRTi7+1KKl72JddjhtlIyl+tuwuHCmFI1nnRzbfdyrWQ1ecrFcALjM9cjybyigyC4M35nPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749703671; c=relaxed/simple; bh=eYItOdFLi7G0YIaWAGU9SVXHNxF9FM0zycgn2Pn9pKE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cs5mkJ/y+DvBMbqtEXYlgxdN813Gvz49v71p4PklA9pwNMWEEsM7+1Lb8jOsFfSuJ1YjV3SHjwb0IfbTMnJUH9A3Gk7rEMC3uo+d4rfpH9i6tyZn2ki/xYXoFPrf2kFMCKyH6vH1a8vnHGT17M2ylm31ch9f1RIMACzX8snvwNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 7C82B68D09; Thu, 12 Jun 2025 06:47:44 +0200 (CEST) Date: Thu, 12 Jun 2025 06:47:44 +0200 From: Christoph Hellwig To: Zhang Yi Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu, djwong@kernel.org, john.g.garry@oracle.com, bmarzins@redhat.com, chaitanyak@nvidia.com, shinichiro.kawasaki@wdc.com, brauner@kernel.org, martin.petersen@oracle.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features Message-ID: <20250612044744.GA12828@lst.de> References: <20250604020850.1304633-1-yi.zhang@huaweicloud.com> <20250604020850.1304633-2-yi.zhang@huaweicloud.com> <20250611060900.GA4613@lst.de> <343f7f06-9bf6-442f-8e77-0a774203ec3f@huaweicloud.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <343f7f06-9bf6-442f-8e77-0a774203ec3f@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jun 11, 2025 at 03:31:21PM +0800, Zhang Yi wrote: > >> +/* supports unmap write zeroes command */ > >> +#define BLK_FEAT_WRITE_ZEROES_UNMAP ((__force blk_features_t)(1u << 17)) > > > > > > Should this be exposed through sysfs as a read-only value? > > Uh, are you suggesting adding another sysfs interface to expose > this feature? That was the idea. Or do we have another way to report this capability?