From: Damien Le Moal <dlemoal@kernel.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: [PATCH v3 1/2] scsi: sd: Prevent logical_to_bytes() from returning overflowed values
Date: Thu, 12 Jun 2025 15:02:10 +0900 [thread overview]
Message-ID: <20250612060211.1970933-2-dlemoal@kernel.org> (raw)
In-Reply-To: <20250612060211.1970933-1-dlemoal@kernel.org>
Make sure that logical_to_bytes() does not return an overflowed value
by changing its return type from unsigned int (32-bits) to size_t
(64-bits).
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/scsi/sd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
index 36382eca941c..3803eb8cb532 100644
--- a/drivers/scsi/sd.h
+++ b/drivers/scsi/sd.h
@@ -213,7 +213,7 @@ static inline sector_t logical_to_sectors(struct scsi_device *sdev, sector_t blo
return blocks << (ilog2(sdev->sector_size) - 9);
}
-static inline unsigned int logical_to_bytes(struct scsi_device *sdev, sector_t blocks)
+static inline size_t logical_to_bytes(struct scsi_device *sdev, sector_t blocks)
{
return blocks * sdev->sector_size;
}
--
2.49.0
next prev parent reply other threads:[~2025-06-12 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 6:02 [PATCH v3 0/2] Improve optimal IO size initialization Damien Le Moal
2025-06-12 6:02 ` Damien Le Moal [this message]
2025-06-12 15:53 ` [PATCH v3 1/2] scsi: sd: Prevent logical_to_bytes() from returning overflowed values Bart Van Assche
2025-06-13 5:55 ` Damien Le Moal
2025-06-12 6:02 ` [PATCH v3 2/2] scsi: sd: Set a default optimal IO size if one is not defined Damien Le Moal
2025-06-12 15:55 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612060211.1970933-2-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.