From: Jakub Kicinski <kuba@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jijie Shao <shaojijie@huawei.com>,
Arnd Bergmann <arnd@kernel.org>,
Jian Shen <shenjian15@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Hao Lan <lanhao@huawei.com>,
Guangwei Zhang <zhangwangwei6@huawei.com>,
Netdev <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<llvm@lists.linux.dev>
Subject: Re: [PATCH] hns3: work around stack size warning
Date: Thu, 12 Jun 2025 07:32:53 -0700 [thread overview]
Message-ID: <20250612073253.2abdd54e@kernel.org> (raw)
In-Reply-To: <34d9d8f7-384e-4447-90e2-7c6694ecbb05@huawei.com>
On Thu, 12 Jun 2025 21:09:40 +0800 Jijie Shao wrote:
> >> Would you please help test whether the following changes have solved
> >> your problem,
> >> And I'm not sure if this patch should be sent to net or net-next...
> > Your patch arrived with whitespace corruption here, so I could not
> > try it, but I'm sure it would help avoid the warning.
> >
> > However, this is not what meant with my suggestion: you already
> > allocate a temporary buffer in hns3_dbg_open() and I would
> > expect it to be possible to read into that buffer directly
> > without a second temporary buffer (on stack or kmalloc).
> >
> > The normal way of doing this would be to use the infrastructure
> > from seq_file and then seq_printf() and not have any extra buffers
> > on top of that.
>
> seq_file is good. But the change is quite big.
> I need to discuss it internally, and it may not be completed so quickly.
> I will also need consider the maintainer's suggestion.
Arnd, do you mind waiting? We can apply your patch as is if the warning
is a nuisance.
next prev parent reply other threads:[~2025-06-12 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 9:21 [PATCH] hns3: work around stack size warning Arnd Bergmann
2025-06-10 16:08 ` Andrew Lunn
2025-06-11 2:10 ` Jijie Shao
2025-06-11 16:36 ` Arnd Bergmann
2025-06-12 13:09 ` Jijie Shao
2025-06-12 14:32 ` Jakub Kicinski [this message]
2025-06-12 15:27 ` Arnd Bergmann
2025-06-12 15:33 ` Jakub Kicinski
2025-06-13 5:59 ` Jijie Shao
2025-06-23 2:30 ` Jijie Shao
2025-06-23 3:19 ` Jijie Shao
2025-06-23 5:56 ` Arnd Bergmann
2025-06-23 6:21 ` Jijie Shao
2025-06-23 7:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612073253.2abdd54e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=justinstitt@google.com \
--cc=lanhao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=zhangwangwei6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.