From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: pavan.chebbi@broadcom.com, willemdebruijn.kernel@gmail.com,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Subject: Re: [RFC net-next 4/6] eth: bnxt: support RSS on IPv6 Flow Label
Date: Thu, 12 Jun 2025 18:04:44 -0700 [thread overview]
Message-ID: <20250612180444.5767aeec@kernel.org> (raw)
In-Reply-To: <CACKFLin1Y=XTJcWQQwR=aDnpEvjdYVYaKgJZDAYGQvWzTx=gsg@mail.gmail.com>
On Thu, 12 Jun 2025 17:11:18 -0700 Michael Chan wrote:
> > @@ -1728,6 +1739,13 @@ static int bnxt_srxfh(struct bnxt *bp, struct ethtool_rxnfc *cmd)
> > rss_hash_cfg |= VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6;
> > else if (!tuple)
> > rss_hash_cfg &= ~VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6;
> > +
> > + if (cmd->data & RXH_IP6_FL)
> > + rss_hash_cfg |=
> > + VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL;
>
> Just a quick update on this. The FW call fails when this flag is set.
> I am looking into it.
Thanks for the update! FWIW I'm doing the refactoring to add netlink
support as requested by Andrew:
https://lore.kernel.org/all/20250611145949.2674086-1-kuba@kernel.org/
There's 40 drivers to convert so even if it goes smoothly I wouldn't
be able to repost for another week.
next prev parent reply other threads:[~2025-06-13 1:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 17:34 [RFC net-next 0/6] net: ethtool: support including Flow Label in the flow hash for RSS Jakub Kicinski
2025-06-09 17:34 ` [RFC net-next 1/6] net: ethtool: factor out the validation for ETHTOOL_SRXFH Jakub Kicinski
2025-06-09 17:34 ` [RFC net-next 2/6] net: ethtool: support including Flow Label in the flow hash for RSS Jakub Kicinski
2025-06-10 13:33 ` Willem de Bruijn
2025-06-09 17:34 ` [RFC net-next 3/6] eth: fbnic: support RSS on IPv6 Flow Label Jakub Kicinski
2025-06-09 17:34 ` [RFC net-next 4/6] eth: bnxt: " Jakub Kicinski
2025-06-09 18:24 ` Michael Chan
2025-06-09 18:44 ` Jakub Kicinski
2025-06-09 23:03 ` Michael Chan
2025-06-13 0:11 ` Michael Chan
2025-06-13 1:04 ` Jakub Kicinski [this message]
2025-06-23 4:20 ` Michael Chan
2025-06-09 17:34 ` [RFC net-next 5/6] selftests: drv-net: import things in lib one by one Jakub Kicinski
2025-06-09 17:34 ` [RFC net-next 6/6] selftests: drv-net: add test for RSS on flow label Jakub Kicinski
2025-06-09 18:26 ` [RFC net-next 0/6] net: ethtool: support including Flow Label in the flow hash for RSS Andrew Lunn
2025-06-09 18:58 ` Jakub Kicinski
2025-06-09 19:30 ` Andrew Lunn
2025-06-09 19:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612180444.5767aeec@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.